749626 - Theme update: make the close button code generic and implement the dark theme for menulists.

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Paul Rouget [:paul]]

3 different patches need these changes.

Comment 1

[Paul Rouget [:paul]]

Attachment: patch v0.1

Comment 2

[Paul Rouget [:paul]]

Here is some code to test:

let menulist = document.createElement("menulist");
menulist.className = "devtools-menulist";
let menupopup = document.createElement("menupopup");
menulist.appendChild(menupopup);
let i1 = document.createElement("menuitem"); let i2 = document.createElement("menuitem");
i1.setAttribute("label", "foo"); i2.setAttribute("label", "foo foo bar bar");
menupopup.appendChild(i1); menupopup.appendChild(i2);
InspectorUI.toolbar.appendChild(menulist);

Copy/paste in scratchpad (browser mode). Run with the Inspector open.

Comment 3

[Paul Rouget [:paul]]

Attachment: patch v0.2

Comment 4

[Paul Rouget [:paul]]

Attachment: patch v0.3

osx style

Comment 5

[Paul Rouget [:paul]]

Attachment: patch v0.4

Windows style (includes a fix for some the breadcrumbs)

Comment 6

[Paul Rouget [:paul]]

Attachment: patch v0.999

Comment 7

[Paul Rouget [:paul]]

Attachment: patch v1

Comment 8

[Paul Rouget [:paul]]

Comment on attachment 621600 [details] [diff] [review]
patch v1

This patch includes:
- shared close button style
- fix for the searchinput style
- menulist style
- fix some misalignment and focus-ring problems of the breadcrumbs on Windows

Comment 9

[Paul Rouget [:paul]]

review ping

Comment 10

[Paul Rouget [:paul]]

https://hg.mozilla.org/integration/fx-team/rev/2707febfc98f

Comment 11

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/mozilla-central/rev/2707febfc98f