Theme update: make the close button code generic and implement the dark theme for menulists.

RESOLVED FIXED in Firefox 15

Status

()

Firefox
Developer Tools
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: paul, Assigned: paul)

Tracking

Trunk
Firefox 15
x86
All
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 attachment, 5 obsolete attachments)

(Assignee)

Description

5 years ago
3 different patches need these changes.
(Assignee)

Updated

5 years ago
Blocks: 692409, 749628
(Assignee)

Comment 1

5 years ago
Created attachment 619039 [details] [diff] [review]
patch v0.1
(Assignee)

Updated

5 years ago
Blocks: 744906, 704110
(Assignee)

Updated

5 years ago
Assignee: nobody → paul
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 2

5 years ago
Here is some code to test:

let menulist = document.createElement("menulist");
menulist.className = "devtools-menulist";
let menupopup = document.createElement("menupopup");
menulist.appendChild(menupopup);
let i1 = document.createElement("menuitem"); let i2 = document.createElement("menuitem");
i1.setAttribute("label", "foo"); i2.setAttribute("label", "foo foo bar bar");
menupopup.appendChild(i1); menupopup.appendChild(i2);
InspectorUI.toolbar.appendChild(menulist);

Copy/paste in scratchpad (browser mode). Run with the Inspector open.
(Assignee)

Comment 3

5 years ago
Created attachment 620360 [details] [diff] [review]
patch v0.2
(Assignee)

Updated

5 years ago
Attachment #619039 - Attachment is obsolete: true
(Assignee)

Comment 4

5 years ago
Created attachment 620731 [details] [diff] [review]
patch v0.3

osx style
(Assignee)

Updated

5 years ago
Attachment #620360 - Attachment is obsolete: true
(Assignee)

Comment 5

5 years ago
Created attachment 621542 [details] [diff] [review]
patch v0.4

Windows style (includes a fix for some the breadcrumbs)
(Assignee)

Updated

5 years ago
Attachment #620731 - Attachment is obsolete: true
(Assignee)

Comment 6

5 years ago
Created attachment 621555 [details] [diff] [review]
patch v0.999
(Assignee)

Updated

5 years ago
Attachment #621542 - Attachment is obsolete: true
(Assignee)

Comment 7

5 years ago
Created attachment 621600 [details] [diff] [review]
patch v1
(Assignee)

Updated

5 years ago
Attachment #621555 - Attachment is obsolete: true
(Assignee)

Comment 8

5 years ago
Comment on attachment 621600 [details] [diff] [review]
patch v1

This patch includes:
- shared close button style
- fix for the searchinput style
- menulist style
- fix some misalignment and focus-ring problems of the breadcrumbs on Windows
Attachment #621600 - Flags: review?(dao)
(Assignee)

Comment 9

5 years ago
review ping

Updated

5 years ago
Attachment #621600 - Flags: review?(dao) → review+
(Assignee)

Updated

5 years ago
Whiteboard: [land-in-fx-team]
(Assignee)

Comment 10

5 years ago
https://hg.mozilla.org/integration/fx-team/rev/2707febfc98f
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/2707febfc98f
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 15

Updated

5 years ago
Depends on: 764625

Updated

5 years ago
No longer depends on: 764625
You need to log in before you can comment on or make changes to this bug.