Closed
Bug 749749
Opened 13 years ago
Closed 13 years ago
test-content-worker.test:setTimeout broken after bug 695480 fixed the leak.
Categories
(Add-on SDK Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: KWierso, Assigned: ochameau)
References
Details
Attachments
(1 file)
Prior to bug 695480 landing, test-content-worker.test:setTimeout was passing. Afterwards, it is permanently failing.
info: executing 'test-content-worker.test:setTimeout are unregistered on content unload'
error: An exception occurred.
Traceback (most recent call last):
File "resource://21ef72fb-7dee-4e10-bc16-d7623a5827ff-at-jetpack/api-utils/lib/observer-service.js", line 144, in
this.callback(subject, data);
File "resource://21ef72fb-7dee-4e10-bc16-d7623a5827ff-at-jetpack/api-utils/lib/content/symbiont.js", line 132, in onStar
if (window && window == frame.contentWindow) {
TypeError: can't access dead object
console: [JavaScript Error: "TypeError: can't access dead object" {file: "resource://21ef72fb-7dee-4e10-bc16-d7623a5827ff-at-jetpack/api-utils/lib/cuddlefish.js -> resource://21ef72fb-7dee-4e10-bc16-d7623a5827ff-at-jetpack/api-utils/tests/test-content-worker.js" line: 450}]
error: TEST FAILED: test-content-worker.test:setTimeout are unregistered on content unload (timed out)
This seems to be the only test that was actually broken by bug 695480, but bug 749526 shows that "can't access dead object" error in a lot of other places (that might not be tested?).
Reporter | ||
Updated•13 years ago
|
Severity: normal → major
Assignee | ||
Comment 1•13 years ago
|
||
Note that it doesn't fix:
info: executing 'test-content-worker.test:sample'
...
TypeError: window.location is undefined
That is another bug, tracked in bug 751069.
Assignee: nobody → poirot.alex
Attachment #620231 -
Flags: review?(rFobic)
Updated•13 years ago
|
Attachment #620231 -
Flags: review?(rFobic) → review+
Comment 2•13 years ago
|
||
Commits pushed to master at https://github.com/mozilla/addon-sdk
https://github.com/mozilla/addon-sdk/commit/5ff97af4dcc62fd9c42ac224ffc87a7b4c28899c
Bug 749749: Fix "test-content-worker.test:setTimeout are unregistered on content unload".
bug 695480 now prevents using unloaded content document references,
but we still can use outer window reference until it is finally closed.
https://github.com/mozilla/addon-sdk/commit/0c518ae8122dea1cbc715bc723329cd46b64f70d
Merge pull request #420 from ochameau/bug/749749-fix-test-content-worker-setTimeout
Bug 749749: Fix "test-content-worker.test:setTimeout are unregistered on content unload". r=@mossop
Assignee | ||
Updated•13 years ago
|
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 3•13 years ago
|
||
Commits pushed to stabilization at https://github.com/mozilla/addon-sdk
https://github.com/mozilla/addon-sdk/commit/5ff97af4dcc62fd9c42ac224ffc87a7b4c28899c
Bug 749749: Fix "test-content-worker.test:setTimeout are unregistered on content unload".
https://github.com/mozilla/addon-sdk/commit/0c518ae8122dea1cbc715bc723329cd46b64f70d
Merge pull request #420 from ochameau/bug/749749-fix-test-content-worker-setTimeout
Comment 4•13 years ago
|
||
Commits pushed to release at https://github.com/mozilla/addon-sdk
https://github.com/mozilla/addon-sdk/commit/5ff97af4dcc62fd9c42ac224ffc87a7b4c28899c
Bug 749749: Fix "test-content-worker.test:setTimeout are unregistered on content unload".
https://github.com/mozilla/addon-sdk/commit/0c518ae8122dea1cbc715bc723329cd46b64f70d
Merge pull request #420 from ochameau/bug/749749-fix-test-content-worker-setTimeout
You need to log in
before you can comment on or make changes to this bug.
Description
•