The default bug view has changed. See this FAQ.

Disable --valgrind flag for jit_test.py when running "make check" with AddressSanitizer

RESOLVED FIXED in mozilla15

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: decoder, Assigned: decoder)

Tracking

Trunk
mozilla15
All
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [sg:want][asan-build-blocker][asan-test-blocker])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
In js/src/Makefile.in the jit_test.py script is called with "--valgrind" which causes some tests to timeout because running an ASan binary under valgrind doesn't work.

I'm writing a patch that only passes --valgrind in the Makefile when MOZ_ASAN is not set.
(Assignee)

Comment 1

5 years ago
Created attachment 619528 [details] [diff] [review]
Patch
Assignee: general → choller
Status: NEW → ASSIGNED
Attachment #619528 - Flags: review?(khuey)
Comment on attachment 619528 [details] [diff] [review]
Patch

Review of attachment 619528 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/Makefile.in
@@ +605,5 @@
>  ifneq ($(OS_ARCH),WINNT) # FIXME: this should be made work on Windows too.
>  #check:: check-malloc-function-usage FIXME: disable on JM until closer to merge time.
>  endif
>  
> +ifneq ($(MOZ_ASAN),1)

ifndef MOZ_ASAN
Attachment #619528 - Flags: review?(khuey) → review+
(Assignee)

Comment 3

5 years ago
Created attachment 619535 [details] [diff] [review]
Updated patch

Updated patch, addresses review comment. Keeping r+ from previous patch version.
Attachment #619528 - Attachment is obsolete: true
Attachment #619535 - Flags: review+
Attachment #619535 - Flags: checkin?(gary)
(Assignee)

Comment 4

5 years ago
Marking also as a build blocker because this causes "make check" to run for the maximum allowed time per test using valgrind, rendering the builds very slow.
Whiteboard: [sg:want][asan-build-blocker][asan-test-blocker]
Comment on attachment 619535 [details] [diff] [review]
Updated patch

http://hg.mozilla.org/integration/mozilla-inbound/rev/1ed79aeea82f
Attachment #619535 - Flags: checkin?(gary) → checkin+
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/1ed79aeea82f
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.