Closed
Bug 749768
Opened 12 years ago
Closed 12 years ago
Disable --valgrind flag for jit_test.py when running "make check" with AddressSanitizer
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: decoder, Assigned: decoder)
References
Details
(Whiteboard: [sg:want][asan-build-blocker][asan-test-blocker])
Attachments
(1 file, 1 obsolete file)
1.29 KB,
patch
|
decoder
:
review+
gkw
:
checkin+
|
Details | Diff | Splinter Review |
In js/src/Makefile.in the jit_test.py script is called with "--valgrind" which causes some tests to timeout because running an ASan binary under valgrind doesn't work. I'm writing a patch that only passes --valgrind in the Makefile when MOZ_ASAN is not set.
Assignee | ||
Comment 1•12 years ago
|
||
Comment on attachment 619528 [details] [diff] [review] Patch Review of attachment 619528 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/Makefile.in @@ +605,5 @@ > ifneq ($(OS_ARCH),WINNT) # FIXME: this should be made work on Windows too. > #check:: check-malloc-function-usage FIXME: disable on JM until closer to merge time. > endif > > +ifneq ($(MOZ_ASAN),1) ifndef MOZ_ASAN
Attachment #619528 -
Flags: review?(khuey) → review+
Assignee | ||
Comment 3•12 years ago
|
||
Updated patch, addresses review comment. Keeping r+ from previous patch version.
Attachment #619528 -
Attachment is obsolete: true
Attachment #619535 -
Flags: review+
Attachment #619535 -
Flags: checkin?(gary)
Assignee | ||
Comment 4•12 years ago
|
||
Marking also as a build blocker because this causes "make check" to run for the maximum allowed time per test using valgrind, rendering the builds very slow.
Whiteboard: [sg:want][asan-build-blocker][asan-test-blocker]
Comment 5•12 years ago
|
||
Comment on attachment 619535 [details] [diff] [review] Updated patch http://hg.mozilla.org/integration/mozilla-inbound/rev/1ed79aeea82f
Attachment #619535 -
Flags: checkin?(gary) → checkin+
Updated•12 years ago
|
Target Milestone: --- → mozilla15
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1ed79aeea82f
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•