Last Comment Bug 749768 - Disable --valgrind flag for jit_test.py when running "make check" with AddressSanitizer
: Disable --valgrind flag for jit_test.py when running "make check" with Addres...
Status: RESOLVED FIXED
[sg:want][asan-build-blocker][asan-te...
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All Linux
: -- normal (vote)
: mozilla15
Assigned To: Christian Holler (:decoder)
:
Mentors:
Depends on:
Blocks: 664901
  Show dependency treegraph
 
Reported: 2012-04-27 13:17 PDT by Christian Holler (:decoder)
Modified: 2012-05-02 21:05 PDT (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (2.30 KB, patch)
2012-04-30 05:26 PDT, Christian Holler (:decoder)
khuey: review+
Details | Diff | Review
Updated patch (1.29 KB, patch)
2012-04-30 05:54 PDT, Christian Holler (:decoder)
choller: review+
gary: checkin+
Details | Diff | Review

Description Christian Holler (:decoder) 2012-04-27 13:17:40 PDT
In js/src/Makefile.in the jit_test.py script is called with "--valgrind" which causes some tests to timeout because running an ASan binary under valgrind doesn't work.

I'm writing a patch that only passes --valgrind in the Makefile when MOZ_ASAN is not set.
Comment 1 Christian Holler (:decoder) 2012-04-30 05:26:36 PDT
Created attachment 619528 [details] [diff] [review]
Patch
Comment 2 Kyle Huey [:khuey] (khuey@mozilla.com) 2012-04-30 05:28:33 PDT
Comment on attachment 619528 [details] [diff] [review]
Patch

Review of attachment 619528 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/Makefile.in
@@ +605,5 @@
>  ifneq ($(OS_ARCH),WINNT) # FIXME: this should be made work on Windows too.
>  #check:: check-malloc-function-usage FIXME: disable on JM until closer to merge time.
>  endif
>  
> +ifneq ($(MOZ_ASAN),1)

ifndef MOZ_ASAN
Comment 3 Christian Holler (:decoder) 2012-04-30 05:54:53 PDT
Created attachment 619535 [details] [diff] [review]
Updated patch

Updated patch, addresses review comment. Keeping r+ from previous patch version.
Comment 4 Christian Holler (:decoder) 2012-04-30 05:55:59 PDT
Marking also as a build blocker because this causes "make check" to run for the maximum allowed time per test using valgrind, rendering the builds very slow.
Comment 5 Gary Kwong [:gkw] [:nth10sd] 2012-04-30 07:24:21 PDT
Comment on attachment 619535 [details] [diff] [review]
Updated patch

http://hg.mozilla.org/integration/mozilla-inbound/rev/1ed79aeea82f
Comment 6 :Ehsan Akhgari (busy, don't ask for review please) 2012-05-02 21:05:10 PDT
https://hg.mozilla.org/mozilla-central/rev/1ed79aeea82f

Note You need to log in before you can comment on or make changes to this bug.