749768 - Disable --valgrind flag for jit_test.py when running "make check" with AddressSanitizer

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Christian Holler (:decoder)]

In js/src/Makefile.in the jit_test.py script is called with "--valgrind" which causes some tests to timeout because running an ASan binary under valgrind doesn't work.

I'm writing a patch that only passes --valgrind in the Makefile when MOZ_ASAN is not set.

Comment 1

[Christian Holler (:decoder)]

Attachment: Patch

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 619528 [details] [diff] [review]
Patch

Review of attachment 619528 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/Makefile.in
@@ +605,5 @@
>  ifneq ($(OS_ARCH),WINNT) # FIXME: this should be made work on Windows too.
>  #check:: check-malloc-function-usage FIXME: disable on JM until closer to merge time.
>  endif
>  
> +ifneq ($(MOZ_ASAN),1)

ifndef MOZ_ASAN

Comment 3

[Christian Holler (:decoder)]

Attachment: Updated patch

Updated patch, addresses review comment. Keeping r+ from previous patch version.

Comment 4

[Christian Holler (:decoder)]

Marking also as a build blocker because this causes "make check" to run for the maximum allowed time per test using valgrind, rendering the builds very slow.

Comment 5

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Comment on attachment 619535 [details] [diff] [review]
Updated patch

http://hg.mozilla.org/integration/mozilla-inbound/rev/1ed79aeea82f

Comment 6

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/1ed79aeea82f