749864 - Typed array argument codegen for bindings

Status: RESOLVED FIXED

Description

[Boris Zbarsky [:bz] (if a patch has no decent message, automatic r-)]

Once bug 742145 is fixed...

Comment 1

[Boris Zbarsky [:bz] (if a patch has no decent message, automatic r-)]

Created attachment 619254 [details] [diff] [review]
Codegen for typed array and arraybuffer arguments.

I think this depends on the infrastructure bug 748267.  Also, I didn't do typed array return values yet, because I have no real way to test them.

Comment 2

[:Ms2ger (⌚ UTC+1/+2)]

Comment on attachment 619254 [details] [diff] [review]
Codegen for typed array and arraybuffer arguments.

Review of attachment 619254 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/base/src/nsXMLHttpRequest.cpp
@@ +2633,5 @@
>    aContentType.SetIsVoid(true);
>    aCharset.Truncate();
>  
> +  PRInt32 length = aArrayBuffer->mLength;
> +  char* data = reinterpret_cast<char*>(aArrayBuffer->mData);

Can this be a static_cast?

Comment 3

[Boris Zbarsky [:bz] (if a patch has no decent message, automatic r-)]

No.  Can't static_cast from uint8_t* to char*.  At least not on my compiler.  ;)

Comment 4

[Boris Zbarsky [:bz] (if a patch has no decent message, automatic r-)]

Created attachment 626287 [details] [diff] [review]
Updated to be a little simpler

Comment 5

[Peter Van der Beken [:peterv]]

Comment on attachment 626287 [details] [diff] [review]
Updated to be a little simpler

Review of attachment 626287 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/Codegen.py
@@ +1414,5 @@
> +        elif type.isArrayBufferView():
> +            name = "ArrayBufferView"
> +            jsname = "TypedArrayObject"
> +        else:
> +            name = type.name

Can't you always set name to type.name, even for ArrayBuffer and ArrayBufferView?

Comment 6

[Boris Zbarsky [:bz] (if a patch has no decent message, automatic r-)]

> Can't you always set name to type.name, even for ArrayBuffer and ArrayBufferView?

I think so, yes.  Will do.

Comment 7

[Boris Zbarsky [:bz] (if a patch has no decent message, automatic r-)]

http://hg.mozilla.org/mozilla-central/rev/faa1929dc247

Comment 8

[Boris Zbarsky [:bz] (if a patch has no decent message, automatic r-)]

Added decent tests in https://hg.mozilla.org/integration/mozilla-inbound/rev/e0d8fa7fe174