Closed
Bug 749864
Opened 13 years ago
Closed 13 years ago
Typed array argument codegen for bindings
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(1 file, 1 obsolete file)
15.98 KB,
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
Once bug 742145 is fixed...
![]() |
Assignee | |
Comment 1•13 years ago
|
||
I think this depends on the infrastructure bug 748267. Also, I didn't do typed array return values yet, because I have no real way to test them.
Attachment #619254 -
Flags: review?(peterv)
![]() |
Assignee | |
Updated•13 years ago
|
Depends on: 748267
Summary: Typed array codegen for bindings → Typed array argument codegen for bindings
Whiteboard: [needs review]
![]() |
Assignee | |
Updated•13 years ago
|
Whiteboard: [needs review] → [need review]
Comment 2•13 years ago
|
||
Comment on attachment 619254 [details] [diff] [review]
Codegen for typed array and arraybuffer arguments.
Review of attachment 619254 [details] [diff] [review]:
-----------------------------------------------------------------
::: content/base/src/nsXMLHttpRequest.cpp
@@ +2633,5 @@
> aContentType.SetIsVoid(true);
> aCharset.Truncate();
>
> + PRInt32 length = aArrayBuffer->mLength;
> + char* data = reinterpret_cast<char*>(aArrayBuffer->mData);
Can this be a static_cast?
![]() |
Assignee | |
Comment 3•13 years ago
|
||
No. Can't static_cast from uint8_t* to char*. At least not on my compiler. ;)
![]() |
Assignee | |
Comment 4•13 years ago
|
||
Attachment #626287 -
Flags: review?(peterv)
![]() |
Assignee | |
Updated•13 years ago
|
Attachment #619254 -
Attachment is obsolete: true
Attachment #619254 -
Flags: review?(peterv)
Comment 5•13 years ago
|
||
Comment on attachment 626287 [details] [diff] [review]
Updated to be a little simpler
Review of attachment 626287 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/bindings/Codegen.py
@@ +1414,5 @@
> + elif type.isArrayBufferView():
> + name = "ArrayBufferView"
> + jsname = "TypedArrayObject"
> + else:
> + name = type.name
Can't you always set name to type.name, even for ArrayBuffer and ArrayBufferView?
Attachment #626287 -
Flags: review?(peterv) → review+
![]() |
Assignee | |
Comment 6•13 years ago
|
||
> Can't you always set name to type.name, even for ArrayBuffer and ArrayBufferView?
I think so, yes. Will do.
![]() |
Assignee | |
Comment 7•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Whiteboard: [need review]
Target Milestone: --- → mozilla15
![]() |
Assignee | |
Comment 8•13 years ago
|
||
Added decent tests in https://hg.mozilla.org/integration/mozilla-inbound/rev/e0d8fa7fe174
Flags: in-testsuite? → in-testsuite+
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•