Last Comment Bug 749892 - Intermittent browser_tabview_apptabs.js | Test timed out followed by many more failures ending in browser_tabview_bug626455.js | application timed out after 330 seconds with no output
: Intermittent browser_tabview_apptabs.js | Test timed out followed by many mor...
Status: RESOLVED FIXED
[test which aborts the suite]
: intermittent-failure
Product: Firefox Graveyard
Classification: Graveyard
Component: Panorama (show other bugs)
: Trunk
: x86 Windows 7
: -- normal
: Firefox 15
Assigned To: Tim Taubert [:ttaubert]
:
Mentors:
Depends on:
Blocks: 438871
  Show dependency treegraph
 
Reported: 2012-04-27 21:28 PDT by Phil Ringnalda (:philor, back in August)
Modified: 2016-04-12 14:00 PDT (History)
3 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch v1 (10.28 KB, patch)
2012-05-04 04:40 PDT, Tim Taubert [:ttaubert]
jaws: review+
Details | Diff | Splinter Review

Description Phil Ringnalda (:philor, back in August) 2012-04-27 21:28:54 PDT
A charming failure mode: it makes such a mess of the log by timing out at a bad time without a cleanup function that tbpl chokes and just says "Timeout generating log." What might well have been the first of these failures happened the other day while BzAPI was down and tbpl wasn't getting any suggestions, and we blew off the timeout generating log as a result of that.

https://tbpl.mozilla.org/php/getParsedLog.php?id=11283297&tree=Mozilla-Inbound
Rev3 WINNT 6.1 mozilla-inbound debug test mochitest-other on 2012-04-27 17:37:52 PDT for push df3acd833280

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/tabview/test/browser_tabview_apptabs.js | Test timed out
(screenshot)
...
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/tabview/test/browser_tabview_bug580412.js | There is only one group - Got 2, expected 1
...
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/tabview/test/browser_tabview_bug626455.js | application timed out after 330 seconds with no output
Comment 1 Phil Ringnalda (:philor, back in August) 2012-04-27 21:54:20 PDT
https://tbpl.mozilla.org/php/getParsedLog.php?id=11277901&tree=Mozilla-Inbound
Comment 2 Phil Ringnalda (:philor, back in August) 2012-04-28 13:44:37 PDT
https://tbpl.mozilla.org/php/getParsedLog.php?id=11297826&tree=Firefox
Comment 4 Phil Ringnalda (:philor, back in August) 2012-04-30 14:03:54 PDT
https://tbpl.mozilla.org/php/getParsedLog.php?id=11335193&tree=Mozilla-Inbound
Comment 6 Phil Ringnalda (:philor, back in August) 2012-04-30 21:00:57 PDT
https://tbpl.mozilla.org/php/getParsedLog.php?id=11347446&tree=Mozilla-Inbound
Comment 7 Phil Ringnalda (:philor, back in August) 2012-04-30 23:33:53 PDT
https://tbpl.mozilla.org/php/getParsedLog.php?id=11351102&tree=Mozilla-Inbound
Comment 8 Phil Ringnalda (:philor, back in August) 2012-05-02 12:56:13 PDT
https://tbpl.mozilla.org/php/getParsedLog.php?id=11397259&tree=Firefox
Comment 13 Phil Ringnalda (:philor, back in August) 2012-05-03 07:54:50 PDT
https://tbpl.mozilla.org/php/getParsedLog.php?id=11428039&tree=Mozilla-Inbound
Comment 14 Phil Ringnalda (:philor, back in August) 2012-05-03 08:15:09 PDT
https://tbpl.mozilla.org/php/getParsedLog.php?id=11425188&tree=Mozilla-Inbound
Comment 15 Phil Ringnalda (:philor, back in August) 2012-05-03 10:51:18 PDT
https://tbpl.mozilla.org/php/getParsedLog.php?id=11430091&tree=Mozilla-Inbound
Comment 16 Phil Ringnalda (:philor, back in August) 2012-05-03 16:01:08 PDT
https://tbpl.mozilla.org/php/getParsedLog.php?id=11442849&tree=Mozilla-Inbound
Comment 17 Phil Ringnalda (:philor, back in August) 2012-05-03 16:01:43 PDT
https://tbpl.mozilla.org/php/getParsedLog.php?id=11442967&tree=Mozilla-Inbound
Comment 18 Phil Ringnalda (:philor, back in August) 2012-05-03 17:50:39 PDT
https://tbpl.mozilla.org/php/getParsedLog.php?id=11446271&tree=Firefox
Comment 20 Phil Ringnalda (:philor, back in August) 2012-05-03 23:20:11 PDT
This really isn't a good failure mode.

https://tbpl.mozilla.org/php/getParsedLog.php?id=11455090&tree=Mozilla-Inbound
Comment 22 Tim Taubert [:ttaubert] 2012-05-04 04:40:44 PDT
Created attachment 621009 [details] [diff] [review]
patch v1

The problem was that whenAppTabIconAdded() always picked the first groupItem available but browser_tabview_apptabs.js (and others) was waiting for an app tab icon to be added to a specific groupItem.

So I changed the signature of whenAppTabIconAdded() to take a groupItem as its first parameter so that there's no ambiguity anymore about the groupItem we're observing.
Comment 24 Tim Taubert [:ttaubert] 2012-05-04 07:34:26 PDT
https://hg.mozilla.org/integration/fx-team/rev/a8ea30b2a729
Comment 25 Phil Ringnalda (:philor, back in August) 2012-05-04 12:45:03 PDT
https://tbpl.mozilla.org/php/getParsedLog.php?id=11475501&tree=Mozilla-Inbound
Comment 26 Phil Ringnalda (:philor, back in August) 2012-05-04 15:28:35 PDT
https://tbpl.mozilla.org/php/getParsedLog.php?id=11480904&tree=Mozilla-Inbound
Comment 27 Phil Ringnalda (:philor, back in August) 2012-05-04 15:32:47 PDT
https://tbpl.mozilla.org/php/getParsedLog.php?id=11475921&tree=Mozilla-Inbound
Comment 28 Phil Ringnalda (:philor, back in August) 2012-05-04 15:37:42 PDT
https://tbpl.mozilla.org/php/getParsedLog.php?id=11477735&tree=Mozilla-Inbound
Comment 29 Tim Taubert [:ttaubert] 2012-05-04 15:38:24 PDT
https://hg.mozilla.org/mozilla-central/rev/a8ea30b2a729

Note You need to log in before you can comment on or make changes to this bug.