Last Comment Bug 749892 - Intermittent browser_tabview_apptabs.js | Test timed out followed by many more failures ending in browser_tabview_bug626455.js | application timed out after 330 seconds with no output
: Intermittent browser_tabview_apptabs.js | Test timed out followed by many mor...
[test which aborts the suite]
: intermittent-failure
Product: Firefox Graveyard
Classification: Graveyard
Component: Panorama (show other bugs)
: Trunk
: x86 Windows 7
-- normal
: Firefox 15
Assigned To: Tim Taubert [:ttaubert]
Depends on:
Blocks: 438871
  Show dependency treegraph
Reported: 2012-04-27 21:28 PDT by Phil Ringnalda (:philor)
Modified: 2016-04-12 14:00 PDT (History)
3 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---

patch v1 (10.28 KB, patch)
2012-05-04 04:40 PDT, Tim Taubert [:ttaubert]
jaws: review+
Details | Diff | Splinter Review

Description User image Phil Ringnalda (:philor) 2012-04-27 21:28:54 PDT
A charming failure mode: it makes such a mess of the log by timing out at a bad time without a cleanup function that tbpl chokes and just says "Timeout generating log." What might well have been the first of these failures happened the other day while BzAPI was down and tbpl wasn't getting any suggestions, and we blew off the timeout generating log as a result of that.
Rev3 WINNT 6.1 mozilla-inbound debug test mochitest-other on 2012-04-27 17:37:52 PDT for push df3acd833280

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/tabview/test/browser_tabview_apptabs.js | Test timed out
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/tabview/test/browser_tabview_bug580412.js | There is only one group - Got 2, expected 1
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/tabview/test/browser_tabview_bug626455.js | application timed out after 330 seconds with no output
Comment 20 User image Phil Ringnalda (:philor) 2012-05-03 23:20:11 PDT
This really isn't a good failure mode.
Comment 22 User image Tim Taubert [:ttaubert] 2012-05-04 04:40:44 PDT
Created attachment 621009 [details] [diff] [review]
patch v1

The problem was that whenAppTabIconAdded() always picked the first groupItem available but browser_tabview_apptabs.js (and others) was waiting for an app tab icon to be added to a specific groupItem.

So I changed the signature of whenAppTabIconAdded() to take a groupItem as its first parameter so that there's no ambiguity anymore about the groupItem we're observing.
Comment 24 User image Tim Taubert [:ttaubert] 2012-05-04 07:34:26 PDT
Comment 29 User image Tim Taubert [:ttaubert] 2012-05-04 15:38:24 PDT

Note You need to log in before you can comment on or make changes to this bug.