Closed Bug 749892 Opened 13 years ago Closed 13 years ago

Intermittent browser_tabview_apptabs.js | Test timed out followed by many more failures ending in browser_tabview_bug626455.js | application timed out after 330 seconds with no output

Categories

(Firefox Graveyard :: Panorama, defect)

Product:
Firefox Graveyard
Component:
Panorama
Platform:
x86
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 15

People

(Reporter: philor, Assigned: ttaubert)

References

Details

(Keywords: intermittent-failure, Whiteboard: [test which aborts the suite])

Attachments

(1 file)

patch v1
10.28 KB, patch
jaws
: review+
Details | Diff | Splinter Review
A charming failure mode: it makes such a mess of the log by timing out at a bad time without a cleanup function that tbpl chokes and just says "Timeout generating log." What might well have been the first of these failures happened the other day while BzAPI was down and tbpl wasn't getting any suggestions, and we blew off the timeout generating log as a result of that. https://tbpl.mozilla.org/php/getParsedLog.php?id=11283297&tree=Mozilla-Inbound Rev3 WINNT 6.1 mozilla-inbound debug test mochitest-other on 2012-04-27 17:37:52 PDT for push df3acd833280 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/tabview/test/browser_tabview_apptabs.js | Test timed out (screenshot) ... TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/tabview/test/browser_tabview_bug580412.js | There is only one group - Got 2, expected 1 ... TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/tabview/test/browser_tabview_bug626455.js | application timed out after 330 seconds with no output
Attached patch patch v1 — — Splinter Review
The problem was that whenAppTabIconAdded() always picked the first groupItem available but browser_tabview_apptabs.js (and others) was waiting for an app tab icon to be added to a specific groupItem. So I changed the signature of whenAppTabIconAdded() to take a groupItem as its first parameter so that there's no ambiguity anymore about the groupItem we're observing.
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
Attachment #621009 - Flags: review?(jwein)
Attachment #621009 - Flags: review?(jwein) → review+
https://hg.mozilla.org/integration/fx-team/rev/a8ea30b2a729
Whiteboard: [orange][test which aborts the suite] → [orange][test which aborts the suite][fixed-in-fx-team]
Target Milestone: --- → Firefox 15
https://hg.mozilla.org/mozilla-central/rev/a8ea30b2a729
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [orange][test which aborts the suite][fixed-in-fx-team] → [orange][test which aborts the suite]
Whiteboard: [orange][test which aborts the suite] → [test which aborts the suite]
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: