749892 - Intermittent browser_tabview_apptabs.js | Test timed out followed by many more failures ending in browser_tabview_bug626455.js | application timed out after 330 seconds with no output

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect)

Description

[Phil Ringnalda (:philor)]

A charming failure mode: it makes such a mess of the log by timing out at a bad time without a cleanup function that tbpl chokes and just says "Timeout generating log." What might well have been the first of these failures happened the other day while BzAPI was down and tbpl wasn't getting any suggestions, and we blew off the timeout generating log as a result of that.

https://tbpl.mozilla.org/php/getParsedLog.php?id=11283297&tree=Mozilla-Inbound
Rev3 WINNT 6.1 mozilla-inbound debug test mochitest-other on 2012-04-27 17:37:52 PDT for push df3acd833280

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/tabview/test/browser_tabview_apptabs.js | Test timed out
(screenshot)
...
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/tabview/test/browser_tabview_bug580412.js | There is only one group - Got 2, expected 1
...
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/tabview/test/browser_tabview_bug626455.js | application timed out after 330 seconds with no output

Comment 1

[Phil Ringnalda (:philor)]

https://tbpl.mozilla.org/php/getParsedLog.php?id=11277901&tree=Mozilla-Inbound

Comment 2

[Phil Ringnalda (:philor)]

https://tbpl.mozilla.org/php/getParsedLog.php?id=11297826&tree=Firefox

Comment 3

[Ed Morley [:emorley]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=11318006&tree=Mozilla-Inbound

Comment 4

[Phil Ringnalda (:philor)]

https://tbpl.mozilla.org/php/getParsedLog.php?id=11335193&tree=Mozilla-Inbound

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=11342959&tree=Mozilla-Inbound

Comment 6

[Phil Ringnalda (:philor)]

https://tbpl.mozilla.org/php/getParsedLog.php?id=11347446&tree=Mozilla-Inbound

Comment 7

[Phil Ringnalda (:philor)]

https://tbpl.mozilla.org/php/getParsedLog.php?id=11351102&tree=Mozilla-Inbound

Comment 8

[Phil Ringnalda (:philor)]

https://tbpl.mozilla.org/php/getParsedLog.php?id=11397259&tree=Firefox

Comment 9

[Ed Morley [:emorley]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=11417619&tree=Firefox

Comment 10

[Ed Morley [:emorley]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=11421039&tree=Mozilla-Inbound

Comment 11

[Ed Morley [:emorley]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=11424117&tree=Mozilla-Inbound

Comment 12

[Ed Morley [:emorley]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=11425622&tree=Mozilla-Inbound

Comment 13

[Phil Ringnalda (:philor)]

https://tbpl.mozilla.org/php/getParsedLog.php?id=11428039&tree=Mozilla-Inbound

Comment 14

[Phil Ringnalda (:philor)]

https://tbpl.mozilla.org/php/getParsedLog.php?id=11425188&tree=Mozilla-Inbound

Comment 15

[Phil Ringnalda (:philor)]

https://tbpl.mozilla.org/php/getParsedLog.php?id=11430091&tree=Mozilla-Inbound

Comment 16

[Phil Ringnalda (:philor)]

https://tbpl.mozilla.org/php/getParsedLog.php?id=11442849&tree=Mozilla-Inbound

Comment 17

[Phil Ringnalda (:philor)]

https://tbpl.mozilla.org/php/getParsedLog.php?id=11442967&tree=Mozilla-Inbound

Comment 18

[Phil Ringnalda (:philor)]

https://tbpl.mozilla.org/php/getParsedLog.php?id=11446271&tree=Firefox

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=11448039&tree=Mozilla-Inbound

Comment 20

[Phil Ringnalda (:philor)]

This really isn't a good failure mode.

https://tbpl.mozilla.org/php/getParsedLog.php?id=11455090&tree=Mozilla-Inbound

Comment 21

[Ed Morley [:emorley]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=11459719&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=11460438&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=11459993&tree=Mozilla-Inbound

Comment 22

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v1

The problem was that whenAppTabIconAdded() always picked the first groupItem available but browser_tabview_apptabs.js (and others) was waiting for an app tab icon to be added to a specific groupItem.

So I changed the signature of whenAppTabIconAdded() to take a groupItem as its first parameter so that there's no ambiguity anymore about the groupItem we're observing.

Comment 23

[Ed Morley [:emorley]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=11459993&tree=Mozilla-Inbound

Comment 24

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/a8ea30b2a729

Comment 25

[Phil Ringnalda (:philor)]

https://tbpl.mozilla.org/php/getParsedLog.php?id=11475501&tree=Mozilla-Inbound

Comment 26

[Phil Ringnalda (:philor)]

https://tbpl.mozilla.org/php/getParsedLog.php?id=11480904&tree=Mozilla-Inbound

Comment 27

[Phil Ringnalda (:philor)]

https://tbpl.mozilla.org/php/getParsedLog.php?id=11475921&tree=Mozilla-Inbound

Comment 28

[Phil Ringnalda (:philor)]

https://tbpl.mozilla.org/php/getParsedLog.php?id=11477735&tree=Mozilla-Inbound

Comment 29

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/a8ea30b2a729