Closed
Bug 750079
Opened 13 years ago
Closed 13 years ago
Cleanup code around nsHTMLEditor::HasAttrVal
Categories
(Core :: DOM: Editor, defect)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
Details
Attachments
(3 files)
|
2.94 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
|
4.56 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
|
9.87 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #619406 -
Flags: review?(ehsan)
|
Assignee | |
Comment 1•13 years ago
|
||
I'll want those nsIContents.
Attachment #619407 -
Flags: review?(ehsan)
|
|
Assignee | |
Comment 2•13 years ago
|
||
Attachment #619408 -
Flags: review?(ehsan)
|
||
Updated•13 years ago
|
Attachment #619406 -
Flags: review?(ehsan) → review+
|
|
||
Updated•13 years ago
|
Attachment #619407 -
Flags: review?(ehsan) → review+
|
|
||
Comment 3•13 years ago
|
||
Comment on attachment 619408 [details] [diff] [review]
Part c: Pass nsIContent to nsHTMLEditor::HasAttrVal
Review of attachment 619408 [details] [diff] [review]:
-----------------------------------------------------------------
::: editor/libeditor/html/nsHTMLEditorStyle.cpp
@@ +356,5 @@
> const nsAString *aAttribute,
> const nsAString *aValue)
> {
> MOZ_ASSERT(aNode && aProperty);
> + MOZ_ASSERT(aValue);
Nit: avoid multiple MOZ_ASSERTs please.
Attachment #619408 -
Flags: review?(ehsan) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2eadc2ba12e4
https://hg.mozilla.org/mozilla-central/rev/13885ec542b8
https://hg.mozilla.org/mozilla-central/rev/d4980a823729
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in
before you can comment on or make changes to this bug.
Description
•