Cleanup code around nsHTMLEditor::HasAttrVal

RESOLVED FIXED in mozilla15

Status

()

Core
Editor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

5 years ago
Created attachment 619406 [details] [diff] [review]
Part a: Add IsOnlyAttribute(nsIContent*, const nsAString&)
Attachment #619406 - Flags: review?(ehsan)
(Assignee)

Comment 1

5 years ago
Created attachment 619407 [details] [diff] [review]
Part b: Return nsIContent from GetPriorHTMLSibling/GetNextHTMLSibling

I'll want those nsIContents.
Attachment #619407 - Flags: review?(ehsan)
(Assignee)

Comment 2

5 years ago
Created attachment 619408 [details] [diff] [review]
Part c: Pass nsIContent to nsHTMLEditor::HasAttrVal
Attachment #619408 - Flags: review?(ehsan)
(Assignee)

Updated

5 years ago
Blocks: 750085
Attachment #619406 - Flags: review?(ehsan) → review+
Attachment #619407 - Flags: review?(ehsan) → review+
Comment on attachment 619408 [details] [diff] [review]
Part c: Pass nsIContent to nsHTMLEditor::HasAttrVal

Review of attachment 619408 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/libeditor/html/nsHTMLEditorStyle.cpp
@@ +356,5 @@
>                                            const nsAString *aAttribute,
>                                            const nsAString *aValue)
>  {
>    MOZ_ASSERT(aNode && aProperty);
> +  MOZ_ASSERT(aValue);

Nit: avoid multiple MOZ_ASSERTs please.
Attachment #619408 - Flags: review?(ehsan) → review+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/2eadc2ba12e4
https://hg.mozilla.org/mozilla-central/rev/13885ec542b8
https://hg.mozilla.org/mozilla-central/rev/d4980a823729
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.