Last Comment Bug 750079 - Cleanup code around nsHTMLEditor::HasAttrVal
: Cleanup code around nsHTMLEditor::HasAttrVal
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Editor (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla15
Assigned To: :Ms2ger
:
Mentors:
Depends on:
Blocks: 750085
  Show dependency treegraph
 
Reported: 2012-04-29 08:52 PDT by :Ms2ger
Modified: 2012-05-05 10:29 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Part a: Add IsOnlyAttribute(nsIContent*, const nsAString&) (2.94 KB, patch)
2012-04-29 08:52 PDT, :Ms2ger
ehsan: review+
Details | Diff | Review
Part b: Return nsIContent from GetPriorHTMLSibling/GetNextHTMLSibling (4.56 KB, patch)
2012-04-29 08:56 PDT, :Ms2ger
ehsan: review+
Details | Diff | Review
Part c: Pass nsIContent to nsHTMLEditor::HasAttrVal (9.87 KB, patch)
2012-04-29 08:59 PDT, :Ms2ger
ehsan: review+
Details | Diff | Review

Description :Ms2ger 2012-04-29 08:52:34 PDT
Created attachment 619406 [details] [diff] [review]
Part a: Add IsOnlyAttribute(nsIContent*, const nsAString&)
Comment 1 :Ms2ger 2012-04-29 08:56:22 PDT
Created attachment 619407 [details] [diff] [review]
Part b: Return nsIContent from GetPriorHTMLSibling/GetNextHTMLSibling

I'll want those nsIContents.
Comment 2 :Ms2ger 2012-04-29 08:59:52 PDT
Created attachment 619408 [details] [diff] [review]
Part c: Pass nsIContent to nsHTMLEditor::HasAttrVal
Comment 3 :Ehsan Akhgari (out sick) 2012-04-30 10:52:48 PDT
Comment on attachment 619408 [details] [diff] [review]
Part c: Pass nsIContent to nsHTMLEditor::HasAttrVal

Review of attachment 619408 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/libeditor/html/nsHTMLEditorStyle.cpp
@@ +356,5 @@
>                                            const nsAString *aAttribute,
>                                            const nsAString *aValue)
>  {
>    MOZ_ASSERT(aNode && aProperty);
> +  MOZ_ASSERT(aValue);

Nit: avoid multiple MOZ_ASSERTs please.

Note You need to log in before you can comment on or make changes to this bug.