Closed
Bug 750085
Opened 13 years ago
Closed 13 years ago
Pass nsIContent to SetInlinePropertyOnNodeImpl and use nsINode APIs to iterate over children
Categories
(Core :: DOM: Editor, defect)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
Details
Attachments
(1 file)
|
11.06 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #619409 -
Flags: review?(ehsan)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 619409 [details] [diff] [review]
Patch v1
Review of attachment 619409 [details] [diff] [review]:
-----------------------------------------------------------------
::: editor/libeditor/html/nsHTMLEditorStyle.cpp
@@ +496,5 @@
> + const nsAString* aAttribute,
> + const nsAString* aValue)
> +{
> + MOZ_ASSERT(aNode);
> + MOZ_ASSERT(aProperty);
Nit: aNode && aProperty.
Attachment #619409 -
Flags: review?(ehsan) → review+
|
Assignee | |
Comment 2•13 years ago
|
||
I disagree; distinct asserts make it easier to figure out which argument is null.
|
|
||
Comment 3•13 years ago
|
||
OK, fine. I don't care much either way.
|
|
Assignee | |
Comment 4•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in
before you can comment on or make changes to this bug.
Description
•