The default bug view has changed. See this FAQ.

Pass nsIContent to SetInlinePropertyOnNodeImpl and use nsINode APIs to iterate over children

RESOLVED FIXED in mozilla15

Status

()

Core
Editor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 619409 [details] [diff] [review]
Patch v1
Attachment #619409 - Flags: review?(ehsan)
Comment on attachment 619409 [details] [diff] [review]
Patch v1

Review of attachment 619409 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/libeditor/html/nsHTMLEditorStyle.cpp
@@ +496,5 @@
> +                                      const nsAString* aAttribute,
> +                                      const nsAString* aValue)
> +{
> +  MOZ_ASSERT(aNode);
> +  MOZ_ASSERT(aProperty);

Nit: aNode && aProperty.
Attachment #619409 - Flags: review?(ehsan) → review+
(Assignee)

Comment 2

5 years ago
I disagree; distinct asserts make it easier to figure out which argument is null.
OK, fine.  I don't care much either way.
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/b6311ea06814
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.