Last Comment Bug 750085 - Pass nsIContent to SetInlinePropertyOnNodeImpl and use nsINode APIs to iterate over children
: Pass nsIContent to SetInlinePropertyOnNodeImpl and use nsINode APIs to iterat...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Editor (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla15
Assigned To: :Ms2ger (⌚ UTC+1/+2)
:
: Makoto Kato [:m_kato]
Mentors:
Depends on: 750079
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-29 09:08 PDT by :Ms2ger (⌚ UTC+1/+2)
Modified: 2012-05-05 10:29 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (11.06 KB, patch)
2012-04-29 09:08 PDT, :Ms2ger (⌚ UTC+1/+2)
ehsan: review+
Details | Diff | Splinter Review

Description :Ms2ger (⌚ UTC+1/+2) 2012-04-29 09:08:22 PDT
Created attachment 619409 [details] [diff] [review]
Patch v1
Comment 1 :Ehsan Akhgari 2012-04-30 10:46:37 PDT
Comment on attachment 619409 [details] [diff] [review]
Patch v1

Review of attachment 619409 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/libeditor/html/nsHTMLEditorStyle.cpp
@@ +496,5 @@
> +                                      const nsAString* aAttribute,
> +                                      const nsAString* aValue)
> +{
> +  MOZ_ASSERT(aNode);
> +  MOZ_ASSERT(aProperty);

Nit: aNode && aProperty.
Comment 2 :Ms2ger (⌚ UTC+1/+2) 2012-04-30 11:44:04 PDT
I disagree; distinct asserts make it easier to figure out which argument is null.
Comment 3 :Ehsan Akhgari 2012-04-30 11:48:55 PDT
OK, fine.  I don't care much either way.
Comment 4 :Ms2ger (⌚ UTC+1/+2) 2012-05-05 10:29:28 PDT
https://hg.mozilla.org/mozilla-central/rev/b6311ea06814

Note You need to log in before you can comment on or make changes to this bug.