Closed Bug 750434 Opened 13 years ago Closed 12 years ago

[Azure] Add support for Azure to Tiled Thebes Layers

Categories

(Core :: Graphics: Layers, defect)

Product:
Core
Component:
Graphics: Layers
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla27

People

(Reporter: gw280, Assigned: ajones)

References

Details

Attachments

(2 files, 9 obsolete files)

Enable azure for android v2
976 bytes, patch
nrc
: review+
Details | Diff | Splinter Review
Add support for Azure content rendering to ClientTiledThebesLayer v5?
9.35 KB, patch
mattwoodrow
: review+
Details | Diff | Splinter Review
Tiled Thebes Layers should have support for drawing using Azure DrawTargets
Attachment #619656 - Flags: feedback?(bgirard)
Comment on attachment 619656 [details] [diff] [review] Add support for Azure content rendering to BasicTiledThebesLayer Looks good
Attachment #619656 - Flags: feedback?(bgirard) → feedback+
Attached patch Updated patch (obsolete) — — Splinter Review
Updated patch. Instead of using Thebes' API to copy the surface to the other, we use Azure directly now.
Attachment #619656 - Attachment is obsolete: true
Attachment #631047 - Flags: review?(bgirard)
Attached patch Update TODO comment (obsolete) — — Splinter Review
Attachment #631047 - Attachment is obsolete: true
Attachment #631047 - Flags: review?(bgirard)
Attachment #631218 - Flags: review?(bgirard)
Attachment #631218 - Flags: review?(bgirard) → review+
Just a quick update as to why this hasn't landed; I need to land the patches for bug 740580 first, and they broke a reftest on unaccelerated windows, which I have yet to fix.
Depends on: 740580
Simple rebasing so it should not require re-review.
Attachment #631218 - Attachment is obsolete: true
Try run for c4c5d3796da0 is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=c4c5d3796da0 Results (out of 92 total builds): exception: 3 success: 73 warnings: 16 Builds (or logs if builds failed) available at: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/ajones@mozilla.com-c4c5d3796da0
Assignee: nobody → ajones
Attachment #661087 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #665777 - Flags: review?(bgirard)
Attachment #661087 - Flags: review?(bgirard)
Comment on attachment 665777 [details] [diff] [review] Add support for Azure content rendering to BasicTiledThebesLayer Review of attachment 665777 [details] [diff] [review]: ----------------------------------------------------------------- LGTM with this fixed ::: gfx/layers/basic/BasicTiledThebesLayer.cpp @@ +179,5 @@ > // Bug 742100, this gfxContext really should live on the stack. > + nsRefPtr<gfxContext> ctxt; > + > + RefPtr<gfx::DrawTarget> writableDrawTarget; > + if (gfxPlatform::GetPlatform()->SupportsAzureContent()) { This only needs to happen if we're doing a single paint buffer draw.
Attachment #665777 - Flags: review?(bgirard) → review+
Comment on attachment 661087 [details] [diff] [review] Azure content for BasicTiledThebesLayer This is stuck in my review queue so I'm removing this.
Attachment #661087 - Flags: review?(bgirard)
Try run for c688628b3c28 is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=c688628b3c28 Results (out of 90 total builds): success: 83 warnings: 7 Builds (or logs if builds failed) available at: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/ajones@mozilla.com-c688628b3c28
Try run for c688628b3c28 is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=c688628b3c28 Results (out of 91 total builds): success: 83 warnings: 8 Builds (or logs if builds failed) available at: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/ajones@mozilla.com-c688628b3c28
Try run for c688628b3c28 is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=c688628b3c28 Results (out of 92 total builds): success: 84 warnings: 8 Builds (or logs if builds failed) available at: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/ajones@mozilla.com-c688628b3c28
This is bitrotted. Please rebase.
Keywords: checkin-needed
Oops checkin-needed on the wrong bug.
Status: ASSIGNED → NEW
Attachment #665777 - Attachment is obsolete: true
Comment on attachment 790002 [details] [diff] [review] Add support for Azure content rendering to ClientTiledThebesLayer Review of attachment 790002 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/layers/client/TiledContentClient.cpp @@ +236,5 @@ > + RefPtr<gfx::DrawTarget> writableDrawTarget; > + if (gfxPlatform::GetPlatform()->SupportsAzureContent()) { > + // TODO: Instead of creating a gfxImageSurface to back the tile we should > + // create an offscreen DrawTarget. This would need to be shared cross-thread > + // and support copy on write semantics. I think this comment should go away, since we've done it.
Attachment #790002 - Flags: review?(matt.woodrow) → review+
Fixed some crash bugs in the Azure paths.
Attachment #790002 - Attachment is obsolete: true
Attachment #795778 - Attachment is obsolete: true
Attached patch Enable azure for android (obsolete) — — Splinter Review
Attachment #808366 - Flags: review?(ncameron)
Attachment #808366 - Attachment is obsolete: true
Attachment #808366 - Flags: review?(ncameron)
Attachment #808372 - Flags: review?(ncameron)
Carrying forward r=mattwoodrow,BenWa
Attachment #808365 - Attachment is obsolete: true
Attachment #808373 - Flags: review+
Attachment #808372 - Flags: review?(ncameron) → review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: