75063 - Typing mozilla.org\ gives unexpected results.

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Neil Marshall]

If you type mozilla.org\ into the location bar and press enter, it selects the 
ftp:// protocol and adds three forward slashes to the end.

file://mozilla.org///

And it also tries to display the www page as an FTP site.  I don't know if this 
is a bug, but I sure didn't expect that to happen.

Comment 1

[Asa Dotzler [:asa]]

over to Networking.  In Linux build 040908 we escape the backslash and load the
page fine but not on win2K.

Comment 2

[neeti]

We are converting to file:// protocol in docshell\base\nsDefaultURIFixup.cpp in
nsDefaultURIFixup::CreateFixupURI(..)

Comment 3

[Adam Lock]

The method nsDefaultURIFixup::ConvertFileToStringURI is doing the fixup. If it 
sees a backslash in the string or the string length is 2 and the last char is a 
colon or a bar then it converts it to a file URL.

This is meant to be smart behaviour to account for people typing file paths into 
the address base. Perhaps it would be smarter it it worked on absolute paths 
e.g. "c:\blah\" & "\somewhere" but "..\foo\" and "bar\" would be skipped. It 
could even test if the file/dir actually exists.

Obviously this is all Win32 specific.

For some reason, the Unix version would turn this "\somepath" into this 
"file://\somepath". Is this legal?

Comment 4

[tenthumbs]

Backslashes are allowed in names, at least on Linux ext2 filesystems.
  touch '\a\b.zz'
will create such a file so mozilla's behavior is correct on Linux.

Comment 5

[Adam Lock]

Attachment: Patch makes file fixup "smarter"

Comment 6

[Adam Lock]

Review please for the patch.

The patch turns the input URL into a file:// URL if it refers to an existing 
file with an absolute path. So things like "c:\", "d:\mozilla\somefile.txt" 
will be transformed into their "file://c|/" and 
"file://d|/mozilla/somefile.txt" equivalents, but "mozilla.org\" will still turn 
into "http://mozilla.org/".

Comment 7

[Adam Lock]

Attachment: Second version of patch does not check if the filename exists or not.

Comment 8

[Judson Valeski]

-> 0.9.2

Comment 9

[Adam Lock]

Attachment: Updated patch

Comment 10

[Adam Lock]

Attachment: Updated again, prevents backslash replacement happening for javascript: links

Comment 11

[Adam Lock]

r=valeski

Comment 12

[rpotts (gone)]

sr=rpotts

Comment 13

[Adam Lock]

Thanks everyone, fix is checked in.

Comment 14

[Jesse Ruderman]

Filed bug 81717 for this still happening for data: (and finger:) urls.

Comment 15

[benc]

qa to me.
+verifyme (will verify when I do all 0.9.x fixes)

Comment 16

[benc]

Is this windows-only behavior?

Comment 17

[Tracy Walker [:tracy]]

mass remove verifyme requests greater than 4 months old