81717 - backslash in data: url converted to forward slash

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Jesse Ruderman]

Found after bug 75063 was fixed:

If a data: url contains a backslash, it's converted to a forward slash as soon 
as I press enter in the location bar.

IMO, URL-munging should be opt-in (http, https, file only) rather than opt-out 
(everything except javascript, data, finger, what else?).

Comment 1

[Judson Valeski]

yea, opt-in makes sense to me too. there could be arbitrary URL implementations
that need the backslash to remain un-touched.

Comment 2

[Adam Lock]

Attachment: Patch restricts backslash fixup to a few protocols

Comment 3

[Adam Lock]

I've changed the fixup code so it's more restrictive. It only happens to http, 
https, ftp protocols. It will also happens if there is no specified protocol, 
e.g. for when someone types "www.mozilla.org\projects".

Backslashes will be passed through unmolested for all other situations.

Comment 4

[Adam Lock]

Can I have a review on the patch please?

Comment 5

[Adam Lock]

Can someone please review the patch? It won't get checked in until it is.

Comment 6

[rpotts (gone)]

r=rpotts.

It would be nice to have a more extensible/flexible way to handle this... but we 
can deal with that later :-)

Comment 7

[Scott MacGregor]

sr=mscott

Comment 8

[Adam Lock]

Fix is checked into trunk

Comment 9

[benc]

QA to me, I'll cover this in the data: URL functional test.