750683 - Reader Mode: Only enable reader operations (read now and reading list) when operation makes sense

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Lucas Rocha (:lucasr)]

For example, we don't want to show the reader button on toolbar if user is accessing the home page of New York Times. We should only show the reader button for article-type of pages. Same applies for "Add to Reading List" operation.

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: (1/2) Check if page is convertible to enable reader mode

Comment 2

[Lucas Rocha (:lucasr)]

Attachment: (2/2) Remove unnecessary code from readability.js

Comment 3

[Lucas Rocha (:lucasr)]

I'm not happy with the fact that the readability on every page involves cloning the whole DOM document. We bail early for home pages and skip a few steps when analyzing the page but I think I need to dig this a bit more to find a more efficient and reliable implementation of this check. I want to keep the ball rolling so I filed bug 765930 as a follow-up to track this.

Comment 4

[Lucas Rocha (:lucasr)]

Pushed: http://hg.mozilla.org/integration/mozilla-inbound/rev/abf2e0775b3b

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/abf2e0775b3b

Comment 6

[Cristian Nicolae (:xti)]

Reader Mode is enabled for article-type pages on the latest Nightly, Aurora and Beta builds. Closing bug as verified fixed.

--
Firefox 18.0a1 (2012-09-27)
Device: Galaxy Note
OS: Android 4.0.4