For example, we don't want to show the reader button on toolbar if user is accessing the home page of New York Times. We should only show the reader button for article-type of pages. Same applies for "Add to Reading List" operation.
Created attachment 634209 [details] [diff] [review] (1/2) Check if page is convertible to enable reader mode
Attachment #634209 - Flags: review?(mark.finkle)
Created attachment 634210 [details] [diff] [review] (2/2) Remove unnecessary code from readability.js
Attachment #634210 - Flags: review?(mark.finkle)
I'm not happy with the fact that the readability on every page involves cloning the whole DOM document. We bail early for home pages and skip a few steps when analyzing the page but I think I need to dig this a bit more to find a more efficient and reliable implementation of this check. I want to keep the ball rolling so I filed bug 765930 as a follow-up to track this.
Attachment #634209 - Flags: review?(mark.finkle) → review+
Attachment #634210 - Flags: review?(mark.finkle) → review+
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16
Reader Mode is enabled for article-type pages on the latest Nightly, Aurora and Beta builds. Closing bug as verified fixed. -- Firefox 18.0a1 (2012-09-27) Device: Galaxy Note OS: Android 4.0.4
Status: RESOLVED → VERIFIED
status-firefox18: --- → verified
You need to log in before you can comment on or make changes to this bug.