Closed Bug 750698 Opened 10 years ago Closed 9 years ago

Reader Mode: Implement "read now" action

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 16

People

(Reporter: lucasr, Assigned: lucasr)

References

Details

(Keywords: uiwanted)

Attachments

(3 files, 1 obsolete file)

General design involves:
- Showing a "Read now" button on browser toolbar. Initial idea is to show a book-like icon on the right size.
- When "Read now" is tapped, the page is changed into readable style.

See design page for reference:

  https://wiki.mozilla.org/Fennec/NativeUI/UserExperience/ReaderMode

Need assets for the button.
Attached file assets (obsolete) —
Attached file assets
Attachment #625230 - Attachment is obsolete: true
We might change this to load DOM document from the existing tab directly once we start using the chromeless GeckoApp thingy that Wes is working on. For now, it's saner to just load the article in the same tab from the URL.
Attachment #631338 - Flags: review?(mark.finkle)
Attachment #631338 - Flags: review?(mark.finkle) → review+
Comment on attachment 631337 [details] [diff] [review]
Add simpler loadUrl method to load page in current tab

Do we really need this simplification?
Attachment #631337 - Flags: review?(mark.finkle) → review+
(In reply to Mark Finkle (:mfinkle) from comment #5)
> Comment on attachment 631337 [details] [diff] [review]
> Add simpler loadUrl method to load page in current tab
> 
> Do we really need this simplification?

Strictly speaking, no. But it didn't feel right to use AwesomeBar* bits inside Tab. Maybe Target should really be in GeckoApp instead?
(In reply to Lucas Rocha (:lucasr) from comment #6)
> (In reply to Mark Finkle (:mfinkle) from comment #5)
> > Comment on attachment 631337 [details] [diff] [review]
> > Add simpler loadUrl method to load page in current tab
> > 
> > Do we really need this simplification?
> 
> Strictly speaking, no. But it didn't feel right to use AwesomeBar* bits
> inside Tab. Maybe Target should really be in GeckoApp instead?

Ah, I see what you mean. Yeah, the simplification is OK for not coupling AwesomeBar into more code. Maybe we should move Target into GeckoApp, or somewhere else, to reduce the coupling.
Comment on attachment 631337 [details] [diff] [review]
Add simpler loadUrl method to load page in current tab

Reader Mode is tentatively planned for Firefox 15. It's still disabled and invisible to users. Need to keep landing it in aurora and central.
Attachment #631337 - Flags: approval-mozilla-aurora?
Comment on attachment 631338 [details] [diff] [review]
Implement "reader mode" action

Reader Mode is tentatively planned for Firefox 15. It's still disabled and invisible to users. Need to keep landing it in aurora and central.
Attachment #631338 - Flags: approval-mozilla-aurora?
(In reply to Lucas Rocha (:lucasr) from comment #10)
> Comment on attachment 631338 [details] [diff] [review]
> Implement "reader mode" action
> 
> Reader Mode is tentatively planned for Firefox 15. It's still disabled and
> invisible to users. Need to keep landing it in aurora and central.

Has uplifting Reader Mode to FN15 been requested by the product team?
https://hg.mozilla.org/mozilla-central/rev/de917daa32d6
https://hg.mozilla.org/mozilla-central/rev/09ff9a7af93e
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16
Comment on attachment 631337 [details] [diff] [review]
Add simpler loadUrl method to load page in current tab

[Triage Comment]
Reader mode is not slated for FF15 in the current draft of the product roadmap.
Attachment #631337 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora-
Attachment #631338 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora-
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.