Closed Bug 750702 Opened 13 years ago Closed 13 years ago

Reader Mode: Cache page text in readable style when they're added to reading list

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 16

People

(Reporter: lucasr, Assigned: lucasr)

References

Details

Attachments

(2 files, 1 obsolete file)

Remove article from cache when removed from reading list
4.42 KB, patch
mfinkle
: review+
akeybl
: approval-mozilla-aurora-
Details | Diff | Splinter Review
Cache article in reader DB when added to reading list
10.94 KB, patch
mfinkle
: review+
akeybl
: approval-mozilla-aurora-
Details | Diff | Splinter Review
The general assumption about reading list is that all items will be available offline for reading. Ideally, we should permanently cache both text and images on disk for later offline reading.
Depends on: 750707
Decided to split this bug into parts. The following patches implement text caching. I want to work on image caching in a follow-up, as it's not core.
Attachment #631374 - Flags: review?(mark.finkle)
Updating title to match the the goal for this bug. I filed bug 762892 to track image caching.
Summary: Reader Mode: Cache pages in readable style (text + images) when they're added to reading list → Reader Mode: Cache page text in readable style when they're added to reading list
Assignee: nobody → lucasr.at.mozilla
Comment on attachment 631374 [details] [diff] [review] Cache article in reader DB when added to reading list This looks OK, but I think we should move handleReaderAdded and registration of "Reader:Added" out of GeckoApp. We are trying to move more code out of GeckoApp. I think we could add the code to Tabs or a specific Tab. What do you think? r- for the code re-org, if needed.
Attachment #631374 - Flags: review?(mark.finkle) → review-
Attachment #631375 - Flags: review?(mark.finkle) → review+
Moved reader handler from GeckoApp to Tabs.
Attachment #631374 - Attachment is obsolete: true
Attachment #632216 - Flags: review?(mark.finkle)
Attachment #632216 - Flags: review?(mark.finkle) → review+
Comment on attachment 631375 [details] [diff] [review] Remove article from cache when removed from reading list Part of Reader Mode, planned for F15.
Attachment #631375 - Flags: approval-mozilla-aurora?
Comment on attachment 632216 [details] [diff] [review] Cache article in reader DB when added to reading list Part of Reader Mode, planned for F15.
Attachment #632216 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/dbb48b8978f9 https://hg.mozilla.org/mozilla-central/rev/1b8a28c67a00
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16
Comment on attachment 631375 [details] [diff] [review] Remove article from cache when removed from reading list [Triage Comment] Reader mode is not slated for FF15 in the current draft of the product roadmap.
Attachment #631375 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora-
Attachment #632216 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora-
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: