751164 - Convert debugger.xul to XUL, remove HTML bits.

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Rob Campbell [:rc] (:robcee)]

Current version of debugger.xul contains various HTML pieces. These should be converted to their XUL counterparts.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

This should hopefully fix bug 722317.

Comment 2

[Rob Campbell [:rc] (:robcee)]

taking.

Comment 3

[Rob Campbell [:rc] (:robcee)]

Attachment: dehtmlify

obvious things missing: styling for styling for buttons, styling for menulist and closebutton (bug 749626), styling for splitters.

I plan to create separate bugs for the remaining of these based on changes in the darkdebug bug 692409.

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 621288 [details] [diff] [review]
dehtmlify

Review of attachment 621288 [details] [diff] [review]:
-----------------------------------------------------------------

I presume the flex, vbox and hbox CSS classes will be removed in the darkdebug patch? We used them to emulate the behavior of the respective XUL elements.

Comment 5

[Rob Campbell [:rc] (:robcee)]

(In reply to Panos Astithas [:past] from comment #4)
> Comment on attachment 621288 [details] [diff] [review]
> dehtmlify
> 
> Review of attachment 621288 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I presume the flex, vbox and hbox CSS classes will be removed in the
> darkdebug patch? We used them to emulate the behavior of the respective XUL
> elements.

right, good point. I can add that here before landing.

Comment 6

[Rob Campbell [:rc] (:robcee)]

(In reply to Rob Campbell [:rc] (:robcee) from comment #5)
> (In reply to Panos Astithas [:past] from comment #4)
> > Comment on attachment 621288 [details] [diff] [review]
> > dehtmlify
> > 
> > Review of attachment 621288 [details] [diff] [review]:
> > -----------------------------------------------------------------
> > 
> > I presume the flex, vbox and hbox CSS classes will be removed in the
> > darkdebug patch? We used them to emulate the behavior of the respective XUL
> > elements.
> 
> right, good point. I can add that here before landing.

still using vbox and flex classes on the inner divs.

Comment 7

[Rob Campbell [:rc] (:robcee)]

Attachment: dehtmlification

removed hbox, dbg-statusbar sections from debugger.css. rebased debugger.xul.

Comment 8

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/integration/fx-team/rev/6d6e0475b348

Comment 9

[Victor Porof [:vporof][:vp]]

(In reply to Rob Campbell [:rc] (:robcee) from comment #6)
> still using vbox and flex classes on the inner divs.

Why?

Comment 10

[Rob Campbell [:rc] (:robcee)]

Attachment: followup

followup patch. Removed flex, vbox classes. Converted divs to vboxes. Added dbg-default class. Removed extra nesting around script.

Comment 11

[Paul Rouget [:paul]]

Comment on attachment 622327 [details] [diff] [review]
followup

Review of attachment 622327 [details] [diff] [review]:
-----------------------------------------------------------------

As you're fixing debugger.xul, can you remove the ^I character line 61?
Can you use toolbarbutton (instead of buttons)?

Both of these things are not required, I can do it in bug 692409.

::: browser/devtools/debugger/debugger.css
@@ +47,3 @@
>    cursor: default;
>  }
>  

No need to add "vbox" (nit)

Comment 12

[Rob Campbell [:rc] (:robcee)]

done. Thanks!

https://hg.mozilla.org/integration/fx-team/rev/4b191063009c

Comment 13

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/mozilla-central/rev/6d6e0475b348

https://hg.mozilla.org/mozilla-central/rev/4b191063009c