Closed Bug 751164 Opened 8 years ago Closed 8 years ago

Convert debugger.xul to XUL, remove HTML bits.

Categories

(DevTools :: Debugger, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 15

People

(Reporter: rcampbell, Assigned: rcampbell)

References

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(3 files)

Current version of debugger.xul contains various HTML pieces. These should be converted to their XUL counterparts.
This should hopefully fix bug 722317.
taking.
Assignee: nobody → rcampbell
Attached patch dehtmlifySplinter Review
obvious things missing: styling for styling for buttons, styling for menulist and closebutton (bug 749626), styling for splitters.

I plan to create separate bugs for the remaining of these based on changes in the darkdebug bug 692409.
Attachment #621288 - Flags: review?(past)
Comment on attachment 621288 [details] [diff] [review]
dehtmlify

Review of attachment 621288 [details] [diff] [review]:
-----------------------------------------------------------------

I presume the flex, vbox and hbox CSS classes will be removed in the darkdebug patch? We used them to emulate the behavior of the respective XUL elements.
Attachment #621288 - Flags: review?(past) → review+
Blocks: darkdebug
(In reply to Panos Astithas [:past] from comment #4)
> Comment on attachment 621288 [details] [diff] [review]
> dehtmlify
> 
> Review of attachment 621288 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I presume the flex, vbox and hbox CSS classes will be removed in the
> darkdebug patch? We used them to emulate the behavior of the respective XUL
> elements.

right, good point. I can add that here before landing.
(In reply to Rob Campbell [:rc] (:robcee) from comment #5)
> (In reply to Panos Astithas [:past] from comment #4)
> > Comment on attachment 621288 [details] [diff] [review]
> > dehtmlify
> > 
> > Review of attachment 621288 [details] [diff] [review]:
> > -----------------------------------------------------------------
> > 
> > I presume the flex, vbox and hbox CSS classes will be removed in the
> > darkdebug patch? We used them to emulate the behavior of the respective XUL
> > elements.
> 
> right, good point. I can add that here before landing.

still using vbox and flex classes on the inner divs.
Status: NEW → ASSIGNED
Attached patch dehtmlificationSplinter Review
removed hbox, dbg-statusbar sections from debugger.css. rebased debugger.xul.
(In reply to Rob Campbell [:rc] (:robcee) from comment #6)
> still using vbox and flex classes on the inner divs.

Why?
Attached patch followupSplinter Review
followup patch. Removed flex, vbox classes. Converted divs to vboxes. Added dbg-default class. Removed extra nesting around script.
Attachment #622327 - Flags: review?(paul)
Comment on attachment 622327 [details] [diff] [review]
followup

Review of attachment 622327 [details] [diff] [review]:
-----------------------------------------------------------------

As you're fixing debugger.xul, can you remove the ^I character line 61?
Can you use toolbarbutton (instead of buttons)?

Both of these things are not required, I can do it in bug 692409.

::: browser/devtools/debugger/debugger.css
@@ +47,3 @@
>    cursor: default;
>  }
>  

No need to add "vbox" (nit)
Attachment #622327 - Flags: review?(paul) → review+
https://hg.mozilla.org/mozilla-central/rev/6d6e0475b348

https://hg.mozilla.org/mozilla-central/rev/4b191063009c
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 15
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.