Convert debugger.xul to XUL, remove HTML bits.

RESOLVED FIXED in Firefox 15

Status

()

Firefox
Developer Tools: Debugger
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: rc, Assigned: rc)

Tracking

unspecified
Firefox 15
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(3 attachments)

(Assignee)

Description

5 years ago
Current version of debugger.xul contains various HTML pieces. These should be converted to their XUL counterparts.
This should hopefully fix bug 722317.
Blocks: 722317
(Assignee)

Comment 2

5 years ago
taking.
Assignee: nobody → rcampbell
(Assignee)

Comment 3

5 years ago
Created attachment 621288 [details] [diff] [review]
dehtmlify

obvious things missing: styling for styling for buttons, styling for menulist and closebutton (bug 749626), styling for splitters.

I plan to create separate bugs for the remaining of these based on changes in the darkdebug bug 692409.
Attachment #621288 - Flags: review?(past)
Comment on attachment 621288 [details] [diff] [review]
dehtmlify

Review of attachment 621288 [details] [diff] [review]:
-----------------------------------------------------------------

I presume the flex, vbox and hbox CSS classes will be removed in the darkdebug patch? We used them to emulate the behavior of the respective XUL elements.
Attachment #621288 - Flags: review?(past) → review+

Updated

5 years ago
Blocks: 692409
(Assignee)

Comment 5

5 years ago
(In reply to Panos Astithas [:past] from comment #4)
> Comment on attachment 621288 [details] [diff] [review]
> dehtmlify
> 
> Review of attachment 621288 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I presume the flex, vbox and hbox CSS classes will be removed in the
> darkdebug patch? We used them to emulate the behavior of the respective XUL
> elements.

right, good point. I can add that here before landing.
(Assignee)

Comment 6

5 years ago
(In reply to Rob Campbell [:rc] (:robcee) from comment #5)
> (In reply to Panos Astithas [:past] from comment #4)
> > Comment on attachment 621288 [details] [diff] [review]
> > dehtmlify
> > 
> > Review of attachment 621288 [details] [diff] [review]:
> > -----------------------------------------------------------------
> > 
> > I presume the flex, vbox and hbox CSS classes will be removed in the
> > darkdebug patch? We used them to emulate the behavior of the respective XUL
> > elements.
> 
> right, good point. I can add that here before landing.

still using vbox and flex classes on the inner divs.
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 7

5 years ago
Created attachment 621932 [details] [diff] [review]
dehtmlification

removed hbox, dbg-statusbar sections from debugger.css. rebased debugger.xul.
(Assignee)

Comment 8

5 years ago
https://hg.mozilla.org/integration/fx-team/rev/6d6e0475b348
Whiteboard: [fixed-in-fx-team]
(In reply to Rob Campbell [:rc] (:robcee) from comment #6)
> still using vbox and flex classes on the inner divs.

Why?
(Assignee)

Comment 10

5 years ago
Created attachment 622327 [details] [diff] [review]
followup

followup patch. Removed flex, vbox classes. Converted divs to vboxes. Added dbg-default class. Removed extra nesting around script.
Attachment #622327 - Flags: review?(paul)

Comment 11

5 years ago
Comment on attachment 622327 [details] [diff] [review]
followup

Review of attachment 622327 [details] [diff] [review]:
-----------------------------------------------------------------

As you're fixing debugger.xul, can you remove the ^I character line 61?
Can you use toolbarbutton (instead of buttons)?

Both of these things are not required, I can do it in bug 692409.

::: browser/devtools/debugger/debugger.css
@@ +47,3 @@
>    cursor: default;
>  }
>  

No need to add "vbox" (nit)
Attachment #622327 - Flags: review?(paul) → review+
(Assignee)

Comment 12

5 years ago
done. Thanks!

https://hg.mozilla.org/integration/fx-team/rev/4b191063009c
(Assignee)

Comment 13

5 years ago
https://hg.mozilla.org/mozilla-central/rev/6d6e0475b348

https://hg.mozilla.org/mozilla-central/rev/4b191063009c
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 15
You need to log in before you can comment on or make changes to this bug.