Closed
Bug 751164
Opened 12 years ago
Closed 12 years ago
Convert debugger.xul to XUL, remove HTML bits.
Categories
(DevTools :: Debugger, defect)
DevTools
Debugger
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 15
People
(Reporter: rcampbell, Assigned: rcampbell)
References
Details
(Whiteboard: [fixed-in-fx-team])
Attachments
(3 files)
7.73 KB,
patch
|
past
:
review+
|
Details | Diff | Splinter Review |
8.39 KB,
patch
|
Details | Diff | Splinter Review | |
1.91 KB,
patch
|
paul
:
review+
|
Details | Diff | Splinter Review |
Current version of debugger.xul contains various HTML pieces. These should be converted to their XUL counterparts.
Comment 1•12 years ago
|
||
This should hopefully fix bug 722317.
Assignee | ||
Comment 3•12 years ago
|
||
obvious things missing: styling for styling for buttons, styling for menulist and closebutton (bug 749626), styling for splitters. I plan to create separate bugs for the remaining of these based on changes in the darkdebug bug 692409.
Attachment #621288 -
Flags: review?(past)
Comment 4•12 years ago
|
||
Comment on attachment 621288 [details] [diff] [review] dehtmlify Review of attachment 621288 [details] [diff] [review]: ----------------------------------------------------------------- I presume the flex, vbox and hbox CSS classes will be removed in the darkdebug patch? We used them to emulate the behavior of the respective XUL elements.
Attachment #621288 -
Flags: review?(past) → review+
Assignee | ||
Comment 5•12 years ago
|
||
(In reply to Panos Astithas [:past] from comment #4) > Comment on attachment 621288 [details] [diff] [review] > dehtmlify > > Review of attachment 621288 [details] [diff] [review]: > ----------------------------------------------------------------- > > I presume the flex, vbox and hbox CSS classes will be removed in the > darkdebug patch? We used them to emulate the behavior of the respective XUL > elements. right, good point. I can add that here before landing.
Assignee | ||
Comment 6•12 years ago
|
||
(In reply to Rob Campbell [:rc] (:robcee) from comment #5) > (In reply to Panos Astithas [:past] from comment #4) > > Comment on attachment 621288 [details] [diff] [review] > > dehtmlify > > > > Review of attachment 621288 [details] [diff] [review]: > > ----------------------------------------------------------------- > > > > I presume the flex, vbox and hbox CSS classes will be removed in the > > darkdebug patch? We used them to emulate the behavior of the respective XUL > > elements. > > right, good point. I can add that here before landing. still using vbox and flex classes on the inner divs.
Assignee | ||
Updated•12 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 7•12 years ago
|
||
removed hbox, dbg-statusbar sections from debugger.css. rebased debugger.xul.
Assignee | ||
Comment 8•12 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/6d6e0475b348
Whiteboard: [fixed-in-fx-team]
Comment 9•12 years ago
|
||
(In reply to Rob Campbell [:rc] (:robcee) from comment #6) > still using vbox and flex classes on the inner divs. Why?
Assignee | ||
Comment 10•12 years ago
|
||
followup patch. Removed flex, vbox classes. Converted divs to vboxes. Added dbg-default class. Removed extra nesting around script.
Attachment #622327 -
Flags: review?(paul)
Comment 11•12 years ago
|
||
Comment on attachment 622327 [details] [diff] [review] followup Review of attachment 622327 [details] [diff] [review]: ----------------------------------------------------------------- As you're fixing debugger.xul, can you remove the ^I character line 61? Can you use toolbarbutton (instead of buttons)? Both of these things are not required, I can do it in bug 692409. ::: browser/devtools/debugger/debugger.css @@ +47,3 @@ > cursor: default; > } > No need to add "vbox" (nit)
Attachment #622327 -
Flags: review?(paul) → review+
Assignee | ||
Comment 12•12 years ago
|
||
done. Thanks! https://hg.mozilla.org/integration/fx-team/rev/4b191063009c
Assignee | ||
Comment 13•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6d6e0475b348 https://hg.mozilla.org/mozilla-central/rev/4b191063009c
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 15
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•