751355 - Linux and Fennec profiling builds should be built with disable elfhack and not strip symbols

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Benoit Girard (:BenWa)]

Attachment: patch

This will let us pull the symbols from the link cache on android when profiling and along with bug 751034 be able to profile tinderbox profiling nightly builds.

Comment 1

[(not currently active) Ted Mielczarek]

Comment on attachment 620462 [details] [diff] [review]
patch

Review of attachment 620462 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +1960,5 @@
>      MOZ_PROFILING=1,
>      MOZ_PROFILING= )
>  
> +# For profiling builds keep the symbol information
> +if test "$MOZ_PROFILING" -a -n "$STRIP_FLAGS"; then

Did you mean '-z "$STRIP_FLAGS"'; here? As written this won't do anything unless STRIP_FLAGS is already set.

@@ +7468,5 @@
>      USE_ELF_HACK=,
>      USE_ELF_HACK=1)
>  
> +# Disable elf hack for profiling because the built in profiler
> +# doesn't read the segments properly with elf hack.

Is this something worth fixing in the profiler?

Comment 2

[Benoit Girard (:BenWa)]

(In reply to Ted Mielczarek [:ted] from comment #1)
> Comment on attachment 620462 [details] [diff] [review]
> patch
> 
> Review of attachment 620462 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: configure.in
> @@ +1960,5 @@
> >      MOZ_PROFILING=1,
> >      MOZ_PROFILING= )
> >  
> > +# For profiling builds keep the symbol information
> > +if test "$MOZ_PROFILING" -a -n "$STRIP_FLAGS"; then
> 
> Did you mean '-z "$STRIP_FLAGS"'; here? As written this won't do anything
> unless STRIP_FLAGS is already set.
> 
> @@ +7468,5 @@
> >      USE_ELF_HACK=,
> >      USE_ELF_HACK=1)
> >  
> > +# Disable elf hack for profiling because the built in profiler
> > +# doesn't read the segments properly with elf hack.
> 
> Is this something worth fixing in the profiler?

For sure, I plan on fixing this on relatively soon. But for now I wanted to take a temporary way around it.

Comment 3

[Benoit Girard (:BenWa)]

Attachment: patch v2

Comment 4

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4ec6652da8b9

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/4ec6652da8b9