Closed Bug 751355 Opened 8 years ago Closed 8 years ago

Linux and Fennec profiling builds should be built with disable elfhack and not strip symbols

Categories

(Core :: Gecko Profiler, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla15

People

(Reporter: BenWa, Assigned: BenWa)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
This will let us pull the symbols from the link cache on android when profiling and along with bug 751034 be able to profile tinderbox profiling nightly builds.
Attachment #620462 - Flags: review?(ted.mielczarek)
Comment on attachment 620462 [details] [diff] [review]
patch

Review of attachment 620462 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +1960,5 @@
>      MOZ_PROFILING=1,
>      MOZ_PROFILING= )
>  
> +# For profiling builds keep the symbol information
> +if test "$MOZ_PROFILING" -a -n "$STRIP_FLAGS"; then

Did you mean '-z "$STRIP_FLAGS"'; here? As written this won't do anything unless STRIP_FLAGS is already set.

@@ +7468,5 @@
>      USE_ELF_HACK=,
>      USE_ELF_HACK=1)
>  
> +# Disable elf hack for profiling because the built in profiler
> +# doesn't read the segments properly with elf hack.

Is this something worth fixing in the profiler?
Attachment #620462 - Flags: review?(ted.mielczarek) → review-
Assignee: nobody → bgirard
(In reply to Ted Mielczarek [:ted] from comment #1)
> Comment on attachment 620462 [details] [diff] [review]
> patch
> 
> Review of attachment 620462 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: configure.in
> @@ +1960,5 @@
> >      MOZ_PROFILING=1,
> >      MOZ_PROFILING= )
> >  
> > +# For profiling builds keep the symbol information
> > +if test "$MOZ_PROFILING" -a -n "$STRIP_FLAGS"; then
> 
> Did you mean '-z "$STRIP_FLAGS"'; here? As written this won't do anything
> unless STRIP_FLAGS is already set.
> 
> @@ +7468,5 @@
> >      USE_ELF_HACK=,
> >      USE_ELF_HACK=1)
> >  
> > +# Disable elf hack for profiling because the built in profiler
> > +# doesn't read the segments properly with elf hack.
> 
> Is this something worth fixing in the profiler?

For sure, I plan on fixing this on relatively soon. But for now I wanted to take a temporary way around it.
Attached patch patch v2Splinter Review
Attachment #620462 - Attachment is obsolete: true
Attachment #621082 - Flags: review?(ted.mielczarek)
Attachment #621082 - Flags: review?(ted.mielczarek) → review+
https://hg.mozilla.org/mozilla-central/rev/4ec6652da8b9
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
Duplicate of this bug: 749521
You need to log in before you can comment on or make changes to this bug.