Linux and Fennec profiling builds should be built with disable elfhack and not strip symbols

RESOLVED FIXED in mozilla15

Status

()

Core
Gecko Profiler
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: BenWa, Assigned: BenWa)

Tracking

unspecified
mozilla15
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 620462 [details] [diff] [review]
patch

This will let us pull the symbols from the link cache on android when profiling and along with bug 751034 be able to profile tinderbox profiling nightly builds.
Attachment #620462 - Flags: review?(ted.mielczarek)
Comment on attachment 620462 [details] [diff] [review]
patch

Review of attachment 620462 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +1960,5 @@
>      MOZ_PROFILING=1,
>      MOZ_PROFILING= )
>  
> +# For profiling builds keep the symbol information
> +if test "$MOZ_PROFILING" -a -n "$STRIP_FLAGS"; then

Did you mean '-z "$STRIP_FLAGS"'; here? As written this won't do anything unless STRIP_FLAGS is already set.

@@ +7468,5 @@
>      USE_ELF_HACK=,
>      USE_ELF_HACK=1)
>  
> +# Disable elf hack for profiling because the built in profiler
> +# doesn't read the segments properly with elf hack.

Is this something worth fixing in the profiler?
Attachment #620462 - Flags: review?(ted.mielczarek) → review-
Assignee: nobody → bgirard
(Assignee)

Comment 2

5 years ago
(In reply to Ted Mielczarek [:ted] from comment #1)
> Comment on attachment 620462 [details] [diff] [review]
> patch
> 
> Review of attachment 620462 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: configure.in
> @@ +1960,5 @@
> >      MOZ_PROFILING=1,
> >      MOZ_PROFILING= )
> >  
> > +# For profiling builds keep the symbol information
> > +if test "$MOZ_PROFILING" -a -n "$STRIP_FLAGS"; then
> 
> Did you mean '-z "$STRIP_FLAGS"'; here? As written this won't do anything
> unless STRIP_FLAGS is already set.
> 
> @@ +7468,5 @@
> >      USE_ELF_HACK=,
> >      USE_ELF_HACK=1)
> >  
> > +# Disable elf hack for profiling because the built in profiler
> > +# doesn't read the segments properly with elf hack.
> 
> Is this something worth fixing in the profiler?

For sure, I plan on fixing this on relatively soon. But for now I wanted to take a temporary way around it.
(Assignee)

Comment 3

5 years ago
Created attachment 621082 [details] [diff] [review]
patch v2
Attachment #620462 - Attachment is obsolete: true
Attachment #621082 - Flags: review?(ted.mielczarek)
Attachment #621082 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ec6652da8b9

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/4ec6652da8b9
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
(Assignee)

Updated

5 years ago
Duplicate of this bug: 749521
You need to log in before you can comment on or make changes to this bug.