Note: There are a few cases of duplicates in user autocompletion which are being worked on.

structure webapp runtime Makefiles correctly

RESOLVED FIXED

Status

Firefox Graveyard
Webapp Runtime
RESOLVED FIXED
5 years ago
a year ago

People

(Reporter: myk, Assigned: myk)

Tracking

unspecified
Bug Flags:
in-moztrap -

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 620475 [details] [diff] [review]
patch v1: corrects makefiles

Per bug 747470, comment 11, makefiles should include autoconf.mk and only include config.mk explicitly if they have to override its definitions.

Here's a patch that corrects webapprt/Makefile.in and webapprt/mac/Makefile.in.  webapprt/win/Makefile.in was already fixed in bug 747470.
Attachment #620475 - Flags: review?(benjamin)
Attachment #620475 - Flags: review?(benjamin) → review+
(Assignee)

Comment 1

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/6a2e890ebcab
http://hg.mozilla.org/mozilla-central/rev/6a2e890ebcab
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Myk - Is there anything I can verify here (I don't think there is, but want to confirm)?
Whiteboard: [qa-]
(Assignee)

Comment 4

5 years ago
That's right, there's nothing you can verify here, since the build outcome is currently the same (as far as I know).
Component: Desktop Runtime → Webapp Runtime
Product: Web Apps → Firefox

Updated

5 years ago
Flags: in-moztrap-

Updated

5 years ago
QA Contact: desktop-runtime → jsmith
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.