Last Comment Bug 751375 - structure webapp runtime Makefiles correctly
: structure webapp runtime Makefiles correctly
Product: Firefox Graveyard
Classification: Graveyard
Component: Webapp Runtime (show other bugs)
: unspecified
: All All
-- normal
: ---
Assigned To: Myk Melez [:myk] [@mykmelez]
: Jason Smith [:jsmith]
Depends on:
  Show dependency treegraph
Reported: 2012-05-02 14:47 PDT by Myk Melez [:myk] [@mykmelez]
Modified: 2016-03-21 12:39 PDT (History)
3 users (show)
jsmith: in‑moztrap-
See Also:
QA Whiteboard:
Iteration: ---
Points: ---

patch v1: corrects makefiles (1.19 KB, patch)
2012-05-02 14:47 PDT, Myk Melez [:myk] [@mykmelez]
benjamin: review+
Details | Diff | Splinter Review

Description User image Myk Melez [:myk] [@mykmelez] 2012-05-02 14:47:21 PDT
Created attachment 620475 [details] [diff] [review]
patch v1: corrects makefiles

Per bug 747470, comment 11, makefiles should include and only include explicitly if they have to override its definitions.

Here's a patch that corrects webapprt/ and webapprt/mac/  webapprt/win/ was already fixed in bug 747470.
Comment 1 User image Myk Melez [:myk] [@mykmelez] 2012-05-07 10:48:47 PDT
Comment 2 User image Ryan VanderMeulen [:RyanVM] 2012-05-07 18:11:40 PDT
Comment 3 User image Jason Smith [:jsmith] 2012-05-12 08:31:58 PDT
Myk - Is there anything I can verify here (I don't think there is, but want to confirm)?
Comment 4 User image Myk Melez [:myk] [@mykmelez] 2012-05-14 10:23:11 PDT
That's right, there's nothing you can verify here, since the build outcome is currently the same (as far as I know).

Note You need to log in before you can comment on or make changes to this bug.