Last Comment Bug 751383 - IonMonkey: Eager+GCZeal: Infinite loop of compile, bailout, Interpreter, GC, follow JSOP_GOTO and compile … (./jit-test/tests/basic/bug713226.js)
: IonMonkey: Eager+GCZeal: Infinite loop of compile, bailout, Interpreter, GC,...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Other Branch
: x86_64 Linux
: -- normal (vote)
: ---
Assigned To: Nicolas B. Pierron [:nbp]
:
:
Mentors:
Depends on:
Blocks: IonEager
  Show dependency treegraph
 
Reported: 2012-05-02 15:14 PDT by Nicolas B. Pierron [:nbp]
Modified: 2012-05-03 23:32 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Skip next OSR if a GC remove the forbidOSR just after the bailout. (1.45 KB, patch)
2012-05-02 17:43 PDT, Nicolas B. Pierron [:nbp]
dvander: review+
Details | Diff | Splinter Review

Description Nicolas B. Pierron [:nbp] 2012-05-02 15:14:42 PDT
This issue can be reproduce with --ion-eager.

gczeal(4);
for (var i = 0; i < 0;)
    ;

We hit a typebarrier when we read "i" and bailout to a point where we can start a new compilation cycle without any updated type information.

I made a work around which check that the bailout does not return to an OSR point and skip the next compilation if this is the case.
Comment 1 David Anderson [:dvander] 2012-05-02 15:56:02 PDT
Would this be fixed by bug 746691?
Comment 2 David Anderson [:dvander] 2012-05-02 15:56:32 PDT
In fact, until bug 746691 we should probably consider gczeal to be unsupported with --ion-eager.
Comment 3 Nicolas B. Pierron [:nbp] 2012-05-02 17:43:47 PDT
Created attachment 620539 [details] [diff] [review]
Skip next OSR if a GC remove the forbidOSR just after the bailout.

Skip all JSOP_GOTO and the next JSOP_LOOPENTRY to avoid the first OSR after a bailout.
Comment 4 Nicolas B. Pierron [:nbp] 2012-05-03 23:32:16 PDT
https://hg.mozilla.org/projects/ionmonkey/rev/89dc67e65016

Note You need to log in before you can comment on or make changes to this bug.