Remove unused txList[Iterator] methods

RESOLVED FIXED in mozilla15

Status

()

Core
XSLT
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ehren Metcalfe, Assigned: Ehren Metcalfe)

Tracking

Trunk
mozilla15
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Noting its comment, it may be dangerous to remove hasPrevious while previous is still used...
(Assignee)

Comment 1

5 years ago
Created attachment 620518 [details] [diff] [review]
patch
Attachment #620518 - Flags: review?(peterv)
Comment on attachment 620518 [details] [diff] [review]
patch

Review of attachment 620518 [details] [diff] [review]:
-----------------------------------------------------------------

We should stop using this class entirely ideally.
Attachment #620518 - Flags: review?(peterv) → review+
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED
Keywords: checkin-needed
Version: unspecified → Trunk
(Assignee)

Comment 3

5 years ago
> We should stop using this class entirely ideally.

hmm, there appears to be more removals (that are difficult to detect statically): http://mxr.mozilla.org/mozilla-central/search?string=gTxTemplateElementHandlers&filter=[Gg]TxTemplateElementHandlers 

will post followup this evening
(Assignee)

Comment 4

5 years ago
> hmm, there appears to be more removals (that are difficult to detect
> statically):
> http://mxr.mozilla.org/mozilla-central/
> search?string=gTxTemplateElementHandlers&filter=[Gg]TxTemplateElementHandlers

oops, spoke too soon http://mxr.mozilla.org/mozilla-central/source/content/xslt/src/xslt/txStylesheetCompileHandlers.cpp#3059
https://hg.mozilla.org/integration/mozilla-inbound/rev/d6c77d2796c0
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → mozilla15

Comment 6

5 years ago
https://hg.mozilla.org/mozilla-central/rev/d6c77d2796c0
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.