Closed Bug 751416 Opened 9 years ago Closed 9 years ago

Remove unused txList[Iterator] methods

Categories

(Core :: XSLT, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla15

People

(Reporter: ehren.m, Assigned: ehren.m)

References

Details

Attachments

(1 file)

Noting its comment, it may be dangerous to remove hasPrevious while previous is still used...
Attached patch patchSplinter Review
Attachment #620518 - Flags: review?(peterv)
Comment on attachment 620518 [details] [diff] [review]
patch

Review of attachment 620518 [details] [diff] [review]:
-----------------------------------------------------------------

We should stop using this class entirely ideally.
Attachment #620518 - Flags: review?(peterv) → review+
Status: NEW → ASSIGNED
Keywords: checkin-needed
Version: unspecified → Trunk
> We should stop using this class entirely ideally.

hmm, there appears to be more removals (that are difficult to detect statically): http://mxr.mozilla.org/mozilla-central/search?string=gTxTemplateElementHandlers&filter=[Gg]TxTemplateElementHandlers 

will post followup this evening
> hmm, there appears to be more removals (that are difficult to detect
> statically):
> http://mxr.mozilla.org/mozilla-central/
> search?string=gTxTemplateElementHandlers&filter=[Gg]TxTemplateElementHandlers

oops, spoke too soon http://mxr.mozilla.org/mozilla-central/source/content/xslt/src/xslt/txStylesheetCompileHandlers.cpp#3059
https://hg.mozilla.org/mozilla-central/rev/d6c77d2796c0
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.