Last Comment Bug 751416 - Remove unused txList[Iterator] methods
: Remove unused txList[Iterator] methods
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: XSLT (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla15
Assigned To: Ehren Metcalfe
:
: Andrew Overholt [:overholt]
Mentors:
Depends on:
Blocks: deadcode
  Show dependency treegraph
 
Reported: 2012-05-02 16:33 PDT by Ehren Metcalfe
Modified: 2012-05-04 10:36 PDT (History)
4 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (7.11 KB, patch)
2012-05-02 16:36 PDT, Ehren Metcalfe
jonas: review+
Details | Diff | Splinter Review

Description Ehren Metcalfe 2012-05-02 16:33:21 PDT
Noting its comment, it may be dangerous to remove hasPrevious while previous is still used...
Comment 1 Ehren Metcalfe 2012-05-02 16:36:45 PDT
Created attachment 620518 [details] [diff] [review]
patch
Comment 2 Jonas Sicking (:sicking) No longer reading bugmail consistently 2012-05-03 00:03:44 PDT
Comment on attachment 620518 [details] [diff] [review]
patch

Review of attachment 620518 [details] [diff] [review]:
-----------------------------------------------------------------

We should stop using this class entirely ideally.
Comment 3 Ehren Metcalfe 2012-05-03 04:36:10 PDT
> We should stop using this class entirely ideally.

hmm, there appears to be more removals (that are difficult to detect statically): http://mxr.mozilla.org/mozilla-central/search?string=gTxTemplateElementHandlers&filter=[Gg]TxTemplateElementHandlers 

will post followup this evening
Comment 4 Ehren Metcalfe 2012-05-03 05:14:00 PDT
> hmm, there appears to be more removals (that are difficult to detect
> statically):
> http://mxr.mozilla.org/mozilla-central/
> search?string=gTxTemplateElementHandlers&filter=[Gg]TxTemplateElementHandlers

oops, spoke too soon http://mxr.mozilla.org/mozilla-central/source/content/xslt/src/xslt/txStylesheetCompileHandlers.cpp#3059
Comment 5 Ryan VanderMeulen [:RyanVM] 2012-05-03 15:40:29 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/d6c77d2796c0
Comment 6 Ed Morley [:emorley] 2012-05-04 10:36:34 PDT
https://hg.mozilla.org/mozilla-central/rev/d6c77d2796c0

Note You need to log in before you can comment on or make changes to this bug.