751416 - Remove unused txList[Iterator] methods

Status: RESOLVED FIXED

(Core :: XSLT, defect)

Description

[Ehren Metcalfe]

Noting its comment, it may be dangerous to remove hasPrevious while previous is still used...

Comment 1

[Ehren Metcalfe]

Attachment: patch

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 620518 [details] [diff] [review]
patch

Review of attachment 620518 [details] [diff] [review]:
-----------------------------------------------------------------

We should stop using this class entirely ideally.

Comment 3

[Ehren Metcalfe]

> We should stop using this class entirely ideally.

hmm, there appears to be more removals (that are difficult to detect statically): http://mxr.mozilla.org/mozilla-central/search?string=gTxTemplateElementHandlers&filter=[Gg]TxTemplateElementHandlers 

will post followup this evening

Comment 4

[Ehren Metcalfe]

> hmm, there appears to be more removals (that are difficult to detect
> statically):
> http://mxr.mozilla.org/mozilla-central/
> search?string=gTxTemplateElementHandlers&filter=[Gg]TxTemplateElementHandlers

oops, spoke too soon http://mxr.mozilla.org/mozilla-central/source/content/xslt/src/xslt/txStylesheetCompileHandlers.cpp#3059

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d6c77d2796c0

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d6c77d2796c0