Closed Bug 751416 Opened 12 years ago Closed 12 years ago

Remove unused txList[Iterator] methods

Categories

(Core :: XSLT, defect)

Product:
Core
Component:
XSLT
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla15

People

(Reporter: ehren.m, Assigned: ehren.m)

References

Details

Attachments

(1 file)

patch
7.11 KB, patch
sicking
: review+
Details | Diff | Splinter Review 
Noting its comment, it may be dangerous to remove hasPrevious while previous is still used...
Attached patch patch — — Splinter Review 

        Attachment #620518 -
        Flags: review?(peterv)

    
    

    
  
Comment on attachment 620518 [details] [diff] [review]
patch

Review of attachment 620518 [details] [diff] [review]:
-----------------------------------------------------------------

We should stop using this class entirely ideally.

        Attachment #620518 -
        Flags: review?(peterv) → review+

    
  
Status: NEW → ASSIGNED
Keywords: checkin-needed
Version: unspecified → Trunk

    
    

    
  
> We should stop using this class entirely ideally.

hmm, there appears to be more removals (that are difficult to detect statically): http://mxr.mozilla.org/mozilla-central/search?string=gTxTemplateElementHandlers&filter=[Gg]TxTemplateElementHandlers 

will post followup this evening

    
    

    
  
> hmm, there appears to be more removals (that are difficult to detect
> statically):
> http://mxr.mozilla.org/mozilla-central/
> search?string=gTxTemplateElementHandlers&filter=[Gg]TxTemplateElementHandlers

oops, spoke too soon http://mxr.mozilla.org/mozilla-central/source/content/xslt/src/xslt/txStylesheetCompileHandlers.cpp#3059

    
    

    
  
https://hg.mozilla.org/integration/mozilla-inbound/rev/d6c77d2796c0
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → mozilla15

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/d6c77d2796c0
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.