751439 - Icons must be square

Status: RESOLVED FIXED

(Marketplace Graveyard :: Developer Pages, defect, P4)

Description

[Andy McKay]

In the validation we don't check that the icons are square. We don't check for that when we fetch icons from the app. Having a non-square icon would be pretty crazy, but we should check for it.

Comment 1

[Wil Clouser [:clouserw]]

We resize icons, right?  So, what is the current output?  Does this look ridiculous or just some padding or something?

Comment 2

[Christopher Van Wiemeersch [:cvan]]

(In reply to Wil Clouser [:clouserw] from comment #1)
> We resize icons, right?  So, what is the current output?  Does this look
> ridiculous or just some padding or something?

In some cases icons can look real weird - especially when they're in your Dock or on your B2G device. See http://cl.ly/11063Z2V192b3R0E043i

Comment 3

[Wil Clouser [:clouserw]]

Ok.  I'm comfortable leaving this as a low priority.  People want their apps to succeed and will upload icons that look good (leaving aside the fact that this is a corner case for icons anyway).  Thanks for the screenshot.

Comment 4

[Christopher Van Wiemeersch [:cvan]]

I have a patch for this, but then I was thinking maybe we don't care if the icon is square for like weirdly shaped transparent icons. Eh, I'll get an r anyway.

Comment 5

[Christopher Van Wiemeersch [:cvan]]

This is easy.

Comment 6

[Matt Basta [:basta]]

This is something that needs a check in the validator since the icons on Marketplace aren't (for non-packaged apps, anyway) the same icons that the browser sees. The icons in the manifest need to be square.

There's a bug somewhere (the number escapes me) to check that the URLs for icons return 200. This could be done as part of that test.

Comment 7

[Matt Basta [:basta]]

This is now being tested for in the validator:

https://github.com/mozilla/app-validator/commit/6a94fdcc28c9501b5170a771582bed997ccc9d0a

A check needs to be added in the icon upload function, as well.

Comment 8

[Matt Basta [:basta]]

Merged in zamboni:

https://github.com/mozilla/zamboni/commit/4771473327f47676011edf4b30a3aaac71a1b417