751592 - Windows debug builders failing due to error in Root.h / Upgrade to Windows 2010

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Mark Banner (:standard8)]

Changes in mozilla-central have broken the Windows debug builds with:

e:\builds\moz2_slave\tb-comm-cen-w32-dbg\build\mozilla\js\src\gc/Root.h(303) : fatal error C1075: end of file found before the left brace '{' at 'e:/builds/moz2_slave/tb-comm-cen-w32-dbg/build/mozilla/js/src/jsnum.cpp(1232)' was matched

As we're currently upgrading to the Firefox architecture, the new builders have Visual Studio 2010 installed and if we upgrade to it, then it fixes the build issue.

However, currently it also breaks mozmill tests in debug mode, I'm trying to work out what the opt ones are doing before working out where we go next.

Comment 1

[David :Bienvenu]

My suspicion is that mozilla-central will continue to break vc 2005, and that we're better off moving to vc 2010 as best we can. There are disadvantages to 2010 (apparently, breakpad stack traces aren't as good), and the IDE is dog slow, but I think we're still better off being on the same compiler as Firefox.

Comment 2

[Mark Banner (:standard8)]

Attachment: The fix

Although the bustage is now fixed, I think we should upgrade anyway. This will match our mozconfigs against Firefox and take the necessary updates.

Try server builds available here:

https://ftp.mozilla.org/pub/mozilla.org/thunderbird/try-builds/[e-mail]-f766d16dc6d0/

(ignore the Win64 directory as that's already upgraded)

Comment 3

[David :Bienvenu]

Comment on attachment 621952 [details] [diff] [review]
The fix

yeah, I agree...

Comment 4

[Mark Banner (:standard8)]

Checked in: https://hg.mozilla.org/comm-central/rev/8be0dde5ccde