The default bug view has changed. See this FAQ.

Windows debug builders failing due to error in Root.h / Upgrade to Windows 2010

RESOLVED FIXED in Thunderbird 15.0

Status

Thunderbird
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Trunk
Thunderbird 15.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Changes in mozilla-central have broken the Windows debug builds with:

e:\builds\moz2_slave\tb-comm-cen-w32-dbg\build\mozilla\js\src\gc/Root.h(303) : fatal error C1075: end of file found before the left brace '{' at 'e:/builds/moz2_slave/tb-comm-cen-w32-dbg/build/mozilla/js/src/jsnum.cpp(1232)' was matched

As we're currently upgrading to the Firefox architecture, the new builders have Visual Studio 2010 installed and if we upgrade to it, then it fixes the build issue.

However, currently it also breaks mozmill tests in debug mode, I'm trying to work out what the opt ones are doing before working out where we go next.

Comment 1

5 years ago
My suspicion is that mozilla-central will continue to break vc 2005, and that we're better off moving to vc 2010 as best we can. There are disadvantages to 2010 (apparently, breakpad stack traces aren't as good), and the IDE is dog slow, but I think we're still better off being on the same compiler as Firefox.
(Assignee)

Comment 2

5 years ago
Created attachment 621952 [details] [diff] [review]
The fix

Although the bustage is now fixed, I think we should upgrade anyway. This will match our mozconfigs against Firefox and take the necessary updates.

Try server builds available here:

https://ftp.mozilla.org/pub/mozilla.org/thunderbird/try-builds/bugzilla@standard8.plus.com-f766d16dc6d0/

(ignore the Win64 directory as that's already upgraded)
Assignee: nobody → mbanner
Status: NEW → ASSIGNED
Attachment #621952 - Flags: review?(dbienvenu)

Comment 3

5 years ago
Comment on attachment 621952 [details] [diff] [review]
The fix

yeah, I agree...
Attachment #621952 - Flags: review?(dbienvenu) → review+
(Assignee)

Comment 4

5 years ago
Checked in: https://hg.mozilla.org/comm-central/rev/8be0dde5ccde
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 15.0
(Assignee)

Updated

5 years ago
Depends on: 753456
You need to log in before you can comment on or make changes to this bug.