Closed Bug 751598 Opened 9 years ago Closed 9 years ago

sync Mozilla trees to npapi-sdk r20

Categories

(Core :: Plug-ins, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla15
Tracking Status
firefox13 + fixed
firefox14 + fixed
firefox15 --- fixed

People

(Reporter: jaas, Assigned: jaas)

References

Details

Attachments

(2 files, 3 obsolete files)

Attached patch fix v1.0 (obsolete) — Splinter Review
We need to update to a new version of npapi-sdk to pick up a number of changes.
Attachment #620737 - Flags: review?(bas.schouten)
Attachment #620737 - Flags: review?(bas.schouten) → review+
Depends on: 751602
Attached patch fix v1.1 (obsolete) — Splinter Review
Compile fix.
Attachment #620737 - Attachment is obsolete: true
Better try server run:

https://tbpl.mozilla.org/?tree=Try&rev=80237bebdaf7
Summary: sync Mozilla trees to npapi-sdk r18 → sync Mozilla trees to npapi-sdk r20
Attached patch fix v1.2 (obsolete) — Splinter Review
Another compile fix.
Attachment #620867 - Attachment is obsolete: true
Attached patch fix v1.3Splinter Review
This patch drops the removal of some android-specific code we added to our headers.
Attachment #620962 - Attachment is obsolete: true
We really should update these headers for Firefox 13 and 14 as well. They have incorrect NPAPI values, a potential binary compatibility problem. Marking this tracking+ for those releases for this reason.
https://hg.mozilla.org/mozilla-central/rev/db4ba89d95ec
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
[Approval Request Comment]
Regression caused by (bug #): 651192
User impact if declined: Binary compatibility risk for plugins.
Testing completed (on m-c, etc.): already on m-c
Risk to taking this patch (and alternatives if risky): Plugins may be released with binary compatibility problems if they reference unpatched NPAPI headers, regardless of whether the feature is turned on in this particular build or not.
String changes made by this patch: none
Attachment #621604 - Flags: approval-mozilla-aurora?
(In reply to Josh Aas (Mozilla Corporation) from comment #12)
> User impact if declined: Binary compatibility risk for plugins.

What's our plan of attack for FF13?
(In reply to Alex Keybl [:akeybl] from comment #13)

> What's our plan of attack for FF13?

My plan is to try to land this for FF13 as well, thought I'd start with FF14. As soon as I get approval I'll post patches for FF13. Even if we can't get to FF13 for some reason, getting this done for FF14 is still good.
Comment on attachment 621604 [details] [diff] [review]
fix v1.3 for Aurora

[Triage Comment]
Approved for Aurora 14. We should land asap and then uplift to beta prior to our next go-to-build (5/15).
Attachment #621604 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Aurora Windows build error:

PluginMessageUtils.h(98) : error C2065: 'NPDrawingModelAsyncWindowsDX9ExSurface' : undeclared identifier
pushed to mozilla-aurora again, compile fix is in the patch for bug 751602

http://hg.mozilla.org/releases/mozilla-aurora/rev/56d137349efc
Comment on attachment 621604 [details] [diff] [review]
fix v1.3 for Aurora

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: 
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):
String changes made by this patch:
Attachment #621604 - Flags: approval-mozilla-beta?
We'll hold off on approving this one until we get a bit more feedback from Aurora.
Comment on attachment 621604 [details] [diff] [review]
fix v1.3 for Aurora

This has had some bake time now - approved for beta 13.
Attachment #621604 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.