sync Mozilla trees to npapi-sdk r20

RESOLVED FIXED in Firefox 13

Status

()

Core
Plug-ins
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Josh Aas, Assigned: Josh Aas)

Tracking

Trunk
mozilla15
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox13+ fixed, firefox14+ fixed, firefox15 fixed)

Details

Attachments

(2 attachments, 3 obsolete attachments)

(Assignee)

Description

5 years ago
Created attachment 620737 [details] [diff] [review]
fix v1.0

We need to update to a new version of npapi-sdk to pick up a number of changes.
Attachment #620737 - Flags: review?(bas.schouten)
Attachment #620737 - Flags: review?(bas.schouten) → review+
(Assignee)

Updated

5 years ago
Depends on: 751602
(Assignee)

Comment 1

5 years ago
Try server run:

https://tbpl.mozilla.org/?tree=Try&rev=25932b8b16a3
(Assignee)

Comment 2

5 years ago
Created attachment 620867 [details] [diff] [review]
fix v1.1

Compile fix.
Attachment #620737 - Attachment is obsolete: true
(Assignee)

Comment 3

5 years ago
Try server run:

https://tbpl.mozilla.org/?tree=Try&rev=af5c8cf3be32
(Assignee)

Comment 4

5 years ago
Better try server run:

https://tbpl.mozilla.org/?tree=Try&rev=80237bebdaf7
(Assignee)

Updated

5 years ago
Summary: sync Mozilla trees to npapi-sdk r18 → sync Mozilla trees to npapi-sdk r20
(Assignee)

Comment 5

5 years ago
Created attachment 620962 [details] [diff] [review]
fix v1.2

Another compile fix.
Attachment #620867 - Attachment is obsolete: true
(Assignee)

Comment 6

5 years ago
Updated try run:

https://tbpl.mozilla.org/?tree=Try&rev=74493bf39656
(Assignee)

Comment 7

5 years ago
Created attachment 621023 [details] [diff] [review]
fix v1.3

This patch drops the removal of some android-specific code we added to our headers.
Attachment #620962 - Attachment is obsolete: true
(Assignee)

Comment 8

5 years ago
Updated try run:

https://tbpl.mozilla.org/?tree=Try&rev=6fe378eec17b
(Assignee)

Comment 9

5 years ago
pushed to mozilla-inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/db4ba89d95ec
(Assignee)

Comment 10

5 years ago
We really should update these headers for Firefox 13 and 14 as well. They have incorrect NPAPI values, a potential binary compatibility problem. Marking this tracking+ for those releases for this reason.
tracking-firefox13: --- → +
tracking-firefox14: --- → +
https://hg.mozilla.org/mozilla-central/rev/db4ba89d95ec
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
(Assignee)

Comment 12

5 years ago
Created attachment 621604 [details] [diff] [review]
fix v1.3 for Aurora

[Approval Request Comment]
Regression caused by (bug #): 651192
User impact if declined: Binary compatibility risk for plugins.
Testing completed (on m-c, etc.): already on m-c
Risk to taking this patch (and alternatives if risky): Plugins may be released with binary compatibility problems if they reference unpatched NPAPI headers, regardless of whether the feature is turned on in this particular build or not.
String changes made by this patch: none
Attachment #621604 - Flags: approval-mozilla-aurora?
(In reply to Josh Aas (Mozilla Corporation) from comment #12)
> User impact if declined: Binary compatibility risk for plugins.

What's our plan of attack for FF13?
(Assignee)

Comment 14

5 years ago
(In reply to Alex Keybl [:akeybl] from comment #13)

> What's our plan of attack for FF13?

My plan is to try to land this for FF13 as well, thought I'd start with FF14. As soon as I get approval I'll post patches for FF13. Even if we can't get to FF13 for some reason, getting this done for FF14 is still good.
Comment on attachment 621604 [details] [diff] [review]
fix v1.3 for Aurora

[Triage Comment]
Approved for Aurora 14. We should land asap and then uplift to beta prior to our next go-to-build (5/15).
Attachment #621604 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 16

5 years ago
pushed to mozilla-aurora

https://hg.mozilla.org/releases/mozilla-aurora/rev/0b71fae84829
(Assignee)

Updated

5 years ago
status-firefox13: --- → affected
status-firefox14: --- → fixed
status-firefox15: --- → fixed
Backed out on Aurora because of build errors on Windows:
https://hg.mozilla.org/releases/mozilla-aurora/rev/91b4b9f38e40
status-firefox14: fixed → affected
(Assignee)

Comment 18

5 years ago
Aurora Windows build error:

PluginMessageUtils.h(98) : error C2065: 'NPDrawingModelAsyncWindowsDX9ExSurface' : undeclared identifier
(Assignee)

Comment 19

5 years ago
pushed to mozilla-aurora again, compile fix is in the patch for bug 751602

http://hg.mozilla.org/releases/mozilla-aurora/rev/56d137349efc
status-firefox14: affected → fixed
(Assignee)

Comment 20

5 years ago
Comment on attachment 621604 [details] [diff] [review]
fix v1.3 for Aurora

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: 
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):
String changes made by this patch:
Attachment #621604 - Flags: approval-mozilla-beta?
We'll hold off on approving this one until we get a bit more feedback from Aurora.
Comment on attachment 621604 [details] [diff] [review]
fix v1.3 for Aurora

This has had some bake time now - approved for beta 13.
Attachment #621604 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
(Assignee)

Comment 23

5 years ago
pushed to mozilla-beta

https://hg.mozilla.org/releases/mozilla-beta/rev/5f412ea09aba
status-firefox13: affected → fixed
You need to log in before you can comment on or make changes to this bug.