Created attachment 620739 [details] [diff] [review] fix v1.0
Created attachment 620760 [details] [diff] [review] fix v1.1
Comment on attachment 620760 [details] [diff] [review] fix v1.1 Made another mistake, I need to stop rushing this!
Created attachment 620777 [details] [diff] [review] fix v1.2
Created attachment 620791 [details] [diff] [review] fix v1.2 (real patch) That time I got the patch right but included a bunch of other changes! Here's the patch without those.
try server run: https://tbpl.mozilla.org/?tree=Try&rev=25932b8b16a3
Try server run with a compile fix in the other patch: https://tbpl.mozilla.org/?tree=Try&rev=80237bebdaf7
Created attachment 620963 [details] [diff] [review] fix v1.3 Added another compile fix.
Updated try run: https://tbpl.mozilla.org/?tree=Try&rev=74493bf39656
Updated try run with compile fix for NPAPI headers: https://tbpl.mozilla.org/?tree=Try&rev=6fe378eec17b
pushed to mozilla-inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/92f6c58e90c5
Comment on attachment 620963 [details] [diff] [review] fix v1.3 [Approval Request Comment] Regression caused by (bug #): 651192 User impact if declined: Binary compatibility risk for plugins. Testing completed (on m-c, etc.): already on m-c Risk to taking this patch (and alternatives if risky): This is a required patch for bug 751598, the real fix. Plugins may be released with binary compatibility problems if they reference unpatched NPAPI headers, regardless of whether the feature is turned on in this particular build or not. String changes made by this patch: none
We'd like to nail down the plan for both FF13 and FF14 before approving. See https://bugzilla.mozilla.org/show_bug.cgi?id=751598#c13
pushed to mozilla-aurora https://hg.mozilla.org/releases/mozilla-aurora/rev/c19c13e83f94
Backed out on Aurora because of build errors on Windows: https://hg.mozilla.org/releases/mozilla-aurora/rev/91b4b9f38e40
I don't have a Windows build environment handy and I don't see a way to do try server builds with Aurora. Fix is pretty straight-forward though, so trying again. Will back out myself if it doesn't work.
pushed to mozilla-aurora again http://hg.mozilla.org/releases/mozilla-aurora/rev/35f963416ff0
Comment on attachment 623588 [details] [diff] [review] fix v1.4 for Aurora This has had some bake time now - approved for beta 13.
pushed to mozilla-beta https://hg.mozilla.org/releases/mozilla-beta/rev/66f87d8a5eab