Closed Bug 751602 Opened 9 years ago Closed 9 years ago

compile fixes for drawing models (add ifdefs)

Categories

(Core :: Plug-ins, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla15
Tracking Status
firefox13 --- fixed
firefox14 --- fixed
firefox15 --- fixed

People

(Reporter: jaas, Assigned: jaas)

References

Details

Attachments

(2 files, 4 obsolete files)

Attached patch fix v1.0 (obsolete) — Splinter Review
No description provided.
Attachment #620739 - Flags: review?(bas.schouten)
Summary: add ifdef for windows sync drawing model → add ifdef for sync drawing models in ipc code
Attached patch fix v1.1 (obsolete) — Splinter Review
Attachment #620739 - Attachment is obsolete: true
Attachment #620739 - Flags: review?(bas.schouten)
Attachment #620760 - Flags: review?(bas.schouten)
Comment on attachment 620760 [details] [diff] [review]
fix v1.1

Made another mistake, I need to stop rushing this!
Attachment #620760 - Attachment is obsolete: true
Attachment #620760 - Flags: review?(bas.schouten)
Attached patch fix v1.2 (obsolete) — Splinter Review
Attachment #620777 - Flags: review?(bas.schouten)
Attachment #620777 - Flags: review?(bas.schouten) → review+
Attached patch fix v1.2 (real patch) (obsolete) — Splinter Review
That time I got the patch right but included a bunch of other changes! Here's the patch without those.
Attachment #620777 - Attachment is obsolete: true
Blocks: 751598
Try server run with a compile fix in the other patch:

https://tbpl.mozilla.org/?tree=Try&rev=80237bebdaf7
Summary: add ifdef for sync drawing models in ipc code → compile fixes for drawing models (add ifdefs)
Attached patch fix v1.3Splinter Review
Added another compile fix.
Attachment #620791 - Attachment is obsolete: true
Updated try run with compile fix for NPAPI headers:

https://tbpl.mozilla.org/?tree=Try&rev=6fe378eec17b
https://hg.mozilla.org/mozilla-central/rev/92f6c58e90c5
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
Comment on attachment 620963 [details] [diff] [review]
fix v1.3

[Approval Request Comment]
Regression caused by (bug #): 651192
User impact if declined: Binary compatibility risk for plugins.
Testing completed (on m-c, etc.): already on m-c
Risk to taking this patch (and alternatives if risky): This is a required patch for bug 751598, the real fix. Plugins may be released with binary compatibility problems if they reference unpatched NPAPI headers, regardless of whether the feature is turned on in this particular build or not.
String changes made by this patch: none
Attachment #620963 - Flags: approval-mozilla-aurora?
We'd like to nail down the plan for both FF13 and FF14 before approving. See https://bugzilla.mozilla.org/show_bug.cgi?id=751598#c13
Attachment #620963 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
I don't have a Windows build environment handy and I don't see a way to do try server builds with Aurora. Fix is pretty straight-forward though, so trying again. Will back out myself if it doesn't work.
Attachment #623588 - Flags: approval-mozilla-beta?
Comment on attachment 623588 [details] [diff] [review]
fix v1.4 for Aurora

This has had some bake time now - approved for beta 13.
Attachment #623588 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.