75169 - [API] strings do not compile cleanly on Win32

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Chris Waterson]

I'm seeing the following warnings when compiling nsLineBox.cpp. I'm frightened. 
I suspect that some of the classes in the string library need to be declared 
__declspec(dllexport), but am not really sure.

nsLineBox.cpp
..\..\..\..\dist\include\nsLocalString.h(80) : warning C4251: 'mHandle' : 
class 'nsBufferHandle<unsigned short>' needs to have dll-interface to be used 
by clients of class 'nsLocalString'
..\..\..\..\dist\include\nsLocalString.h(120) : warning C4251: 'mHandle' : 
class 'nsBufferHandle<char>' needs to have dll-interface to be used by clients 
of class 'nsLocalCString'
..\..\..\..\dist\include\nsCommonString.h(69) : warning C4251: 'mBuffer' : 
class 'nsAutoBufferHandle<unsigned short>' needs to have dll-interface to be 
used by clients of class 'nsCommonString'
..\..\..\..\dist\include\nsCommonString.h(98) : warning C4251: 'mBuffer' : 
class 'nsAutoBufferHandle<char>' needs to have dll-interface to be used by 
clients of class 'nsCommonCString'

Comment 1

[Scott Collins]

I need to untemplatize the buffer handle classes to eliminate these warnings.

Comment 2

[Bernd]

*** Bug 75025 has been marked as a duplicate of this bug. ***

Comment 3

[Scott Collins]

These are the 0.9 bugs that didn't make it, and that I intend to fix in 0.9.1

Comment 4

[Scott Collins]

re-targeting milestones, starting from a clean slate

Comment 5

[Scott Collins]

All planned string API fixes need to be in by mozilla1.0.

Comment 6

[Scott Collins]

See

  http://lxr.mozilla.org/seamonkey/search?string=BufferHandle%3C

for a list of places that would be touched by an untemplitization.

Comment 7

[Scott Collins]

I will not be bullied.  After analysis of this bug, and discussion with jst, I
have decided not to untemplatize these classes.  No compiler mis-selections or
errors have been associated with these templates, and it's a waste of time,
effort, and churn to untemplatize them just to quite warnings that are in error
(no actual linkage problems exist, the warnings are false).  Therefore, the
right fix is to disable that warning.  Additionally, there are typos in my
constants that I will fix in the same patch.  Patch will be attached anon.

Comment 8

[Scott Collins]

s/quite/quiet/

Comment 9

[Johnny Stenback (:jst)]

Attachment: Add #pragma warning to quiet down the warnings.

Comment 10

[Chris Waterson]

Not sure who's bullying you here (FWIW, I thought you already _did_ untemplatize
these classes; wasn't that what the big mozilla-0.8.1 string landing was about?
Guess I've been asleep at the wheel lately.)

Anyway, I think you'll want to put that under |#ifdef XP_WIN|, right?

Comment 11

[Scott Collins]

The compiler warnings were bullying me :-)  We have other |#pragma disable|s not
protected by |#ifdef| elsewhere in the build, but if you think it's needed, I'll
modify the patch.

Comment 12

[Scott Collins]

Attachment: add comments, wrap in |#ifdef XP_WIN| as per waterson, fix nearby typos

Comment 13

[Scott Collins]

looking to waterson for sr=, jst for r=, and I'll send mail

Comment 14

[Chris Waterson]

sr=waterson

Comment 15

[Johnny Stenback (:jst)]

r=jst

Comment 16

[Scott Collins]

fix checked in