Closed
Bug 751941
Opened 13 years ago
Closed 13 years ago
Last Italian nightly build (2012-05-04) contains strings from a different locale
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: flod, Assigned: khuey)
References
Details
Attachments
(2 files)
|
48.17 KB,
image/jpeg
|
Details | |
|
1.82 KB,
patch
|
khuey
:
review+
mozilla
:
checked-in+
|
Details | Diff | Splinter Review |
I've just updated my Italian nightly build and it's a mix of Italian (it) and Hungarian (hu).
For example: menus are in Hungarian, but the error page is displayed in Italian.
Not sure where I can check the log for this build.
Comment 1•13 years ago
|
||
Naoki, can you take a look at this?
| Reporter | ||
Comment 2•13 years ago
|
||
Still the same after an update to 2012-05-05. CCing l10n-community to understand if it's happening only to us.
Comment 3•13 years ago
|
||
i don't see this problem with the nl build on a galaxy s plus
Comment 4•13 years ago
|
||
Over to release engineering for investigation. For what it's worth, the strings seem to be Hungarian.
Suspect is not cleaning up the l10n-merge dir, or not using one per-locale.
Component: General → Release Engineering: Automation (General)
Product: Fennec Native → mozilla.org
QA Contact: general → catlee
Version: Trunk → other
Comment 5•13 years ago
|
||
Confirming for es-ES. I've just updated to latest nightly (I had a version from 1st May) and our strings (in menus) are in English
Comment 6•13 years ago
|
||
Same for ES-AR. Menus are shown in english.
Comment 7•13 years ago
|
||
Aki suggested bug 748130 as a possible suspect. Can you test aurora vs nightly, as that bug is only on nightly, and not on aurora?
| Reporter | ||
Comment 8•13 years ago
|
||
Aurora 14.0a2 (2012-05-07) is completely localized in Italian, Nightly from the same day is still a mix of Hungarian and Italian.
Comment 9•13 years ago
|
||
Is this Android-only?
Comment 10•13 years ago
|
||
not sure how we'd verify that, as the automation on desktop is rather different to that on mobile, notably, the locales that follow each other, and how, is totally different.
Comment 11•13 years ago
|
||
Well, presumably a spot check of a few desktop l10n builds would show whether the issue exists there or not.
Comment 12•13 years ago
|
||
Downloading the Hungarian and Italian builds from:
http://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/latest-mozilla-central-android-l10n/fennec-15.0a1.hu.android-arm.apk
http://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/latest-mozilla-central-android-l10n/fennec-15.0a1.it.android-arm.apk
and unpacking them with http://code.google.com/p/android-apktool/, I note that the strings.xml files are identical, so that bug seems likely as the regressor.
Comment 13•13 years ago
|
||
and looking at the logfile, you can see that the Hungarian repack processes strings.xml:
06:55:49 INFO - make[2]: Entering directory `/builds/slave/m-cen-andrd-l10n-3/build/mozilla-central/obj-l10n/mobile/android/base/locales'
06:55:49 INFO - /builds/slave/m-cen-andrd-l10n-3/build/mozilla-central/obj-l10n/config/nsinstall -D ../res/values
06:55:49 INFO - /tools/python/bin/python2.5 /builds/slave/m-cen-andrd-l10n-3/build/mozilla-central/config/Preprocessor.py \
06:55:49 INFO - -DAB_CD=hu -DXPI_NAME=locale-hu \
06:55:49 INFO - -DBRANDPATH="/builds/slave/m-cen-andrd-l10n-3/build/mozilla-central/obj-l10n/mobile/android/base/locales/../../../../dist/xpi-stage/locale-hu/chrome/hu/locale/branding/brand.dtd" \
06:55:49 INFO - -DSTRINGSPATH="/builds/slave/m-cen-andrd-l10n-3/build/mozilla-central/obj-l10n/merged//mobile/android/base/android_strings.dtd" \
06:55:49 INFO - -DSYNCSTRINGSPATH="/builds/slave/m-cen-andrd-l10n-3/build/mozilla-central/obj-l10n/merged//mobile/android/base/sync_strings.dtd" \
06:55:49 INFO - -DBOOKMARKSPATH="/builds/slave/m-cen-andrd-l10n-3/build/l10n-central/hu/mobile/profile/bookmarks.inc" \
06:55:49 INFO - /builds/slave/m-cen-andrd-l10n-3/build/mozilla-central/mobile/android/base/locales/../strings.xml.in \
06:55:49 INFO - > ../res/values/strings.xml
06:55:49 INFO - make[2]: Leaving directory `/builds/slave/m-cen-andrd-l10n-3/build/mozilla-central/obj-l10n/mobile/android/base/locales'
but the Italian repack does not:
06:56:27 INFO - make[2]: Entering directory `/builds/slave/m-cen-andrd-l10n-3/build/mozilla-central/obj-l10n/mobile/android/base/locales'
06:56:27 INFO - make[2]: Nothing to be done for `libs'.
06:56:27 INFO - make[2]: Leaving directory `/builds/slave/m-cen-andrd-l10n-3/build/mozilla-central/obj-l10n/mobile/android/base/locales'
Comment 14•13 years ago
|
||
Joey - over to you as it seems bug 748130 regressed something.
Assignee: nobody → joey
Comment 15•13 years ago
|
||
:flod
After khuey landed this on m-c: http://hg.mozilla.org/mozilla-central/rev/3b06e981ce0d, I kicked off new nightlies, which are now available.
Can you update to latest nightly and see if that now has correct locale strings for you?
Updated•13 years ago
|
Assignee: joey → khuey
| Reporter | ||
Comment 16•13 years ago
|
||
(In reply to John O'Duinn [:joduinn] from comment #15)
> After khuey landed this on m-c:
> http://hg.mozilla.org/mozilla-central/rev/3b06e981ce0d, I kicked off new
> nightlies, which are now available.
Still no updates available, and builds on FTP are from yesterday, not sure is something went wrong.
http://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/latest-mozilla-central-android-l10n/
| Assignee | ||
Comment 17•13 years ago
|
||
Yeah, we're still sorting through it, but it looks like the repacks are using some out of date copy of m-c.
Comment 18•13 years ago
|
||
Attachment #622748 -
Flags: review?(khuey)
| Assignee | ||
Updated•13 years ago
|
Attachment #622748 -
Flags: review?(khuey) → review+
Comment 19•13 years ago
|
||
Comment on attachment 622748 [details] [diff] [review]
point mobile single locale nightly repacks at the new en-US subdir
http://hg.mozilla.org/build/mozharness/rev/5f81f5493492
Respinning nightly mobile single locale repacks.
Attachment #622748 -
Flags: checked-in+
Comment 20•13 years ago
|
||
Ok, successfully respun the nightly mobile single locale repacks.
Now can we re-verify the latest Italian nightly?
| Assignee | ||
Comment 21•13 years ago
|
||
I downloaded http://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/latest-mozilla-central-android-l10n/fennec-15.0a1.it.android-arm.apk and it looks pretty Italian to me. I'll let flod check and close this out when he wakes up.
Comment 22•13 years ago
|
||
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #21)
> I downloaded
> http://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/latest-mozilla-central-
> android-l10n/fennec-15.0a1.it.android-arm.apk and it looks pretty Italian to
> me.
I downloaded and browsed using http://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/latest-mozilla-central-android-l10n/fennec-15.0a1.es-ES.android-arm.apk and it works in spanish (and only spanish!) as far as I can see.
> I'll let flod check and close this out when he wakes up.
wfm.
| Reporter | ||
Comment 23•13 years ago
|
||
(In reply to Aki Sasaki [:aki] from comment #20)
> Ok, successfully respun the nightly mobile single locale repacks.
> Now can we re-verify the latest Italian nightly?
Verified, now it's completely in Italian :-)
| Assignee | ||
Updated•13 years ago
|
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 24•13 years ago
|
||
(In reply to Francesco Lodolo [:flod] from comment #23)
> (In reply to Aki Sasaki [:aki] from comment #20)
> > Ok, successfully respun the nightly mobile single locale repacks.
> > Now can we re-verify the latest Italian nightly?
>
> Verified, now it's completely in Italian :-)
Great to hear, and thanks :flod for reporting this!
Updated•12 years ago
|
Product: mozilla.org → Release Engineering
Updated•7 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•