753863 - mobile_l10n.py broken by latest Fennec makefile changes

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Aki Sasaki (not active)]

I find the package name by doing a

  make echo-variable-PACKAGE AB_CD=%(locale)s

in OBJDIR/mobile/android/locales.

This is now giving me the output of

  cd ../../.. && CONFIG_HEADERS= CONFIG_FILES=config/autoconf.mk ./config.status

instead of the package name.

Ted says this works in mobile/android/installer :

[09:35]	<ted>	luser@cuatro:~/build$ make -C fennec-android-mozilla-central/mobile/android/installer/ echo-variable-PACKAGE
[09:35]	<ted>	fennec-15.0a1.en-US.android-arm.apk

We can either fix make echo-variable-PACKAGE in mobile/android/locales or change mobile_l10n.py to change directories for the package name.

Comment 1

[Aki Sasaki (not active)]

Attachment: partial package name fix

This should allow us to change which directory we call make echo-variable-* from.

I could hardcode mobile/android/installer in the script, but it would be more mozharness-y to put that in the config files.

I need to do that and test nightly repacks.

I also need to test to see if mobile/android/installer works for Aurora as well, or if we need to keep doing that in mobile/android/locales.

Comment 2

[Aki Sasaki (not active)]

13:11:46     INFO - Getting output from command: ['make', 'echo-variable-PACKAGE', 'AB_CD=%(locale)s'] in /builds/slave/aki/build/mozilla-central/obj-l10n/mobile/android/installer
13:11:47     INFO - Reading from file tmpfile_stdout
13:11:47     INFO -  cd ../../.. && CONFIG_HEADERS= CONFIG_FILES=config/autoconf.mk ./config.status
13:11:47     INFO - creating config/autoconf.mk


The directory doesn't seem to be what's wrong here.

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

It sounds like the objdir isn't up to date when you're running echo-variable-PACKAGE.

Comment 4

[Aki Sasaki (not active)]

This comes after a make -f client.mk configure and a 'make' in the config dir, as well as a make wget-en-US and make unpack.

However, after the unpack, we do hg update to the en-US revision; does that invalidate the configure?

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Changing the revision being used in any way potentially invalidates the configuration done earlier.

Comment 6

[Aki Sasaki (not active)]

Attachment: call configure both before and after unpack/hg up

That was it.
I wrote this to re-call the |make -f client.mk configure| and |make| in config/ after the |hg update|.
Afterwards I got the correct output:

13:40:27     INFO - Getting output from command: ['make', 'echo-variable-PACKAGE', 'AB_CD=%(locale)s'] in /builds/slave/aki/build/mozilla-central/obj-l10n/mobile/android/locales
13:40:27     INFO - Reading from file tmpfile_stdout
13:40:27     INFO -  fennec-15.0a1.%(locale)s.android-arm.apk

Jordan: do you feel comfortable reviewing this?

Comment 7

[Aki Sasaki (not active)]

Attachment: add staging single locale configs

This should make it more user-friendly to test this.

Comment 8

[Jordan Lund (:jlund)]

Comment on attachment 622896 [details] [diff] [review]
call configure both before and after unpack/hg up

looks fine to me. I would be up for trying to get the en_US revision prior to setup so we do not have to run 'make configure' twice. Ping me if that becomes important and its something you would like me to do.

Comment 9

[Aki Sasaki (not active)]

Comment on attachment 622896 [details] [diff] [review]
call configure both before and after unpack/hg up

http://hg.mozilla.org/build/mozharness/rev/90cae9848565

Comment 10

[Aki Sasaki (not active)]

Comment on attachment 622932 [details] [diff] [review]
add staging single locale configs

http://hg.mozilla.org/build/mozharness/rev/5a0729fe42c5

Comment 11

[Aki Sasaki (not active)]

This should now be fixed.
Respinning nightly l10n repacks to verify.

Comment 12

[Aki Sasaki (not active)]

Successful mobile l10n repack; now we can re-verify the strings are all one language.