752139 - libtheora ARM asm should mark its stacks non-executable

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Timothy B. Terriberry (:derf)]

Bug 671426 identifies several object files that do not indicate support for a non-executable stack. The ARM asm from libtheora is included in these. This bug is about fixing that asm to request a non-executable stack.

Comment 1

[Timothy B. Terriberry (:derf)]

Attachment: Mark stacks non-executable in the libtheora ARM asm

This patch comes from upstream commit r18031.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7a7c6d1e67e0

Comment 3

[Timothy B. Terriberry (:derf)]

(In reply to Ryan VanderMeulen from comment #2)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/7a7c6d1e67e0

Actually, this patch wasn't quite ready to get checked in yet. I posted it right away since it was part of an upstream commit, but hadn't verified that it solved all the problems. As it turned out it did not: we're still building armopts.s, which winds up being empty, but doesn't get marked as allowing a non-executable stack (because it doesn't contain a CODE section). I guess I'll need to post a follow-up patch to fix that now.

Please do not mark this bug fixed when you merge to m-c.

Comment 4

[Timothy B. Terriberry (:derf)]

Attachment: Don't build an empty armopts.s

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Will do.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

First patch:
https://hg.mozilla.org/mozilla-central/rev/7a7c6d1e67e0

Comment 7

[Timothy B. Terriberry (:derf)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7ac8857d0c83

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Follow-up patch:
https://hg.mozilla.org/mozilla-central/rev/7ac8857d0c83

Sorry about jumping the gun earlier. I'll leave your bugs alone in the future.

Comment 9

[Timothy B. Terriberry (:derf)]

(In reply to Ryan VanderMeulen from comment #8)
> Sorry about jumping the gun earlier. I'll leave your bugs alone in the
> future.

No worries, I should have done the patch right the first time.