The default bug view has changed. See this FAQ.

libtheora ARM asm should mark its stacks non-executable

RESOLVED FIXED in mozilla15

Status

()

Core
Audio/Video
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: derf, Assigned: derf)

Tracking

({sec-other})

Trunk
mozilla15
sec-other
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
Bug 671426 identifies several object files that do not indicate support for a non-executable stack. The ARM asm from libtheora is included in these. This bug is about fixing that asm to request a non-executable stack.
(Assignee)

Comment 1

5 years ago
Created attachment 621239 [details] [diff] [review]
Mark stacks non-executable in the libtheora ARM asm

This patch comes from upstream commit r18031.
Assignee: nobody → tterribe
Status: NEW → ASSIGNED
Attachment #621239 - Flags: review?(mh+mozilla)
(Assignee)

Updated

5 years ago
Blocks: 671426
No longer blocks: 620058
No longer depends on: 671426
Attachment #621239 - Flags: review?(mh+mozilla) → review+
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/7a7c6d1e67e0
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → mozilla15
(Assignee)

Comment 3

5 years ago
(In reply to Ryan VanderMeulen from comment #2)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/7a7c6d1e67e0

Actually, this patch wasn't quite ready to get checked in yet. I posted it right away since it was part of an upstream commit, but hadn't verified that it solved all the problems. As it turned out it did not: we're still building armopts.s, which winds up being empty, but doesn't get marked as allowing a non-executable stack (because it doesn't contain a CODE section). I guess I'll need to post a follow-up patch to fix that now.

Please do not mark this bug fixed when you merge to m-c.
(Assignee)

Comment 4

5 years ago
Created attachment 621366 [details] [diff] [review]
Don't build an empty armopts.s
Attachment #621366 - Flags: review?(mh+mozilla)
Will do.
Whiteboard: [leave open]
First patch:
https://hg.mozilla.org/mozilla-central/rev/7a7c6d1e67e0
Whiteboard: [leave open]
Attachment #621239 - Flags: checkin+
Attachment #621366 - Flags: review?(mh+mozilla) → review+
(Assignee)

Updated

5 years ago
Blocks: 752293
(Assignee)

Updated

5 years ago
No longer blocks: 752293
(Assignee)

Comment 7

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/7ac8857d0c83
Follow-up patch:
https://hg.mozilla.org/mozilla-central/rev/7ac8857d0c83

Sorry about jumping the gun earlier. I'll leave your bugs alone in the future.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Attachment #621366 - Flags: checkin+
(Assignee)

Comment 9

5 years ago
(In reply to Ryan VanderMeulen from comment #8)
> Sorry about jumping the gun earlier. I'll leave your bugs alone in the
> future.

No worries, I should have done the patch right the first time.
You need to log in before you can comment on or make changes to this bug.