Bug 671426 identifies several object files that do not indicate support for a non-executable stack. The ARM asm from libtheora is included in these. This bug is about fixing that asm to request a non-executable stack.
Created attachment 621239 [details] [diff] [review]
Mark stacks non-executable in the libtheora ARM asm
This patch comes from upstream commit r18031.
(In reply to Ryan VanderMeulen from comment #2)
Actually, this patch wasn't quite ready to get checked in yet. I posted it right away since it was part of an upstream commit, but hadn't verified that it solved all the problems. As it turned out it did not: we're still building armopts.s, which winds up being empty, but doesn't get marked as allowing a non-executable stack (because it doesn't contain a CODE section). I guess I'll need to post a follow-up patch to fix that now.
Please do not mark this bug fixed when you merge to m-c.
Created attachment 621366 [details] [diff] [review]
Don't build an empty armopts.s
Sorry about jumping the gun earlier. I'll leave your bugs alone in the future.
(In reply to Ryan VanderMeulen from comment #8)
> Sorry about jumping the gun earlier. I'll leave your bugs alone in the
No worries, I should have done the patch right the first time.