752293 - Y'CbCr to RGB ARM asm should mark its stacks non-executable

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Timothy B. Terriberry (:derf)]

Bug 671426 identifies several object files that do not indicate support for a non-executable stack. The ARM asm in gfx/ycbcr/yuv_row_arm.s is included in these. This bug is about fixing that asm to request a non-executable stack.

Comment 1

[Timothy B. Terriberry (:derf)]

Attachment: Mark stacks non-executable in yuv_row_arm.s

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 621391 [details] [diff] [review]
Mark stacks non-executable in yuv_row_arm.s

Review of attachment 621391 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/ycbcr/yuv_row_arm.s
@@ +332,5 @@
>      .size ScaleYCbCr42xToRGB565_BilinearY_Row_NEON, .-ScaleYCbCr42xToRGB565_BilinearY_Row_NEON
> +
> +#if defined(__ELF__)&&defined(__linux__)
> +    .section .note.GNU-stack,"",%progbits
> +#endif

Does that actually work? I thought .s files weren't preprocessed (as opposed to .S files)

Comment 3

[Timothy B. Terriberry (:derf)]

(In reply to Mike Hommey [:glandium] from comment #2)
> Does that actually work? I thought .s files weren't preprocessed (as opposed
> to .S files)

Yes it does. They apparently are in our build system (I remember some vague issue with the suffix our automatic rules use that made me use .s instead of .S when I wrote this file, but I don't remember the details).

Comment 4

[Timothy B. Terriberry (:derf)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4960479d3694

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4960479d3694