Y'CbCr to RGB ARM asm should mark its stacks non-executable

RESOLVED FIXED in mozilla15

Status

()

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: derf, Assigned: derf)

Tracking

({sec-other})

Trunk
mozilla15
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Bug 671426 identifies several object files that do not indicate support for a non-executable stack. The ARM asm in gfx/ycbcr/yuv_row_arm.s is included in these. This bug is about fixing that asm to request a non-executable stack.
Assignee: nobody → tterribe
Blocks: 671426
No longer blocks: 620058
No longer depends on: 671426, 752139
Comment on attachment 621391 [details] [diff] [review]
Mark stacks non-executable in yuv_row_arm.s

Review of attachment 621391 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/ycbcr/yuv_row_arm.s
@@ +332,5 @@
>      .size ScaleYCbCr42xToRGB565_BilinearY_Row_NEON, .-ScaleYCbCr42xToRGB565_BilinearY_Row_NEON
> +
> +#if defined(__ELF__)&&defined(__linux__)
> +    .section .note.GNU-stack,"",%progbits
> +#endif

Does that actually work? I thought .s files weren't preprocessed (as opposed to .S files)
(In reply to Mike Hommey [:glandium] from comment #2)
> Does that actually work? I thought .s files weren't preprocessed (as opposed
> to .S files)

Yes it does. They apparently are in our build system (I remember some vague issue with the suffix our automatic rules use that made me use .s instead of .S when I wrote this file, but I don't remember the details).
Status: NEW → ASSIGNED
Attachment #621391 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/4960479d3694
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.