752252 - Lightning test failures, mozinfo package cannot be imported

Status: RESOLVED FIXED

(Calendar :: Build Config, defect)

Description

[Philipp Kewisch [:Fallen][📱📆]]

The builders are getting the following errors on comm-central, which shows up as an orange. Maybe something changed how the xpcshell info is being processed? mozinfo is the information database for processing the xpcshell.ini.

Here is the error:


/tools/python/bin/python2.5 -u /buildbot/comm-central-linux/build/mozilla/config/pythonpath.py \
	  -I/buildbot/comm-central-linux/build/mozilla/build \
	  /buildbot/comm-central-linux/build/mozilla/testing/xpcshell/runxpcshelltests.py \
	  --symbols-path=../../mozilla/dist/crashreporter-symbols \
	  --build-info-json=../../mozilla/mozinfo.json \
	   \
	  /buildbot/comm-central-linux/build/objdir-tb/mozilla/dist/bin/xpcshell \
	  ../../mozilla/_tests/xpcshell/calendar/test/unit
Traceback (most recent call last):
  File "/buildbot/comm-central-linux/build/mozilla/config/pythonpath.py", line 52, in <module>
    main(sys.argv[1:])
  File "/buildbot/comm-central-linux/build/mozilla/config/pythonpath.py", line 44, in main
    execfile(script, frozenglobals)
  File "/buildbot/comm-central-linux/build/mozilla/testing/xpcshell/runxpcshelltests.py", line 48, in <module>
    import mozinfo
ImportError: No module named mozinfo
make: *** [xpcshell-tests] Error 1

Comment 1

[Philipp Kewisch [:Fallen][📱📆]]

Oh it seems this is only on the linux builders.

Comment 2

[:Irving Reid (No longer working on Firefox)]

I suspect it might be https://bugzilla.mozilla.org/show_bug.cgi?id=746545 - i'm tracking this down because running individual tests by hand under comm-central also fails (on OS X, for me)

Comment 3

[David :Bienvenu]

there are different rules for running all tests, and for running individual tests, iirc. I've tried changing the path, but then I get complaints about not being able to find manifestparser, which may just be a downstream error.

Comment 4

[:Irving Reid (No longer working on Firefox)]

Attachment: Port rules.mk changes to find mozinfo python module

Bring over a number of changes from mozilla-central rules.mk (see https://bugzilla.mozilla.org/show_bug.cgi?id=750368) to cope with the mozinfo.py removal from https://bugzilla.mozilla.org/show_bug.cgi?id=746545

Comment 5

[Justin Wood (:Callek)]

Comment on attachment 623238 [details] [diff] [review]
Port rules.mk changes to find mozinfo python module

I won't get at this for probably about a week or two, Mark might be able to grab it earlier

Comment 6

[David :Bienvenu]

fwiw, this fixes running tests for me on windows (though it didn't quite apply cleanly, I think because of whitespace changes)

Comment 7

[David :Bienvenu]

Attachment: perhaps de-bitrotted patch

the patch up for review didn't apply cleanly for me, but this one does, and seems to work.

Comment 8

[:Irving Reid (No longer working on Firefox)]

David's update to the patch looks fine; the original patch had some trivial whitespace removal that conflicted with someone else's change.

Comment 9

[Mark Banner (:standard8)]

Ok, so a bit of digging reveals you're actually porting bug 620905 and at least part of bug 729098. Not a problem but useful to know for review.

Comment 10

[Mark Banner (:standard8)]

Comment on attachment 625117 [details] [diff] [review]
perhaps de-bitrotted patch

Looks good. r=me.

Comment 11

[Mark Banner (:standard8)]

Checked in: https://hg.mozilla.org/comm-central/rev/6abc892b5ebd