Closed Bug 752252 Opened 9 years ago Closed 9 years ago

Lightning test failures, mozinfo package cannot be imported


(Calendar :: Build Config, defect)

Not set


(Not tracked)



(Reporter: Fallen, Assigned: Irving)




(1 file, 1 obsolete file)

The builders are getting the following errors on comm-central, which shows up as an orange. Maybe something changed how the xpcshell info is being processed? mozinfo is the information database for processing the xpcshell.ini.

Here is the error:

/tools/python/bin/python2.5 -u /buildbot/comm-central-linux/build/mozilla/config/ \
	  -I/buildbot/comm-central-linux/build/mozilla/build \
	  /buildbot/comm-central-linux/build/mozilla/testing/xpcshell/ \
	  --symbols-path=../../mozilla/dist/crashreporter-symbols \
	  --build-info-json=../../mozilla/mozinfo.json \
	  /buildbot/comm-central-linux/build/objdir-tb/mozilla/dist/bin/xpcshell \
Traceback (most recent call last):
  File "/buildbot/comm-central-linux/build/mozilla/config/", line 52, in <module>
  File "/buildbot/comm-central-linux/build/mozilla/config/", line 44, in main
    execfile(script, frozenglobals)
  File "/buildbot/comm-central-linux/build/mozilla/testing/xpcshell/", line 48, in <module>
    import mozinfo
ImportError: No module named mozinfo
make: *** [xpcshell-tests] Error 1
Oh it seems this is only on the linux builders.
I suspect it might be - i'm tracking this down because running individual tests by hand under comm-central also fails (on OS X, for me)
Depends on: 750368
there are different rules for running all tests, and for running individual tests, iirc. I've tried changing the path, but then I get complaints about not being able to find manifestparser, which may just be a downstream error.
Bring over a number of changes from mozilla-central (see to cope with the removal from
Attachment #623238 - Flags: review?(bugspam.Callek)
Comment on attachment 623238 [details] [diff] [review]
Port changes to find mozinfo python module

I won't get at this for probably about a week or two, Mark might be able to grab it earlier
Attachment #623238 - Flags: review?(mbanner)
Assignee: nobody → irving
fwiw, this fixes running tests for me on windows (though it didn't quite apply cleanly, I think because of whitespace changes)
the patch up for review didn't apply cleanly for me, but this one does, and seems to work.
David's update to the patch looks fine; the original patch had some trivial whitespace removal that conflicted with someone else's change.
Ok, so a bit of digging reveals you're actually porting bug 620905 and at least part of bug 729098. Not a problem but useful to know for review.
Depends on: 620905, 729098
Attachment #623238 - Attachment is obsolete: true
Attachment #623238 - Flags: review?(mbanner)
Attachment #623238 - Flags: review?(bugspam.Callek)
Comment on attachment 625117 [details] [diff] [review]
perhaps de-bitrotted patch

Looks good. r=me.
Attachment #625117 - Flags: review+
Checked in:
Closed: 9 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.