Last Comment Bug 752306 - Cleanup MessageHeader button min-height definition
: Cleanup MessageHeader button min-height definition
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Theme (show other bugs)
: unspecified
: All Windows 7
: -- normal (vote)
: Thunderbird 15.0
Assigned To: Richard Marti (:Paenglab)
:
:
Mentors:
Depends on:
Blocks: 741998
  Show dependency treegraph
 
Reported: 2012-05-06 04:17 PDT by Richard Marti (:Paenglab)
Modified: 2012-05-23 17:33 PDT (History)
2 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (1.35 KB, patch)
2012-05-06 04:20 PDT, Richard Marti (:Paenglab)
bugs: review-
Details | Diff | Splinter Review
patch v2 (1.68 KB, patch)
2012-05-09 12:59 PDT, Richard Marti (:Paenglab)
bugs: review+
Details | Diff | Splinter Review

Description Richard Marti (:Paenglab) 2012-05-06 04:17:17 PDT
After landing of bug 741998 the messageheader buttons don't have the same height in text only mode.
Comment 1 Richard Marti (:Paenglab) 2012-05-06 04:20:26 PDT
Created attachment 621402 [details] [diff] [review]
patch

Fix the min-height
Comment 2 Andreas Nilsson (:andreasn) 2012-05-09 05:21:16 PDT
Comment on attachment 621402 [details] [diff] [review]
patch

After applying the patch all message header buttons are now equally tall in the 3 modes, but different in height from the toolbar and QFB. I would rather see them all 24px tall. With this patch the icons starts to feel a bit crammed in.
Comment 3 Richard Marti (:Paenglab) 2012-05-09 12:59:28 PDT
Created attachment 622474 [details] [diff] [review]
patch v2

Set the min-height of 24px for all .toolbarbutton-1.
Comment 4 Andreas Nilsson (:andreasn) 2012-05-23 04:04:23 PDT
Comment on attachment 622474 [details] [diff] [review]
patch v2

diff --git a/mail/themes/qute/mail/messageHeader-aero.css b/mail/themes/qute/mail/messageHeader-aero.css

@@ -259,8 +258,6 @@
   /* important required to override primaryToolbar.css rules */
   -moz-padding-start: 3px !important;
   -moz-padding-end: 3px !important;
-  padding-top: 2px !important;
-  padding-bottom: 2px !important;
 }

I always feel good when we're able to remove !important


r+ me
Comment 5 Ryan VanderMeulen [:RyanVM] 2012-05-23 17:33:34 PDT
https://hg.mozilla.org/comm-central/rev/23f217579dee

Note You need to log in before you can comment on or make changes to this bug.