752306 - Cleanup MessageHeader button min-height definition

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

After landing of bug 741998 the messageheader buttons don't have the same height in text only mode.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: patch

Fix the min-height

Comment 2

[Andreas Nilsson (:andreasn)]

Comment on attachment 621402 [details] [diff] [review]
patch

After applying the patch all message header buttons are now equally tall in the 3 modes, but different in height from the toolbar and QFB. I would rather see them all 24px tall. With this patch the icons starts to feel a bit crammed in.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: patch v2

Set the min-height of 24px for all .toolbarbutton-1.

Comment 4

[Andreas Nilsson (:andreasn)]

Comment on attachment 622474 [details] [diff] [review]
patch v2

diff --git a/mail/themes/qute/mail/messageHeader-aero.css b/mail/themes/qute/mail/messageHeader-aero.css

@@ -259,8 +258,6 @@
   /* important required to override primaryToolbar.css rules */
   -moz-padding-start: 3px !important;
   -moz-padding-end: 3px !important;
-  padding-top: 2px !important;
-  padding-bottom: 2px !important;
 }

I always feel good when we're able to remove !important


r+ me

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/23f217579dee