The default bug view has changed. See this FAQ.

Cleanup MessageHeader button min-height definition

RESOLVED FIXED in Thunderbird 15.0

Status

Thunderbird
Theme
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 15.0
All
Windows 7
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
After landing of bug 741998 the messageheader buttons don't have the same height in text only mode.
(Assignee)

Updated

5 years ago
Blocks: 741998
(Assignee)

Comment 1

5 years ago
Created attachment 621402 [details] [diff] [review]
patch

Fix the min-height
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #621402 - Flags: review?(nisses.mail)
Comment on attachment 621402 [details] [diff] [review]
patch

After applying the patch all message header buttons are now equally tall in the 3 modes, but different in height from the toolbar and QFB. I would rather see them all 24px tall. With this patch the icons starts to feel a bit crammed in.
Attachment #621402 - Flags: review?(nisses.mail) → review-
(Assignee)

Comment 3

5 years ago
Created attachment 622474 [details] [diff] [review]
patch v2

Set the min-height of 24px for all .toolbarbutton-1.
Attachment #621402 - Attachment is obsolete: true
Attachment #622474 - Flags: review?(nisses.mail)
Comment on attachment 622474 [details] [diff] [review]
patch v2

diff --git a/mail/themes/qute/mail/messageHeader-aero.css b/mail/themes/qute/mail/messageHeader-aero.css

@@ -259,8 +258,6 @@
   /* important required to override primaryToolbar.css rules */
   -moz-padding-start: 3px !important;
   -moz-padding-end: 3px !important;
-  padding-top: 2px !important;
-  padding-bottom: 2px !important;
 }

I always feel good when we're able to remove !important


r+ me
Attachment #622474 - Flags: review?(nisses.mail) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/23f217579dee
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 15.0
You need to log in before you can comment on or make changes to this bug.