Lots of Permanent oranges since CPG landed: Test Failure: controller(): Window could not be initialized.

RESOLVED FIXED in Thunderbird 15.0

Status

Thunderbird
Testing Infrastructure
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mconley, Assigned: mconley)

Tracking

({intermittent-failure})

Trunk
Thunderbird 15.0
x86
Windows 7
intermittent-failure
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
Since compartment-per-global landed (bug 650353), some of our Mozmill tests have started to perma-orange with an error stating that:

Test Failure: controller(): Window could not be initialized.

The Mozmill devs themselves got broken by 650353 (see 751424), and they're rapidly working to fix themselves up.

When their patch lands, we'll have to modify our workaround (bug 666438) in _wait_for_generic_load in test-window-helpers.js, but then we should be back in business.  I just tried an early version of the Mozmill patch with a variation on our workaround with positive results.
(Assignee)

Comment 1

5 years ago
Created attachment 621449 [details] [diff] [review]
Fix _wait_for_generic_load to use Mozmill's new controller.windowMap

Henrik says that the Mozmill team is planning on landing their CPG fix in Mozmill 1.5.12 soon, so we're going to have to upgrade.

We'll also need to change our approach to the window workaround we were doing before.  This patch, combined with an early draft of Henrik's work, had good results in test-fixage.
Assignee: nobody → mconley
Attachment #621449 - Flags: review?(mbanner)
(Assignee)

Comment 2

5 years ago
Created attachment 621577 [details] [diff] [review]
Backport of Mozmill patch

Originally merged into the Mozmill 1.5 hotfix branch here:

https://github.com/mozautomation/mozmill/commit/7e8667076c1dc610f6412043cb20e39b330dc30a
Comment on attachment 621449 [details] [diff] [review]
Fix _wait_for_generic_load to use Mozmill's new controller.windowMap

>+++ b/mail/test/mozmill/shared-modules/test-window-helpers.js
>@@ -731,17 +731,20 @@ function _wait_for_generic_load(aDetails
>-  contentWindow.mozmillDocumentLoaded = true;
>+  let windowId = contentWindow.QueryInterface(Ci.nsIInterfaceRequestor)
>+                              .getInterface(Ci.nsIDOMWindowUtils)
>+                              .outerWindowID;
>+  controller.windowMap.update(windowId, "loaded", true);

You should make use of the new utils.getWindowId() method. I have added it to the latest revision of my patch.
(Assignee)

Comment 4

5 years ago
Comment on attachment 621449 [details] [diff] [review]
Fix _wait_for_generic_load to use Mozmill's new controller.windowMap

Mark expressed to me how important it was to get these landed and re-open the tree yesterday, so I've brought them in to comm-central

https://hg.mozilla.org/comm-central/rev/dbfa7c06dbfb

and

https://hg.mozilla.org/comm-central/rev/fda8b20e6b21
Attachment #621449 - Flags: review?(mbanner)
(Assignee)

Comment 5

5 years ago
(In reply to Henrik Skupin (:whimboo) from comment #3)
> Comment on attachment 621449 [details] [diff] [review]
> Fix _wait_for_generic_load to use Mozmill's new controller.windowMap
> 
> >+++ b/mail/test/mozmill/shared-modules/test-window-helpers.js
> >@@ -731,17 +731,20 @@ function _wait_for_generic_load(aDetails
> >-  contentWindow.mozmillDocumentLoaded = true;
> >+  let windowId = contentWindow.QueryInterface(Ci.nsIInterfaceRequestor)
> >+                              .getInterface(Ci.nsIDOMWindowUtils)
> >+                              .outerWindowID;
> >+  controller.windowMap.update(windowId, "loaded", true);
> 
> You should make use of the new utils.getWindowId() method. I have added it
> to the latest revision of my patch.

Thanks Henrik - I'll write a follow-up patch to fix that once we get our tree back open.
(Assignee)

Comment 6

5 years ago
Looks like it worked. No more Window could not be initialized errors on comm-central.

\o/
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 15.0
Keywords: intermittent-failure
Whiteboard: [tb-orange]
You need to log in before you can comment on or make changes to this bug.