752467 - Browser window leaked when changing another browser window's windowtype attribute. (browser_580512.js and browser_589246.js)

Status: NEW

(Firefox :: Session Restore, defect)

Description

[Dão Gottwald [:dao]]

browser_589246.js and browser_580512.js set the host window's windowtype attribute to some random value, do stuff with other windows, and set the windowtype attribute back to navigator:browser. Each of these tests leaks a browser window and I suspect this is due to some code getting confused because the original window suddenly disappears from the set of open windows and later becomes part of it again.

We should either disable the tests or fix this behavior if we want to support it.

Comment 1

[Serge Gautherie (:sgautherie)]

Ftr, SeaMonkey has not ported these 2 tests.

Comment 2

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

(In reply to Dão Gottwald [:dao] from comment #0)
> browser_589246.js and browser_580512.js set the host window's windowtype
> attribute to some random value, do stuff with other windows, and set the
> windowtype attribute back to navigator:browser. Each of these tests leaks a
> browser window and I suspect this is due to some code getting confused
> because the original window suddenly disappears from the set of open windows
> and later becomes part of it again.
> 
> We should either disable the tests or fix this behavior if we want to
> support it.

I'm ok disabling those tests unless a nicer solution can be found. It was a hacky way to trick session restore into thinking there were no browser windows open. Session Restore may even be the source of those leaks.

r=me for disabling.

Comment 3

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/0abed8c2714f