Closed Bug 734554 Opened 12 years ago Closed 12 years ago

Windows and Mac intermittently "ShutdownLeaks | leaked 20 DOMWindow(s) and 2 DocShell(s) until shutdown"

Categories

(Firefox :: Session Restore, defect)

Product:
Firefox
Component:
Session Restore
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox13 --- affected

People

(Reporter: philor, Unassigned)

References

(Depends on 1 open bug)

Details

(Keywords: intermittent-failure) 

https://tbpl.mozilla.org/php/getParsedLog.php?id=9982460&tree=Mozilla-Inbound
Summary: Windows intermittently "ShutdownLeaks | leaked 119 (or 120) DOMWindow(s) and 2 DocShell(s) until shutdown" → Windows intermittently "ShutdownLeaks | leaked 119 (or 120 or 121) DOMWindow(s) and 2 DocShell(s) until shutdown"
I think this is caused by http://hg.mozilla.org/mozilla-central/rev/3dcb40ebd487 which reduced the threshold to 123 leaks per test-run.
(In reply to Tim Taubert [:ttaubert] from comment #13)
> I think this is caused by
> http://hg.mozilla.org/mozilla-central/rev/3dcb40ebd487 which reduced the
> threshold to 123 leaks per test-run.

Why would this trigger the failure when leaking 119 windows and 2 docshells?
Err, the current threshold is in fact 120.
https://tbpl.mozilla.org/php/getParsedLog.php?id=10011465&tree=Mozilla-Inbound
Summary: Windows intermittently "ShutdownLeaks | leaked 119 (or 120 or 121) DOMWindow(s) and 2 DocShell(s) until shutdown" → Windows intermittently "ShutdownLeaks | leaked 119 (or 120 or 121 or 122 or 123) DOMWindow(s) and 2 DocShell(s) until shutdown"
And the downside of crying wolf is that I'll just ignore a regression and keep on starring. I might even be doing it now, dunno.

https://tbpl.mozilla.org/php/getParsedLog.php?id=10012155&tree=Mozilla-Inbound
(In reply to Phil Ringnalda (:philor) from comment #23)
> And the downside of crying wolf is that I'll just ignore a regression and
> keep on starring. I might even be doing it now, dunno.

The downside of a higher threshold would be that we wouldn't even get orange on a regression. If you think you see an increasing volume of failures, please don't ignore it.
http://hg.mozilla.org/mozilla-central/rev/4b9fb42c0d52

This should avoid the "119 DOMWindow(s) and 2 DocShell(s)" failure, which I think was the most frequent one.
https://tbpl.mozilla.org/php/getParsedLog.php?id=10075307&tree=Firefox
leaked 121 DOMWindow(s) and 2 DocShell(s)
https://tbpl.mozilla.org/php/getParsedLog.php?id=10335542&tree=Firefox
leaked 121 DOMWindow(s) and 2 DocShell(s)
https://tbpl.mozilla.org/php/getParsedLog.php?id=10359962&tree=Firefox
leaked 121 DOMWindow(s) and 2 DocShell(s)
When I clicked "analyze the leak" on TBPL entry for comment 57, it said:
> chrome://mochitests/content/chrome/dom/ipc/tests/test_process_error.xul leaked 1 DOMWINDOW(s)
Not sure if that's relevant...
Only to bug 726514.
https://tbpl.mozilla.org/php/getParsedLog.php?id=11092410&tree=Firefox
leaked 121 DOMWindow(s) and 2 DocShell(s)
https://tbpl.mozilla.org/php/getParsedLog.php?id=11102023&tree=Firefox
leaked 121 DOMWindow(s) and 2 DocShell(s)
https://tbpl.mozilla.org/php/getParsedLog.php?id=11116325&tree=Mozilla-Inbound
TEST-UNEXPECTED-FAIL | ShutdownLeaks | leaked 121 DOMWindow(s) and 2 DocShell(s) until shutdown

https://tbpl.mozilla.org/php/getParsedLog.php?id=11119645&tree=Mozilla-Inbound
TEST-UNEXPECTED-FAIL | ShutdownLeaks | leaked 121 DOMWindow(s) and 2 DocShell(s) until shutdown 

https://tbpl.mozilla.org/php/getParsedLog.php?id=11119299&tree=Mozilla-Inbound
TEST-UNEXPECTED-FAIL | ShutdownLeaks | leaked 121 DOMWindow(s) and 2 DocShell(s) until shutdown

https://tbpl.mozilla.org/php/getParsedLog.php?id=11122185&tree=Mozilla-Inbound
TEST-UNEXPECTED-FAIL | ShutdownLeaks | leaked 121 DOMWindow(s) and 2 DocShell(s) until shutdown 

https://tbpl.mozilla.org/php/getParsedLog.php?id=11119697&tree=Mozilla-Inbound
TEST-UNEXPECTED-FAIL | ShutdownLeaks | leaked 121 DOMWindow(s) and 2 DocShell(s) until shutdown
And given that several of those aren't even Windows, someone's landed bustage.
(In reply to Phil Ringnalda (:philor) from comment #71)
> And given that several of those aren't even Windows, someone's landed
> bustage.

Thanks for the notice. Do you already have a regression range, even if a large one?
There are new persistent leaks, apparently all from browser/devtools/layoutview/test/browser_layoutview.js (bug 683954).
Depends on: 747919
(In reply to Phil Ringnalda (:philor) from comment #71)
> And given that several of those aren't even Windows, someone's landed
> bustage.

Whoops missed Windows in bug summary, my bad.
https://tbpl.mozilla.org/php/getParsedLog.php?id=11265687&tree=Firefox
Summary: Windows intermittently "ShutdownLeaks | leaked 119 (or 120 or 121 or 122 or 123) DOMWindow(s) and 2 DocShell(s) until shutdown" → Windows intermittently "ShutdownLeaks | leaked 23 DOMWindow(s) and 2 DocShell(s) until shutdown"
The test intermittently leaking appears to be browser/components/sessionstore/test/browser_461634.js
Blocks: bc-leaks
Component: BrowserTest → Session Restore
Product: Testing → Firefox
QA Contact: browsertest → session.restore
[browser/components/sessionstore/test/browser_461634.js]
  1 window(s) [url = chrome://browser/content/browser.xul]
  1 window(s) [url = about:blank]
TEST-UNEXPECTED-FAIL | ShutdownLeaks | leaked 22 DOMWindow(s) and 2 DocShell(s) until shutdown

Rev3 MacOSX Leopard 10.5.8 mozilla-inbound debug test mochitest-other on 2012-04-27 02:03:10 PDT for push eb4b76b2840f

slave: talos-r3-leopard-011

https://tbpl.mozilla.org/php/getParsedLog.php?id=11260585&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=11277508&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=11280689&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=11282163&tree=Mozilla-Inbound
Summary: Windows intermittently "ShutdownLeaks | leaked 23 DOMWindow(s) and 2 DocShell(s) until shutdown" → Windows and Mac intermittently "ShutdownLeaks | leaked 23 (or 22) DOMWindow(s) and 2 DocShell(s) until shutdown"
https://tbpl.mozilla.org/php/getParsedLog.php?id=11294197&tree=Firefox

WinXP at 25 DOMWindow(s) and 2 DocShell(s) from browser_bug435788.js having 3 about:blank and 3 pluginInstallerWizard.xul rather than the usual 1 and 1, plus an intermittent 1 from browser_461634.js.
https://tbpl.mozilla.org/php/getParsedLog.php?id=11498023&tree=Mozilla-Inbound
Summary: Windows and Mac intermittently "ShutdownLeaks | leaked 23 (or 22) DOMWindow(s) and 2 DocShell(s) until shutdown" → Windows and Mac intermittently "ShutdownLeaks | leaked 20, 22, or 23 DOMWindow(s) and 2 DocShell(s) until shutdown"
Summary: Windows and Mac intermittently "ShutdownLeaks | leaked 20, 22, or 23 DOMWindow(s) and 2 DocShell(s) until shutdown" → Windows and Mac intermittently "ShutdownLeaks | leaked 20 DOMWindow(s) and 2 DocShell(s) until shutdown"
Status: NEW → RESOLVED
Closed: 12 years ago
Depends on: 752467, 751086
Resolution: --- → FIXED
Whiteboard: [orange]
You need to log in before you can comment on or make changes to this bug.