Ergonomics improvements for HashTable::rekeyFront

RESOLVED FIXED in mozilla15

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: terrence, Assigned: terrence)

Tracking

Trunk
mozilla15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 621675 [details] [diff] [review]
v0

This makes rekeyFront take a const ref and check for the unchanged case.  This allows us to unconditionally pass a newly constructed temporary into it.  This saves us a few lines and a level of indentation basically everywhere we need to use rekeyFront.  Granted, this is only a handful of places, but this still seems to be the cleaner option.
Attachment #621675 - Flags: review?(luke)

Updated

5 years ago
Attachment #621675 - Flags: review?(luke) → review+
(Assignee)

Comment 1

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/7b11e6c758c8

Comment 2

5 years ago
https://hg.mozilla.org/mozilla-central/rev/7b11e6c758c8
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.