Closed Bug 752776 Opened 13 years ago Closed 13 years ago

Upgrade pywebsocket to v631

Categories

(Core :: Networking: WebSockets, defect)

Product:
Core
Component:
Networking: WebSockets
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla14

People

(Reporter: jduell.mcbugs, Assigned: jduell.mcbugs)

References

Details

Attachments

(2 files, 2 obsolete files)

pywebsocket, v631
50.58 KB, patch
mcmanus
: review+
akeybl
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Mozilla-specific tweaks to pywebsocket v631
2.90 KB, patch
mcmanus
: review+
akeybl
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Attached patch diff of pywebsocket v606->v630. (obsolete) — — Splinter Review
This mainly gets us the newer close code definitions in the spec. First attachment is just a straight diff of the canonical pywebsocket repo v606->v630, so nothing really to review.
Attachment #621840 - Flags: review?(mcmanus)
The usual HSTS patch.
Assignee: nobody → jduell.mcbugs
Status: NEW → ASSIGNED
Attachment #621841 - Flags: review?(mcmanus)
Comment on attachment 621840 [details] [diff] [review] diff of pywebsocket v606->v630. this is a rubberstamp
Attachment #621840 - Flags: review?(mcmanus) → review+
Comment on attachment 621841 [details] [diff] [review] Mozilla-specific tweaks to pywebsocket Review of attachment 621841 [details] [diff] [review]: ----------------------------------------------------------------- ::: testing/mochitest/pywebsocket/README-MOZILLA @@ +43,3 @@ > $OBJDIR/_tests/testing/mochitest/websock.log > > - Upgrade the svnversion number at top of this file to whatever version we're why?
Attachment #621841 - Flags: review?(mcmanus) → review+
> Upgrade the svnversion number Oh, just because the version # isn't in the pywebsocket code anywhere. We could always figure it out with hg + bugzilla archeology. Seemed simpler to just store it in the README.
pywebsocket 631, which contains my fixes for empty close frames. Patrick: just needs rubberstamp as usual.
Attachment #621840 - Attachment is obsolete: true
Attachment #623789 - Flags: review?(mcmanus)
Attachment #621841 - Attachment is obsolete: true
Attachment #623790 - Flags: review?(mcmanus)
Summary: Upgrade pywebsocket to v630 → Upgrade pywebsocket to v631
Attachment #623790 - Flags: review?(mcmanus) → review+
Comment on attachment 623789 [details] [diff] [review] pywebsocket, v631 this is a rubberstamp. glad to hear code got upstream!
Attachment #623789 - Flags: review?(mcmanus) → review+
https://hg.mozilla.org/mozilla-central/rev/6aa80954981c https://hg.mozilla.org/mozilla-central/rev/deb1fd74e10b
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
Blocks: 748580
Comment on attachment 623789 [details] [diff] [review] pywebsocket, v631 Test infrastructure-only change to support landing bug 748580 on aurora
Attachment #623789 - Flags: approval-mozilla-aurora?
Comment on attachment 623790 [details] [diff] [review] Mozilla-specific tweaks to pywebsocket v631 [Approval Request Comment] Bug caused by (feature/regressing bug #): User impact if declined: Testing completed (on m-c, etc.): Risk to taking this patch (and alternatives if risky): String or UUID changes made by this patch:
Attachment #623790 - Flags: approval-mozilla-aurora?
Attachment #623789 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #623790 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Target Milestone: mozilla15 → mozilla14
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: