Last Comment Bug 752776 - Upgrade pywebsocket to v631
: Upgrade pywebsocket to v631
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Networking: WebSockets (show other bugs)
: unspecified
: x86_64 Linux
: -- normal (vote)
: mozilla14
Assigned To: Jason Duell [:jduell] (needinfo? me)
:
Mentors:
: 752778 (view as bug list)
Depends on:
Blocks: 748580
  Show dependency treegraph
 
Reported: 2012-05-07 18:51 PDT by Jason Duell [:jduell] (needinfo? me)
Modified: 2012-05-21 19:54 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
diff of pywebsocket v606->v630. (44.01 KB, patch)
2012-05-07 18:51 PDT, Jason Duell [:jduell] (needinfo? me)
mcmanus: review+
Details | Diff | Review
Mozilla-specific tweaks to pywebsocket (6.00 KB, patch)
2012-05-07 18:53 PDT, Jason Duell [:jduell] (needinfo? me)
mcmanus: review+
Details | Diff | Review
pywebsocket, v631 (50.58 KB, patch)
2012-05-14 13:10 PDT, Jason Duell [:jduell] (needinfo? me)
mcmanus: review+
akeybl: approval‑mozilla‑aurora+
Details | Diff | Review
Mozilla-specific tweaks to pywebsocket v631 (2.90 KB, patch)
2012-05-14 13:11 PDT, Jason Duell [:jduell] (needinfo? me)
mcmanus: review+
akeybl: approval‑mozilla‑aurora+
Details | Diff | Review

Description Jason Duell [:jduell] (needinfo? me) 2012-05-07 18:51:29 PDT
Created attachment 621840 [details] [diff] [review]
diff of pywebsocket v606->v630.

This mainly gets us the newer close code definitions in the spec.

First attachment is just a straight diff of the canonical pywebsocket repo v606->v630, so nothing really to review.
Comment 1 Jason Duell [:jduell] (needinfo? me) 2012-05-07 18:53:10 PDT
Created attachment 621841 [details] [diff] [review]
Mozilla-specific tweaks to pywebsocket

The usual HSTS patch.
Comment 2 Patrick McManus [:mcmanus] 2012-05-08 05:53:27 PDT
Comment on attachment 621840 [details] [diff] [review]
diff of pywebsocket v606->v630.

this is a rubberstamp
Comment 3 Patrick McManus [:mcmanus] 2012-05-08 05:58:15 PDT
Comment on attachment 621841 [details] [diff] [review]
Mozilla-specific tweaks to pywebsocket

Review of attachment 621841 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/mochitest/pywebsocket/README-MOZILLA
@@ +43,3 @@
>    $OBJDIR/_tests/testing/mochitest/websock.log
>  
>  - Upgrade the svnversion number at top of this file to whatever version we're

why?
Comment 4 Jason Duell [:jduell] (needinfo? me) 2012-05-08 16:32:53 PDT
> Upgrade the svnversion number

Oh, just because the version # isn't in the pywebsocket code anywhere.  We could always figure it out with hg + bugzilla archeology.  Seemed simpler to just store it in the README.
Comment 5 Jason Duell [:jduell] (needinfo? me) 2012-05-14 13:10:04 PDT
*** Bug 752778 has been marked as a duplicate of this bug. ***
Comment 6 Jason Duell [:jduell] (needinfo? me) 2012-05-14 13:10:49 PDT
Created attachment 623789 [details] [diff] [review]
pywebsocket, v631

pywebsocket 631, which contains my fixes for empty close frames.

Patrick: just needs rubberstamp as usual.
Comment 7 Jason Duell [:jduell] (needinfo? me) 2012-05-14 13:11:20 PDT
Created attachment 623790 [details] [diff] [review]
Mozilla-specific tweaks to pywebsocket v631
Comment 8 Patrick McManus [:mcmanus] 2012-05-16 08:23:36 PDT
Comment on attachment 623789 [details] [diff] [review]
pywebsocket, v631

this is a rubberstamp. glad to hear code got upstream!
Comment 11 Jason Duell [:jduell] (needinfo? me) 2012-05-18 21:21:42 PDT
Comment on attachment 623789 [details] [diff] [review]
pywebsocket, v631

Test infrastructure-only change to support landing bug 748580 on aurora
Comment 12 Jason Duell [:jduell] (needinfo? me) 2012-05-18 21:21:49 PDT
Comment on attachment 623790 [details] [diff] [review]
Mozilla-specific tweaks to pywebsocket v631

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): 
String or UUID changes made by this patch:

Note You need to log in before you can comment on or make changes to this bug.