UI tweaks for the property view

RESOLVED FIXED in Firefox 15

Status

()

Firefox
Developer Tools: Debugger
P2
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: vporof, Assigned: vporof)

Tracking

12 Branch
Firefox 15
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 attachment, 5 obsolete attachments)

(Assignee)

Description

5 years ago
It's bad to assume someone is interested in EVERYTHING that's shown in the property view. For example, we probably never really need to look at __proto__, but now it's the first element shown and it even has the same colors.

Let's reduce visual clutter, by playing with ordering and css a bit.
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

5 years ago
Also, we're displaying [object Constructor] for everything except primitives (or strings and null). Again, clutter. I think the Constructor information is more than enough.
(Assignee)

Comment 2

5 years ago
We should also have nicer property name displays for Arguments, Array and Object types, like Firebug does. Followup bug for this.
(Assignee)

Updated

5 years ago
Priority: -- → P2
(Assignee)

Updated

5 years ago
Depends on: 753332
(Assignee)

Comment 3

5 years ago
Filed bug 753332 addressing comment #1 and #2.
(Assignee)

Updated

5 years ago
Blocks: 753332
No longer depends on: 753332
(Assignee)

Updated

5 years ago
Depends on: 753651
(Assignee)

Updated

5 years ago
Depends on: 753313
No longer depends on: 753651
(Assignee)

Comment 4

5 years ago
Created attachment 622800 [details] [diff] [review]
v1

Also fixed some bad indents in DVF_updateState from the debugger xulification.
Attachment #622800 - Flags: review?(rcampbell)
(Assignee)

Comment 5

5 years ago
Created attachment 622824 [details] [diff] [review]
v1

Had to rebase, since bug 753313 is trending right now.
Attachment #622800 - Attachment is obsolete: true
Attachment #622800 - Flags: review?(rcampbell)
Attachment #622824 - Flags: review?(rcampbell)
(Assignee)

Comment 6

5 years ago
Somewhat dependent on bug 752770. Please postpone review until that settles.
Comment on attachment 622824 [details] [diff] [review]
v1

+      aCallback && aCallback(prop, value);

are we doing this now? I guess that's ok.
I'd like to try this out, I would. But the patch depth is too deep.
(Assignee)

Updated

5 years ago
No longer blocks: 753332
No longer depends on: 753313
(Assignee)

Updated

5 years ago
Blocks: 753332
Depends on: 753313
(Assignee)

Comment 9

5 years ago
Created attachment 625517 [details] [diff] [review]
v1.1

Rebased.
Attachment #622824 - Attachment is obsolete: true
Attachment #622824 - Flags: review?(rcampbell)
Attachment #625517 - Flags: review?(rcampbell)
(Assignee)

Comment 10

5 years ago
Created attachment 627727 [details] [diff] [review]
v2

Rebased.
Attachment #625517 - Attachment is obsolete: true
Attachment #625517 - Flags: review?(rcampbell)
Attachment #627727 - Flags: review?(rcampbell)
(Assignee)

Comment 11

5 years ago
Created attachment 627728 [details] [diff] [review]
v2

Achievement unlocked: forgot to qref.
Attachment #627727 - Attachment is obsolete: true
Attachment #627727 - Flags: review?(rcampbell)
Attachment #627728 - Flags: review?(rcampbell)
(Assignee)

Updated

5 years ago
Blocks: 759135
(Assignee)

Comment 12

5 years ago
Created attachment 627935 [details] [diff] [review]
v3

Bug 755346 generated a lot of fuzz, qrefreshed.
Comment on attachment 627935 [details] [diff] [review]
v3

ok. Let me try this.
Attachment #627728 - Flags: review?(rcampbell)
Attachment #627728 - Attachment is obsolete: true
Comment on attachment 627935 [details] [diff] [review]
v3

Review of attachment 627935 [details] [diff] [review]:
-----------------------------------------------------------------

Got a call from the Homeowners Association that I should help the homeless, so I'm stealing this.

Looks good.
Attachment #627935 - Flags: review+
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/71f26fd0bdc5
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/71f26fd0bdc5
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 15
You need to log in before you can comment on or make changes to this bug.