4.59 KB, image/png
12.50 KB, patch
|Details | Diff | Splinter Review|
per Roc: I think we might also be able to replace the SVG mask with an SVG clip-path. clip-path should be significantly more efficient since it doesn't require per-pixel luminance calculations.
Comment on attachment 621984 [details] [diff] [review] Patch converts SVG masks to clipPath elements. Need profiling. I don't know anything about our theme stuff, Dao should be the person looking at this.
Attachment #621984 - Flags: feedback?(ehsan) → feedback?(dao)
Attachment #621984 - Flags: feedback?(roc) → feedback+
Comment on attachment 621984 [details] [diff] [review] Patch converts SVG masks to clipPath elements. Need profiling. You need to update browser/themes/winstripe/browser.css too. nit: please replace "-mask" with "-clipPath" in the SVG node ids.
Component: Tabbed Browser → Theme
QA Contact: tabbed.browser → theme
Addresses feedback comments. Need a final r+ prior to landing.
Summary: tab UI shouldn't use expensive SVG masks → Convert expensive SVG masks to clip-paths
This patch includes clip-paths that very precisely follow the outlines of the original mask shapes they replace. This should resolve any compositing bleed issues.
This patch simplifies the paths, reduces precision for less verbose SVG markup. Note: this SVG is generated by the Inkscape SVG editor.
Comment on attachment 623098 [details] [diff] [review] This patch reduces precision for less verbose SVG code. Thanks!
Attachment #623098 - Flags: review?(dao) → review+
Target Milestone: --- → Firefox 15
Version: unspecified → Trunk
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
It looks like this caused a 2% regression in the Talos SVG benchmark, at least on Mac OS X 10.6: http://graphs.mozilla.org/graph.html#tests=[[22,63,21]]&sel=1336616135166,1337220935166 Should it be backed out?
I don't believe that's possible :-)
You need to log in before you can comment on or make changes to this bug.