Closed
Bug 752918
Opened 13 years ago
Closed 13 years ago
Convert expensive SVG masks to clip-paths
Categories
(Firefox :: Theme, defect)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
Firefox 15
People
(Reporter: bugs, Assigned: bugs)
References
(Blocks 1 open bug)
Details
(Keywords: perf, Whiteboard: [Snappy])
Attachments
(2 files, 3 obsolete files)
4.59 KB,
image/png
|
Details | |
12.50 KB,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
per Roc: I think we might also be able to replace the SVG mask with an SVG clip-path. clip-path should be significantly more efficient since it doesn't require per-pixel luminance calculations.
Attachment #621984 -
Flags: feedback?(roc)
Attachment #621984 -
Flags: feedback?(ehsan)
Comment 1•13 years ago
|
||
Comment on attachment 621984 [details] [diff] [review]
Patch converts SVG masks to clipPath elements. Need profiling.
I don't know anything about our theme stuff, Dao should be the person looking at this.
Attachment #621984 -
Flags: feedback?(ehsan) → feedback?(dao)
Attachment #621984 -
Flags: feedback?(roc) → feedback+
Comment 2•13 years ago
|
||
Comment on attachment 621984 [details] [diff] [review]
Patch converts SVG masks to clipPath elements. Need profiling.
You need to update browser/themes/winstripe/browser.css too.
nit: please replace "-mask" with "-clipPath" in the SVG node ids.
Updated•13 years ago
|
Component: Tabbed Browser → Theme
QA Contact: tabbed.browser → theme
Updated•13 years ago
|
Attachment #621984 -
Flags: feedback?(dao)
Assignee | ||
Comment 3•13 years ago
|
||
Addresses feedback comments. Need a final r+ prior to landing.
Assignee: nobody → jet
Attachment #621984 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #622694 -
Flags: review?(dao)
Updated•13 years ago
|
Summary: tab UI shouldn't use expensive SVG masks → Convert expensive SVG masks to clip-paths
Comment 4•13 years ago
|
||
Note the pixels bleeding through behind the back button especially at the bottom. It looks like the clip path is misaligned or doesn't quite have the right shape.
Assignee | ||
Comment 5•13 years ago
|
||
This patch includes clip-paths that very precisely follow the outlines of the original mask shapes they replace. This should resolve any compositing bleed issues.
Attachment #622694 -
Attachment is obsolete: true
Attachment #622694 -
Flags: review?(dao)
Attachment #623087 -
Flags: review?(dao)
Assignee | ||
Comment 6•13 years ago
|
||
This patch simplifies the paths, reduces precision for less verbose SVG markup. Note: this SVG is generated by the Inkscape SVG editor.
Attachment #623087 -
Attachment is obsolete: true
Attachment #623087 -
Flags: review?(dao)
Attachment #623098 -
Flags: review?(dao)
Comment 7•13 years ago
|
||
Comment on attachment 623098 [details] [diff] [review]
This patch reduces precision for less verbose SVG code.
Thanks!
Attachment #623098 -
Flags: review?(dao) → review+
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Comment 8•13 years ago
|
||
Comment 9•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 10•13 years ago
|
||
It looks like this caused a 2% regression in the Talos SVG benchmark, at least on Mac OS X 10.6:
http://graphs.mozilla.org/graph.html#tests=[[22,63,21]]&sel=1336616135166,1337220935166
Should it be backed out?
I don't believe that's possible :-)
Updated•12 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•