Closed Bug 753135 Opened 8 years ago Closed 8 years ago

Add AddressSanitizer mozconfig files to the tree

Categories

(Firefox Build System :: General, defect)

All
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla15

People

(Reporter: decoder, Assigned: decoder)

References

Details

(Keywords: sec-want, Whiteboard: [sg:want][asan-build-blocker])

Attachments

(1 file, 1 obsolete file)

Attached patch Patch (obsolete) — Splinter Review
In order to be able to request Firefox builds with AddressSanitizer support from RelEng, the configuration files need to be added to the tree. The attached patch adds a base configuration in build/unix/mozconfig.asan that can later also be reused for Mac OSX. Furthermore it adds four build specific configs:

browser/config/mozconfigs/linux32/debug-asan
browser/config/mozconfigs/linux64/debug-asan
browser/config/mozconfigs/linux32/nightly-asan
browser/config/mozconfigs/linux64/nightly-asan
Attachment #622160 - Flags: review?(catlee)
Comment on attachment 622160 [details] [diff] [review]
Patch

Review of attachment 622160 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/unix/mozconfig.asan
@@ +1,3 @@
> +# Use Clang r155417
> +export CC="/tools/clang-3.0-r155417.moz0/bin/clang -fgnu89-inline"
> +export CXX="/tools/clang-3.0-r155417.moz0/bin/clang++"

my only concern is with these lines here. they'll have to change every time we bump the clang version that's installed. Set these to /tools/clang-3.0 and we'll be good to go once bug 753969 is done.
Attachment #622160 - Flags: review?(catlee) → review+
Updated patch with Clang symlink as requested. Carrying r+ from last review. I'd like to land this as soon as the name of the symlink "/tools/clang-3.0" is fixed, even if it does not yet exist. The reason is that others who want to create try builds now, can use these configs easily by substituting the paths and copying the config over the regular linux build configs. I'd also like to point to these configs in the MDN article to make it easier.
Assignee: nobody → choller
Attachment #622160 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #623161 - Flags: review+
Depends on: 753969
Comment on attachment 623161 [details] [diff] [review]
Updated patch to use Clang symlink

Landing this now and will change it later if the symlink turns out to be wrong :)
Attachment #623161 - Flags: checkin?(gary)
Attachment #623161 - Flags: checkin?(gary) → checkin+
https://hg.mozilla.org/mozilla-central/rev/0ad870ffec61
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Anyone know why the Asan builds have -disable-crashreporter?
(In reply to Armen Zambrano [:armenzg] (EDT/UTC-4) from comment #6)
> Anyone know why the Asan builds have -disable-crashreporter?

Crash reporter uses signal handlers that collide with ASan's signal handler. Also, using a crash reporter simply makes no sense when you use ASan, except if our crash reporter was able to deal with the way ASan reports failures.
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.