Unnecessary fields added in bug 746633

RESOLVED FIXED in Firefox 14

Status

()

Firefox for Android
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: kats, Assigned: snorp)

Tracking

unspecified
Firefox 15
All
Android
Points:
---

Firefox Tracking Flags

(firefox14 fixed, firefox15 fixed)

Details

Attachments

(1 attachment)

The patch at https://bug746633.bugzilla.mozilla.org/attachment.cgi?id=621178 introduces a new screenSize and mSurfaceWidth/mSurfaceHeight fields, which I believe are redundant. The viewport width and height (as obtained by viewport.width() and viewport.height()) should be identical to these values, as they will always be the screen width/height in device pixels.

The extra fields added should be removed, or if in fact there is some reason they are needed, they should be commented as such.
Created attachment 626545 [details] [diff] [review]
Remove unnecessary fields in RenderContext
Attachment #626545 - Flags: review?(bugmail.mozilla)
Comment on attachment 626545 [details] [diff] [review]
Remove unnecessary fields in RenderContext

Review of attachment 626545 [details] [diff] [review]:
-----------------------------------------------------------------

A very enthusiastic r+ from me :)
Attachment #626545 - Flags: review?(bugmail.mozilla) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/2c51ac146815
https://hg.mozilla.org/mozilla-central/rev/2c51ac146815
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 15
status-firefox14: --- → affected
status-firefox15: --- → fixed
Comment on attachment 626545 [details] [diff] [review]
Remove unnecessary fields in RenderContext

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: none
Testing completed (on m-c, etc.): on m-c for a while
Risk to taking this patch (and alternatives if risky): need this patch in order for the patches from bug 758635 to apply properly. (this patch also currently doesn't apply cleanly on beta but the rebase seems straightforward enough)
String or UUID changes made by this patch: none
Attachment #626545 - Flags: approval-mozilla-beta?
Comment on attachment 626545 [details] [diff] [review]
Remove unnecessary fields in RenderContext

[Triage Comment]
As in bug 758635, please go ahead and land this to mozilla-beta tip only.
Attachment #626545 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Landed on default branch of mozilla-beta:

https://hg.mozilla.org/releases/mozilla-beta/rev/6333f82c041e
status-firefox14: affected → fixed
You need to log in before you can comment on or make changes to this bug.