kumascript: Use conditional GET in requests for Kuma documents

VERIFIED FIXED

Status

VERIFIED FIXED
7 years ago
6 years ago

People

(Reporter: lorchard, Assigned: lorchard)

Tracking

Details

(Whiteboard: u=contributor c=wiki s=2012-06-05 p=2 t=2012-06-05)

(Assignee)

Description

7 years ago
After bug 753483 is done, start using conditional GET for requests to Kuma. That is: Cache Kuma response bodies along with Last-Modified / Etag. Send If-Modified-Since and If-None-Match headers with subsequent requests.

If a 304 Not Modified response happens, use cached Kuma doc source for templates and documents. 

Additionally, KumaScript could choose to just skip the Kuma request altogether if there's a cached response not older than whatever the current Cache-Control: max-age directive specifies.
(Assignee)

Updated

7 years ago
Depends on: 753483
(Assignee)

Updated

7 years ago
Whiteboard: u=contributor c=wiki
(Assignee)

Comment 1

7 years ago
Progress, close to a PR, semi-blocked by bug 740093
Whiteboard: u=contributor c=wiki → u=contributor c=wiki s=2012-06-05 p=2
(Assignee)

Updated

7 years ago
Assignee: nobody → lorchard
(Assignee)

Comment 2

7 years ago
Crud. So, I *meant* to submit a PR for this, but instead I just merged it along with the other code I meant to help address 740093:

https://github.com/mozilla/kumascript/commit/2d377e61d01eb8ea2af64e386bbfefe90836215e
(Assignee)

Comment 3

7 years ago
By mistake, this is already merged... :/ if anybody objects, go ahead and reopen.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Whiteboard: u=contributor c=wiki s=2012-06-05 p=2 → u=contributor c=wiki s=2012-06-05 p=2 t=2012-06-05
Status: RESOLVED → VERIFIED
Version: Kuma → unspecified
Component: Docs Platform → Editing
Product: Mozilla Developer Network → Mozilla Developer Network
You need to log in before you can comment on or make changes to this bug.