Closed
Bug 747151
Opened 13 years ago
Closed 12 years ago
Improve caching for kumascript -> kuma requests
Categories
(developer.mozilla.org Graveyard :: KumaScript, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: lorchard, Assigned: lorchard)
References
Details
Caching for requests from kumascript to kuma has suddenly become much more important.
Many pages will auto-require around 10 other templates, and for a page that requires lots of templates... that's a lot of HTTP requests.
Updated•13 years ago
|
Whiteboard: u=contributor c=wiki s=2012-05-08 p=2
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → lorchard
Updated•13 years ago
|
Whiteboard: u=contributor c=wiki s=2012-05-08 p=2 → u=contributor c=wiki s=2012-05-22 p=2
Assignee | ||
Updated•13 years ago
|
Whiteboard: u=contributor c=wiki s=2012-05-22 p=2 → u=contributor c=wiki
Assignee | ||
Comment 1•13 years ago
|
||
Looks like a partial fix for this has been done on the KumaScript side:
https://github.com/mozilla/kumascript/commit/f05d343b04005d2bb9e688ca7d72130535e380c6
There's no conditional GET, but kumascript template loaders do cache kuma source in memcache. But, there's also no cache invalidation when the kuma source changes, unless a force-refresh is done.
So, some conditional GET will help invalidation. Along with that, KumaScript could "cheat" by spying on Kuma's entries in memcache. Those can give access to the last-modified timestamps of Kuma documents once bug 753483 starts stashing those.
Updated•13 years ago
|
Assignee | ||
Comment 2•13 years ago
|
||
I think this is mostly improved:
https://github.com/mozilla/kumascript/commit/2d377e61d01eb8ea2af64e386bbfefe90836215e
Going to call this done, at least with respect to July launch. There is lots of caching, and it can always be improved. But, it's probably good enough for now.
Updated•12 years ago
|
Version: Kuma → unspecified
Updated•12 years ago
|
Component: Docs Platform → Editing
Comment 3•12 years ago
|
||
Closing as per comment 2. We can open different bugs for further improvements.
Status: NEW → RESOLVED
Closed: 12 years ago
Component: Editing → KumaScript
Resolution: --- → FIXED
Summary: kumascript: Improve caching for kumascript -> kuma requests → Improve caching for kumascript -> kuma requests
Whiteboard: u=contributor c=wiki
Updated•5 years ago
|
Product: developer.mozilla.org → developer.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•