The default bug view has changed. See this FAQ.

Visually distinguish between configurable, enumerable and writable properties

RESOLVED FIXED in Firefox 15

Status

()

Firefox
Developer Tools: Debugger
P3
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: vporof, Assigned: vporof)

Tracking

12 Branch
Firefox 15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(3 attachments, 1 obsolete attachment)

(Assignee)

Description

5 years ago
A few visual metaphors for these properties may be nice.
(Assignee)

Comment 1

5 years ago
The "enumerable" part of this bug is mostly taken care of in bug 752834.
(Assignee)

Updated

5 years ago
Priority: -- → P3
(Assignee)

Comment 2

5 years ago
We'll just need a lock icon for the unwritable properties.
(Assignee)

Updated

5 years ago
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Frozen objects should be identified as well:

https://mail.mozilla.org/pipermail/es-discuss/2012-May/022991.html

As a matter of fact, why not indicate all object extensibility characteristics? I imagine a single character at the right side of the object value, with a "float: right" alignment, that reads either F(rozen), S(ealed) or N(on-extensible).
(Assignee)

Updated

5 years ago
Depends on: 759135
(Assignee)

Comment 4

5 years ago
Created attachment 628321 [details] [diff] [review]
v1
Attachment #628321 - Flags: review?(past)
(Assignee)

Comment 5

5 years ago
(In reply to Panos Astithas [:past] from comment #3)
> Frozen objects should be identified as well:
> 
> https://mail.mozilla.org/pipermail/es-discuss/2012-May/022991.html
> 
> As a matter of fact, why not indicate all object extensibility
> characteristics? I imagine a single character at the right side of the
> object value, with a "float: right" alignment, that reads either F(rozen),
> S(ealed) or N(on-extensible).

How about a followup for this?
(In reply to Victor Porof from comment #5)
> (In reply to Panos Astithas [:past] from comment #3)
> > Frozen objects should be identified as well:
> > 
> > https://mail.mozilla.org/pipermail/es-discuss/2012-May/022991.html
> > 
> > As a matter of fact, why not indicate all object extensibility
> > characteristics? I imagine a single character at the right side of the
> > object value, with a "float: right" alignment, that reads either F(rozen),
> > S(ealed) or N(on-extensible).
> 
> How about a followup for this?

I'm fine with that.
(Assignee)

Comment 7

5 years ago
Created attachment 628360 [details] [diff] [review]
v1-2

Part 2: make the variables obey these same rules as properties (I didn't think we need another bug for this).
Attachment #628360 - Flags: review?(past)
Comment on attachment 628321 [details] [diff] [review]
v1

Review of attachment 628321 [details] [diff] [review]:
-----------------------------------------------------------------

I very much like the decorations, but they are not terribly intuitive. Can't we add tooltips or something?
Attachment #628321 - Flags: review?(past) → review+
Attachment #628360 - Flags: review?(past) → review+
(Assignee)

Comment 9

5 years ago
(In reply to Panos Astithas [:past] from comment #8)
> Comment on attachment 628321 [details] [diff] [review]
> v1
> 
> Review of attachment 628321 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I very much like the decorations, but they are not terribly intuitive. Can't
> we add tooltips or something?

Indeed. I was hoping that this will be just temporary, and shorlander will think of something awesome as always.
(Assignee)

Comment 10

5 years ago
Created attachment 628612 [details] [diff] [review]
v1-2-fix

Added tooltips copied CSS bits to gnomestripe and pinstripe as well.
I like the tooltips! One thing I noticed though, after playing with the patch some more, is that the dotted underline beneath non-writable and non-configurable properties is barely visible next to the dotted separator between properties. Perhaps using a dashed underline will make it more prominent, and also emphasize the color difference between noon-writable and non-configurable properties (due to the extra colored pixels), which is now too subtle.
Whiteboard: [land-in-fx-team]
I could not apply this. Needs a little rebase.
Whiteboard: [land-in-fx-team] → [needs-rebase]
(Assignee)

Comment 13

5 years ago
There are two patches in this bug:
v1: which is part1
v1-2-fix: which is part2 with nits addressed from panos.

I'll address comment 11 and reupload a single patch :)
(Assignee)

Comment 14

5 years ago
Created attachment 629206 [details] [diff] [review]
v-fold

Addressed comments and qfolded. Land me.
Attachment #628612 - Attachment is obsolete: true
https://hg.mozilla.org/integration/fx-team/rev/1bc2c4e1493b
Whiteboard: [needs-rebase] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/1bc2c4e1493b
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 15
You need to log in before you can comment on or make changes to this bug.