Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Broken appearance of IM system messages

RESOLVED FIXED in Thunderbird 15.0

Status

Thunderbird
Mail Window Front End
--
enhancement
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: florian, Assigned: florian)

Tracking

({regression})

Trunk
Thunderbird 15.0
regression

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

5 years ago
Created attachment 622723 [details] [diff] [review]
Patch

+++ This bug was initially created as a clone of Bug #747415 +++

Bug 747415 regressed the appearance of IM conversations by messing up the style rules for the first system message (receiving the "event" class on a div node that also has the class "bubble", and the consecutive system messages (receiving the "event" class on a p node).

The attached patch reverts the 2 changes that caused the regression, and while I was looking in that file, I also optimized two other expensive selectors.
Attachment #622723 - Flags: review?(bwinton)
(Assignee)

Comment 1

5 years ago
Created attachment 622726 [details]
Screenshot of the bug
(Assignee)

Comment 2

5 years ago
Created attachment 622727 [details]
Screenshot with the patch applied
(Assignee)

Comment 3

5 years ago
Comment on attachment 622723 [details] [diff] [review]
Patch

>diff --git a/mail/components/im/messages/main.css b/mail/components/im/messages/main.css

>+.bubble > .indicator > hr {

".bubble > " may not be strictly necessary on that line.
Comment on attachment 622723 [details] [diff] [review]
Patch

Looks good.  r=me!
Attachment #622723 - Flags: review?(bwinton) → review+
(Assignee)

Comment 5

5 years ago
http://hg.mozilla.org/comm-central/rev/fe3609de7fc7
Assignee: nobody → florian
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 15.0
You need to log in before you can comment on or make changes to this bug.