Add logic so makeutils.mk can autoload library makefiles on demand.

RESOLVED FIXED in mozilla15

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: joey, Assigned: joey)

Tracking

(Blocks: 1 bug)

unspecified
mozilla15
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
+++ This bug was initially created as a clone of Bug #748470 +++

Split the dependency patch for 748470 into smaller pieces.

Separate out makeutils.mk edits setup to load autotargets.mk and unit test for the edits into a separate patch.
(Assignee)

Updated

5 years ago
Assignee: nobody → joey
(Assignee)

Updated

5 years ago
(Assignee)

Updated

5 years ago
Summary: mobile/android/base: dependency builds → Add logic so makeutils.mk can autoload library makefiles on demand.
(Assignee)

Comment 1

5 years ago
Created attachment 622874 [details] [diff] [review]
makeutils.mk .mk loading logic with unit tests
(Assignee)

Comment 2

5 years ago
Comment on attachment 622874 [details] [diff] [review]
makeutils.mk .mk loading logic with unit tests

makeutils.mk logic and unit tests from bug 748470

makeutils.mk modified to act as a front end loader for other library makefiles.

# Include autotargets.mk to define mkdir-deps() early:
USE_AUTOTARGETS_MK = 1
include $(topsrcdir)/config/makefiles/makeutils.mk

Unit tests setup to verify loading.
Also compile time unit test code moved out of Makefile.in and into sub-makefiles so the main makefile will be easier to read.  Timestamp dependencies added so check tests will only run when a makefile or unit test is modified.

mkdir_deps: filter the pattern '//' from strings.  Very easy to create using:
  $(call mkdir_deps,$(dir $(path)))

Also fixed a GARBAGE/clean rule.  GARBAGE_DIRS should be assigned GENERATED_DIRS not the timestamp files contained within them.
Attachment #622874 - Flags: review?(ted.mielczarek)
(Assignee)

Comment 3

5 years ago
code was tested before but another try job is in the pipeline for these isolated edits.
(Assignee)

Comment 4

5 years ago
Try job passed last night: https://tbpl.mozilla.org/?tree=Try&rev=518809ddc158
(Assignee)

Updated

5 years ago
Blocks: 751167
(Assignee)

Updated

5 years ago
Blocks: 748470
Attachment #622874 - Flags: review?(ted.mielczarek) → review+
Comment on attachment 622874 [details] [diff] [review]
makeutils.mk .mk loading logic with unit tests

Landed on inbound

http://hg.mozilla.org/integration/mozilla-inbound/rev/2006a862d66b
https://hg.mozilla.org/mozilla-central/rev/2006a862d66b
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.