+++ This bug was initially created as a clone of Bug #748470 +++ Split the dependency patch for 748470 into smaller pieces. Separate out makeutils.mk edits setup to load autotargets.mk and unit test for the edits into a separate patch.
Comment on attachment 622874 [details] [diff] [review] makeutils.mk .mk loading logic with unit tests makeutils.mk logic and unit tests from bug 748470 makeutils.mk modified to act as a front end loader for other library makefiles. # Include autotargets.mk to define mkdir-deps() early: USE_AUTOTARGETS_MK = 1 include $(topsrcdir)/config/makefiles/makeutils.mk Unit tests setup to verify loading. Also compile time unit test code moved out of Makefile.in and into sub-makefiles so the main makefile will be easier to read. Timestamp dependencies added so check tests will only run when a makefile or unit test is modified. mkdir_deps: filter the pattern '//' from strings. Very easy to create using: $(call mkdir_deps,$(dir $(path))) Also fixed a GARBAGE/clean rule. GARBAGE_DIRS should be assigned GENERATED_DIRS not the timestamp files contained within them.
code was tested before but another try job is in the pipeline for these isolated edits.
Try job passed last night: https://tbpl.mozilla.org/?tree=Try&rev=518809ddc158
Comment on attachment 622874 [details] [diff] [review] makeutils.mk .mk loading logic with unit tests Landed on inbound http://hg.mozilla.org/integration/mozilla-inbound/rev/2006a862d66b