"ASSERTION: mRequiredRadioCount about to wrap below 0!" with radio root

RESOLVED FIXED in mozilla15

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Jesse Ruderman, Assigned: mounir)

Tracking

(Blocks: 1 bug, {assertion, testcase})

Trunk
mozilla15
assertion, testcase
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Reporter)

Description

5 years ago
Created attachment 622918 [details]
testcase

1. Load the testcase.
2. Quit Firefox.

Result: An assertion fails during cycle collection.

###!!! ASSERTION: mRequiredRadioCount about to wrap below 0!: 'radioGroup->mRequiredRadioCount != 0', file content/base/src/nsDocument.cpp, line 6617

This is a "regression" from bug 750370 (before which the assertion was a noop).
(Reporter)

Comment 1

5 years ago
Created attachment 622919 [details]
stack trace
(Assignee)

Updated

5 years ago
OS: Mac OS X → All
Hardware: x86_64 → All
(Assignee)

Comment 2

5 years ago
Created attachment 623232 [details] [diff] [review]
Patch v1

I have no idea why |GetParent()| was checked before.

Unfortunately, we need to trigger the GC to write a test and the only tests that would fail with asserts are reftests/crashtests which don't allow GC to be triggered AFAIK.
Assignee: nobody → mounir
Status: NEW → ASSIGNED
Attachment #623232 - Flags: review?(bzbarsky)
Comment on attachment 623232 [details] [diff] [review]
Patch v1

This patch just rearranges the comments and moves the 'notify' init.  Based on comment 2. shouldn't something happen here with GetParent() ?
Attachment #623232 - Flags: review?(bzbarsky) → review-
(Assignee)

Comment 4

5 years ago
Created attachment 623434 [details] [diff] [review]
Patch

Arg... I changed the patch to see what I could do to test it and I forgot to revert that change.

This is the real patch I wanted to attach ;)
Attachment #623232 - Attachment is obsolete: true
Attachment #623434 - Flags: review?(bzbarsky)
Comment on attachment 623434 [details] [diff] [review]
Patch

That makes way more sense.  r=me
Attachment #623434 - Flags: review?(bzbarsky) → review+
(Assignee)

Updated

5 years ago
Target Milestone: --- → mozilla15
(Assignee)

Updated

5 years ago
Attachment #623434 - Flags: checkin+

Comment 6

5 years ago
https://hg.mozilla.org/mozilla-central/rev/89be81f8a5c7
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.