754142 - ASSERTION: Why don't we have a Window here?

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Gregor Wagner [:gwagner]]

###!!! ASSERTION: Why don't we have a Window here?: 'window', file /Users/idefix2/code/gaia/src/dom/indexedDB/IndexedDatabaseManager.cpp, line 870
WARNING: NS_ENSURE_TRUE(sop) failed: file /Users/idefix2/code/gaia/src/dom/indexedDB/CheckQuotaHelper.cpp, line 77
WARNING: SQLite returned error code 1 , Storage will convert it to NS_ERROR_FAILURE: file /Users/idefix2/code/gaia/src/storage/src/mozStoragePrivateHelpers.cpp, line 113
WARNING: Failed to rollback transaction!: file /Users/idefix2/code/gaia/src/dom/indexedDB/IDBTransaction.cpp, line 771

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Maybe khuey can take this?

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Not without a test case or any useful STR.

Comment 3

[Gregor Wagner [:gwagner]]

Use the emulator build of B2G: https://wiki.mozilla.org/Gaia/Hacking and load a bunch of contacts via "UI tests"->"Insert fake contacts"

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

Some context would have been useful in the bug report.

Comment 5

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 623738 [details] [diff] [review]
Patch

Review of attachment 623738 [details] [diff] [review]:
-----------------------------------------------------------------

We talked about this, and we think there is a better way.

Comment 6

[Gregor Wagner [:gwagner]]

Now I need a way to set dependencies to the gaia repository...
This blocks the favorite-contact feature for gaia.

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

There's a reason we track everything in Bugzilla ;-)

Comment 8

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

Comment 9

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 623817 [details] [diff] [review]
Patch

Review of attachment 623817 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/indexedDB/IndexedDatabaseManager.cpp
@@ +716,3 @@
>    NS_ENSURE_TRUE(ss, NS_ERROR_FAILURE);
>  
> +  if (mPrivilege == Content) {

Let's do != Chrome here, and below.

Comment 10

[Brad Jackson]

My build is broken with this error. I am using GCC 4.7.

../../../dist/include/mozilla/dom/indexedDB/IndexedDatabaseManager.h:72:6: error: use of enum ‘FactoryPrivilege’ without previous declaration
../../../dist/include/mozilla/dom/indexedDB/IndexedDatabaseManager.h:158:38: error: ‘FactoryPrivilege’ has not been declared

Comment 11

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Tried to land this, but GCC doesn't like forward declared enums.

Comment 12

[Gregor Wagner [:gwagner]]

Kyle, any chance you can fix this?

Comment 13

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

It's on the list.  There's another problem here we still need to solve though.  deleteDatabase uses sqlite3_quota_remove to delete files, and if we don't install the quota handler that doesn't work.

Comment 14

[Ben Turner (not reading bugmail, use the needinfo flag!)]

We need to fix this.

Comment 15

[Ben Turner (not reading bugmail, use the needinfo flag!)]

I think i fixed the places where sqlite3_quota_remove wasn't removing files (in the android test patch). And use a bool (mIsChrome? mIsPrivileged?) instead of the enum.

Comment 16

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Not blocking unprefixing since this doesn't affect web developers. But still important to fix of course.

Comment 17

[Gregor Wagner [:gwagner]]

Can we fix this now with a bool as ben suggested?

Comment 18

[Gregor Wagner [:gwagner]]

Ping! We really need this fixed.

Comment 19

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/19609455b05d

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/19609455b05d