ASSERTION: Why don't we have a Window here?

RESOLVED FIXED in mozilla17

Status

()

Core
DOM: IndexedDB
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: gwagner, Assigned: khuey)

Tracking

(Blocks: 1 bug)

unspecified
mozilla17
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(blocking-basecamp:+)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
###!!! ASSERTION: Why don't we have a Window here?: 'window', file /Users/idefix2/code/gaia/src/dom/indexedDB/IndexedDatabaseManager.cpp, line 870
WARNING: NS_ENSURE_TRUE(sop) failed: file /Users/idefix2/code/gaia/src/dom/indexedDB/CheckQuotaHelper.cpp, line 77
WARNING: SQLite returned error code 1 , Storage will convert it to NS_ERROR_FAILURE: file /Users/idefix2/code/gaia/src/storage/src/mozStoragePrivateHelpers.cpp, line 113
WARNING: Failed to rollback transaction!: file /Users/idefix2/code/gaia/src/dom/indexedDB/IDBTransaction.cpp, line 771
Maybe khuey can take this?
Not without a test case or any useful STR.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → INCOMPLETE
(Reporter)

Comment 3

5 years ago
Use the emulator build of B2G: https://wiki.mozilla.org/Gaia/Hacking and load a bunch of contacts via "UI tests"->"Insert fake contacts"
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
Created attachment 623738 [details] [diff] [review]
Patch

Some context would have been useful in the bug report.
Assignee: nobody → khuey
Status: REOPENED → ASSIGNED
Attachment #623738 - Flags: review?(bent.mozilla)
Comment on attachment 623738 [details] [diff] [review]
Patch

Review of attachment 623738 [details] [diff] [review]:
-----------------------------------------------------------------

We talked about this, and we think there is a better way.
Attachment #623738 - Flags: review?(bent.mozilla)
(Reporter)

Comment 6

5 years ago
Now I need a way to set dependencies to the gaia repository...
This blocks the favorite-contact feature for gaia.
There's a reason we track everything in Bugzilla ;-)
Created attachment 623817 [details] [diff] [review]
Patch
Attachment #623738 - Attachment is obsolete: true
Attachment #623817 - Flags: review?(bent.mozilla)
Comment on attachment 623817 [details] [diff] [review]
Patch

Review of attachment 623817 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/indexedDB/IndexedDatabaseManager.cpp
@@ +716,3 @@
>    NS_ENSURE_TRUE(ss, NS_ERROR_FAILURE);
>  
> +  if (mPrivilege == Content) {

Let's do != Chrome here, and below.
Attachment #623817 - Flags: review?(bent.mozilla) → review+

Comment 10

5 years ago
My build is broken with this error. I am using GCC 4.7.

../../../dist/include/mozilla/dom/indexedDB/IndexedDatabaseManager.h:72:6: error: use of enum ‘FactoryPrivilege’ without previous declaration
../../../dist/include/mozilla/dom/indexedDB/IndexedDatabaseManager.h:158:38: error: ‘FactoryPrivilege’ has not been declared
Tried to land this, but GCC doesn't like forward declared enums.
(Reporter)

Comment 12

5 years ago
Kyle, any chance you can fix this?
(Reporter)

Updated

5 years ago
Blocks: 674720
(Reporter)

Updated

5 years ago
Blocks: 678695
It's on the list.  There's another problem here we still need to solve though.  deleteDatabase uses sqlite3_quota_remove to delete files, and if we don't install the quota handler that doesn't work.
We need to fix this.
Blocks: 726378
I think i fixed the places where sqlite3_quota_remove wasn't removing files (in the android test patch). And use a bool (mIsChrome? mIsPrivileged?) instead of the enum.
Not blocking unprefixing since this doesn't affect web developers. But still important to fix of course.
No longer blocks: 726378
blocking-basecamp: --- → ?
blocking-basecamp: ? → +
(Reporter)

Comment 17

5 years ago
Can we fix this now with a bool as ben suggested?
(Reporter)

Updated

5 years ago
Blocks: 746439
(Reporter)

Comment 18

5 years ago
Ping! We really need this fixed.
http://hg.mozilla.org/integration/mozilla-inbound/rev/19609455b05d
https://hg.mozilla.org/mozilla-central/rev/19609455b05d
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17

Updated

5 years ago
Depends on: 780625
You need to log in before you can comment on or make changes to this bug.