754209 - OSFileConstants.cpp does not build with VC9

Status: RESOLVED FIXED

(Core :: js-ctypes, defect)

Description

[David Teller [:Yoric] - still alive but not very active]

Quote from bug 739740: « This doesn't build on VC9 because it doesn't have ELOOP, ELOOP, EOPNOTSUPP, EOVERFLOW, ETIMEDOUT or EWOULDBLOCK. »

Comment 1

[David Teller [:Yoric] - still alive but not very active]

Attachment: Patch for VC9

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 623081 [details] [diff] [review]
Patch for VC9

Neil, does this patch fix the issue for you?

Comment 3

[[e-mail]]

Comment on attachment 623081 [details] [diff] [review]
Patch for VC9

>+#if defined(ELOOP) // not defined with VC9
>   INT_CONSTANT(ELOOP),
>+#endif // defined(ELOOP)
>   INT_CONSTANT(EMFILE),
>   INT_CONSTANT(ENAMETOOLONG),
>   INT_CONSTANT(ENFILE),
>   INT_CONSTANT(ELOOP),
Still fails here ;-)

Comment 4

[David Teller [:Yoric] - still alive but not very active]

Attachment: Patch for VC9

Same one, with just one ELOOP :)

Comment 5

[David Teller [:Yoric] - still alive but not very active]

Attachment: Patch for VC9

Comment 6

[Philip Chee]

Does not apply cleanly due to bug 747872 being backed out.

Comment 7

[Philip Chee]

> Does not apply cleanly due to bug 747872 being backed out.
I guess attachment 622753 [details] [diff] [review] needs to be applied first.

Comment 8

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/6309cc2b328d

Comment 9

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/6309cc2b328d