OSFileConstants.cpp does not build with VC9

RESOLVED FIXED in mozilla15

Status

()

Core
js-ctypes
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Yoric, Assigned: Yoric)

Tracking

unspecified
mozilla15
All
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Quote from bug 739740: « This doesn't build on VC9 because it doesn't have ELOOP, ELOOP, EOPNOTSUPP, EOVERFLOW, ETIMEDOUT or EWOULDBLOCK. »
Created attachment 623081 [details] [diff] [review]
Patch for VC9
Assignee: nobody → dteller
Comment on attachment 623081 [details] [diff] [review]
Patch for VC9

Neil, does this patch fix the issue for you?
Attachment #623081 - Flags: review?(neil)

Comment 3

5 years ago
Comment on attachment 623081 [details] [diff] [review]
Patch for VC9

>+#if defined(ELOOP) // not defined with VC9
>   INT_CONSTANT(ELOOP),
>+#endif // defined(ELOOP)
>   INT_CONSTANT(EMFILE),
>   INT_CONSTANT(ENAMETOOLONG),
>   INT_CONSTANT(ENFILE),
>   INT_CONSTANT(ELOOP),
Still fails here ;-)
Created attachment 623086 [details] [diff] [review]
Patch for VC9

Same one, with just one ELOOP :)
Attachment #623081 - Attachment is obsolete: true
Attachment #623081 - Flags: review?(neil)
Attachment #623086 - Flags: review?(neil)

Updated

5 years ago
Attachment #623086 - Flags: review?(neil) → review+
Created attachment 623090 [details] [diff] [review]
Patch for VC9
Attachment #623086 - Attachment is obsolete: true
Attachment #623090 - Attachment is patch: true
Keywords: checkin-needed

Comment 6

5 years ago
Does not apply cleanly due to bug 747872 being backed out.

Comment 7

5 years ago
> Does not apply cleanly due to bug 747872 being backed out.
I guess attachment 622753 [details] [diff] [review] needs to be applied first.
Status: NEW → ASSIGNED
http://hg.mozilla.org/integration/mozilla-inbound/rev/6309cc2b328d
Keywords: checkin-needed
Target Milestone: --- → mozilla15
Keywords: checkin-needed

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/6309cc2b328d
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.