754269 - Send application version info from the front end to lattice

Status: RESOLVED FIXED

(Pancake Graveyard :: Front-end, defect)

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

This bug needs a better description. What needs to be sent? And why to Lattice?

Comment 2

[Olivier Yiptong [:oyiptong]]

I need two version numbers:

One for the ios application
Another for the JS application.

Perhaps it could be concatenated: 1.1.A.A
Where the first two characters are for the iOS app, and the subsequent two characters for the JS app.

We want the version numbers for logging purposes, and to know what people are running.

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

The iOS app already makes a method available that returns the version number:

https://bugzilla.mozilla.org/show_bug.cgi?id=754268

The frontend can pick that up.

I think my original question was more like: where exactly should this info be submitted. What is the concrete API that requires these version numbers.

Comment 4

[Olivier Yiptong [:oyiptong]]

Here's a better suggestion: the version numbers can be sent on each lattice calls as query params as follows:

e.g.

device=iPad3,3:5.1.1:1.0&client=1.0

Where device represents device information and client represents the javascript client.

device has multiple colon-separated values which are, in order: hardwareMachine, deviceSystemVersion, applicationVersion

client is just the JS application client version

Comment 5

[Olivier Yiptong [:oyiptong]]

those values can be obtained from: https://bugzilla.mozilla.org/show_bug.cgi?id=754268

Comment 6

[Gordon Brander :gordonb]

The client version number should be passed to the template layer from the Python app. We should look for the client version number in /etc/pancake/web.json.

Comment 7

[Sam Foster [:sfoster] (he/him) out until 2024-05-26]

https://bitbucket.org/mozillapancake/pancake/changeset/65596f2ec48c has changes to wrap each lattice request and add the client/device info as 'X-' request headers. This mirrors how we do the csrf token, but assign back to me if it turns out we need to add to the querystring. 

For the /views browser client, most fields are "n/a", but I provide { deviceSystemVersion: navigator.oscpu }. If you prefer I could just not include the headers/fields at all?

Comment 8

[Sam Foster [:sfoster] (he/him) out until 2024-05-26]

Also added a X-JsAppVersion header that gets its value from config.appVersion (which is populated in the config.mustache template)

Comment 9

[Olivier Yiptong [:oyiptong]]

I changed the dev proxy so that the headers go through to lattice