754369 - SSL Status is not always constructed before we call the bad cert handler or the SSL error listener

Status: RESOLVED DUPLICATE of bug 1550686

(Core :: Security: PSM, defect, P5)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

+++ This bug was initially created as a clone of Bug #739563 +++
+++ This bug was initially created as a clone of Bug #739558 +++

PSM has a bug where it does not set the SSLStatus of the socket before calling the SSL error listener.

The patches that are coming for bug 754365 should fix this.

Comment 1

[Ben Bucksch (:BenB)]

bsmith, would this fix Bug 739558 and similar "failing silently" bugs?

Comment 2

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Nope, but Thunderbird bug 739563 and the other Firefox bug would.

Comment 3

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

I have a whole series of patches written for bug 754365, which happen to fix this bug, and which are needed for other important work.

So, I am going to finalize the series of patches for bug 754365 and submit them for review, and then I'm going to keep this bug open for the tests that verify that the nsISSLStatus object is passed to the nsISSLErrorListener.

Comment 4

[Ben Bucksch (:BenB)]

bsmith writes in bug 785426 comment 57:
> nsISSLErrorListener .. socketInfo ... getInterface() ... nsITransportSecurityInfo.errorMessage
> ... your application can strip the HTML tags from the ... formatted-for-Firefox error message

Comment 5

[Dana Keeler (she/her) (use needinfo) [:keeler]]

bug 1550686 removed nsIBadCertListener2 and bug 844351 removed nsISSLErrorListener.