754521 - Win: Category buttons (.landingButtons) in in-content prefs styled as regular buttons if not -moz-windows-compositor

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Nils Maier [:nmaier]]

STR:
- Make sure Firefox does not use -moz-windows-compositor, i.e. switch your Windows theme from Glass to Basic or Classic (or use a Remote Desktop Connection).
- Open about:preferences

Expected:
The category buttons should not have the default visual styles, but instead should have no borders, no hover state and a transparent background, i.e. -moz-appearance: none, as is the case when using a Glass Windows theme or on mac.

Actual:
The category buttons are styled with -moz-appearance: button;


-moz-appearance: none is only set when building with WINSTRIPE_AERO and the -moz-windows-compositior media query is fulfilled:
http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/winstripe/global/inContentUI.css#119

A possible fix would be for the .landingButton rule to always define -moz-appearance: none, in:
http://mxr.mozilla.org/mozilla-central/source/browser/themes/pinstripe/preferences/in-content/preferences.css#17

Comment 1

[Mike Hoye [:mhoye]]

Flagging as a diamond bug. Paolo, you remain committed to mentoring this should a contributor appear?

Comment 2

[:Paolo Amadini]

(In reply to Mike Hoye [:mhoye] from comment #1)
> Flagging as a diamond bug. Paolo, you remain committed to mentoring this
> should a contributor appear?

I'm still interested in mentoring this bug, but I'm clearing the whiteboard tag because I don't have a clear picture of my availability in the next two weeks. I will register again as a mentor when I can have faster response times.

Comment 3

[Mike Hoye [:mhoye]]

Shoutout to Paolo for a great comment. Paolo, you're doing this right.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

This was fixed by bug 738796

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

(Verified on Windows 7 Basic, along with verifying that window.matchMedia("-moz-windows-compositor").matches == false))