Closed Bug 754521 Opened 12 years ago Closed 10 years ago

Win: Category buttons (.landingButtons) in in-content prefs styled as regular buttons if not -moz-windows-compositor

Categories

(Firefox :: Settings UI, defect)

All
Windows 7
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 32

People

(Reporter: nmaier, Unassigned)

References

Details

(Whiteboard: [fixed by bug 738796] p=0 s=it-32c-31a-30b.2 [qa!])

STR:
- Make sure Firefox does not use -moz-windows-compositor, i.e. switch your Windows theme from Glass to Basic or Classic (or use a Remote Desktop Connection).
- Open about:preferences

Expected:
The category buttons should not have the default visual styles, but instead should have no borders, no hover state and a transparent background, i.e. -moz-appearance: none, as is the case when using a Glass Windows theme or on mac.

Actual:
The category buttons are styled with -moz-appearance: button;


-moz-appearance: none is only set when building with WINSTRIPE_AERO and the -moz-windows-compositior media query is fulfilled:
http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/winstripe/global/inContentUI.css#119

A possible fix would be for the .landingButton rule to always define -moz-appearance: none, in:
http://mxr.mozilla.org/mozilla-central/source/browser/themes/pinstripe/preferences/in-content/preferences.css#17
Whiteboard: p=0
Whiteboard: p=0 → p=2
Whiteboard: p=2 → p=2 [mentor=paolo]
No longer blocks: fxdesktopbacklog
Flags: firefox-backlog+
Whiteboard: p=2 [mentor=paolo] → [mentor=paolo] p=2
Flagging as a diamond bug. Paolo, you remain committed to mentoring this should a contributor appear?
Flags: needinfo?(paolo.mozmail)
Whiteboard: [mentor=paolo] p=2 → [mentor=paolo] p=2 [diamond]
Whiteboard: [mentor=paolo] p=2 [diamond] → [mentor=paolo] p=2 [diamond] [good next bug]
(In reply to Mike Hoye [:mhoye] from comment #1)
> Flagging as a diamond bug. Paolo, you remain committed to mentoring this
> should a contributor appear?

I'm still interested in mentoring this bug, but I'm clearing the whiteboard tag because I don't have a clear picture of my availability in the next two weeks. I will register again as a mentor when I can have faster response times.
Flags: needinfo?(paolo.mozmail)
Whiteboard: [mentor=paolo] p=2 [diamond] [good next bug] → p=2 [diamond] [good next bug]
Shoutout to Paolo for a great comment. Paolo, you're doing this right.
This was fixed by bug 738796
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: p=2 [diamond] [good next bug] → p=0 [fixed by bug 738796]
(Verified on Windows 7 Basic, along with verifying that window.matchMedia("-moz-windows-compositor").matches == false))
Status: RESOLVED → VERIFIED
Whiteboard: p=0 [fixed by bug 738796] → [fixed by bug 738796] p=0 s=it-32c-31a-30b.2 [qa!]
Depends on: 738796
Target Milestone: --- → Firefox 32
You need to log in before you can comment on or make changes to this bug.