754620 - After enabling browser.preferences.inContent, I'm unable to set a proxy server

Status: RESOLVED DUPLICATE of bug 738797

(Firefox :: Settings UI, defect)

Description

[Brian Carpenter [:geeknik]]

I set browser.preferences.inContent to true in Nightly (Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:15.0) Gecko/15.0 Firefox/15.0a1), cset 22a58090fa70, and when I select Advanced->Network->Connection->Settings, it pops up a window with the proxy settings and No Proxy is always selected, even when I set the proxy settings to match my network. I click OK, the window goes away. Once I go back to the same Window, No Proxy is checked once again. I can verify that no proxy is being used because my real IP is displayed @ whatismyip.com. If I disable in content preferences, I can set a proxy with no issues.

Comment 1

[rdz_bug]

The problem also happens with:

Content -> JavaScrit -> Advanced
Fonts & Colors -> Advanced
Fonts & Colors -> Colors
Languages -> Choose

That is, whatever changes are made on these new windows aren't saved.

Comment 2

[Brian Carpenter [:geeknik]]

According to this post on the MozillaZine forums (http://forums.mozillazine.org/viewtopic.php?p=12014207#p12014207), it appears that this issue is not limited to just the proxy settings, but also to javascript settings. I gave the OP a link to this bug, hopefully he drops in to give us some more information.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

If you set browser.preferences.instantApply to true, is your problem fixed?

Comment 4

[Jim Jeffery not reading bug-mail 1/2/11]

(In reply to Jared Wein [:jaws] from comment #3)
> If you set browser.preferences.instantApply to true, is your problem fixed?

Yes, setting that pref does indeed save the changes.

Comment 5

[Christian Sonne [:cers]]

Attachment: Possibly fix, needs testing

I just backported this from a my working set for bug 754344, and as I'm on the way out I didn't have time test it out in a clean environment.

Further, even in my other set, I only tested it for a few dialogs, but there it seemed to work fine.

Comment 6

[Jim Jeffery not reading bug-mail 1/2/11]

(In reply to Christian Sonne [:cers] from comment #5)
> Created attachment 627553 [details] [diff] [review]
> Possibly fix, needs testing
> 
> I just backported this from a my working set for bug 754344, and as I'm on
> the way out I didn't have time test it out in a clean environment.
> 
> Further, even in my other set, I only tested it for a few dialogs, but there
> it seemed to work fine.

Did you intend to ask for a review, or are you now waiting for bug 754344 as the correct fix ?

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

I don't think we should take attachment 627553 [details] [diff] [review]. The monkey-patching there is unnecessary if we just flip the browser.preferences.instantApply pref.

Flipping that pref will be part of bug 738797.

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Since the solution to this bug is bug 738797, I'm going to resolve this as a duplicate of that bug.

If you are coming to this bug to look for a workaround, just set browser.preferences.instantApply to true in about:config.